MC-29277SSP Leaking memory when connecting and disconnecting from worlds
Steps to reproduce:
1) Enter a world
2) Hit F3 and look at the memory and on which value it drops when the GC runs.
3) Wait a minute so that more chunks load then disconnect
4) Go back to 1 and see that the value it drops to is higher then before
5) Repeat this until you'll possibly have an out of memory error
The problem here is that some of the resources of the IntegratedServerListenThread aren't released properly. Basicly netMemoryConnection field is never nulled once created and that's ok but MemoryConnection class holds a reference to NetHandler (myNetHandler) that holds references to the current world and so all the data associated with it.
myNetHandler is only nulled in closeConnections and that function is not called for the integrated server, so after stopping the integrated server that reference still holds, keeping everything in memory.
But even calling closeConnections there's a second place where references are held.. and this is in NetworkListenThread, connections field.
There connections are removed in networkTick, but what happens with the Integrated Server is that the server is stopped before it can tick and so the connections List isn't emptied.. and that again holds indirectly references to the world data.
Personally i've fixed it like this: http://pastebin.com/QHfdke9b
Linked Issues
Created Issue:
SSP Leaking memory when connecting and disconnecting from worlds
Steps to reproduce:
1) Enter a world
2) Hit F3 and look at the memory and on which value it drops when the GC runs.
3) Wait a minute so that more chunks load then disconnect
4) Go back to 1 and see that the value it drops to is higher then before
5) Repeat this until you'll possibly have an out of memory errorThe problem here is that some of the resources of the IntegratedServerListenThread aren't released properly. Basicly netMemoryConnection field is never nulled once created and that's ok but MemoryConnection class holds a reference to NetHandler (myNetHandler) that holds references to the current world and so all the data associated with it.
myNetHandler is only nulled in closeConnections and that function is not called for the integrated server, so after stopping the integrated server that reference still holds, keeping everything in memory.
But even calling closeConnections there's a second place where references are held.. and this is in NetworkListenThread, connections field.
There connections are removed in networkTick, but what happens with the Integrated Server is that the server is stopped before it can tick and so the connections List isn't emptied.. and that again holds indirectly references to the world data.Personally i've fixed it like this: http://pastebin.com/QHfdke9b
duplicates
Sorry for the duplicate, i swear i searched but didn't found this issues (probably wrong keywords). Anyway this means it will be resolved?
Because the other issues you linked is closed and Fixed but in 1.6.2 this issue still exists, so is NOT fixed.
We are unable to reproduce this issue in 1.6.2, please join the discussion in
MC-1628and provide additional information there.I'm actually unable to reproduce this bug too in vanilla.
In fact i wrongly tested this with Forge, just because the problem was leading me to vanilla code.
What was happening is that due to Forge another reference didn't get cleaned and while IntegratedServer keeps those references to the world, when you load again a world the memory gets reused/freed, but due to that Forge problem it wasn't happening.
Sorry again for the wrong report.