MC-121719Enchantment GUI's book opening and closing animation is rendered at approximatly 20fps, even if actual framerate is higher
In 1.11.2 the enchantment GUI's book animation opened and closed smoothly, at the the same framerate as the game was running. In 1.12.2 (and in snapshot 17w45a) the animation jumps between positions, staying in a single one for a few frames.
From the equivalent forge code (1.12.2, MCP data version "snapshot_20170629") it appears that minecraft calls GuiScreen.drawScreen with a parameter for partialTicks with Minecraft.getTickLength() rather than Minecraft.getRenderPartialTicks(). (The former is the amount of time, in ticks, from when the last frame was rendered, the latter is the amount of time, in ticks, since the last tick). Note that this is reproducible without forge, so it is not caused by a broken forge patch, but it is more obvious in modded GUI's that have larger animated elements than the enchanting table.
Created Issue:
Enchantment GUI's book opening and closing animation is rendered at approximatly 20fps, even if actual framerate is higher
In 1.11.2 the enchantment GUI's book animation opened and closed smoothly, at the the same framerate as the game was running. In 1.12.2 (and in snapshot 17w45a) the animation jumps between positions, staying in a single one for a few frames.
From the equivalent forge code (1.12.2, MCP data version "snapshot_20170629") it appears that minecraft calls GuiScreen.drawScreen with a parameter for "partialTicks" with "Minecraft.getTickLength()" rather than "Minecraft.getRenderPartialTicks()". (The former is the amount of time, in ticks, from when the last frame was rendered, the latter is the amount of time, in ticks, since the last tick). Note that this issue is reproducible without forge, so it is not caused by a broken forge patch, it is just much more obvious in modded GUI's that have larger animated elements than the enchanting table.
Environment
Minecraft launcher 1.6.84-j, (Unknown Java version, I assume it's the one that's shipped with the launcher).
Minecraft launcher 1.6.84-j, (Unknown Java version, I assume it's the one that's shipped with the launcher).
Minecraft launcher 1.6.84-j
In 1.11.2 the enchantment GUI's book animation opened and closed smoothly, at the the same framerate as the game was running. In 1.12.2 (and in snapshot 17w45a) the animation jumps between positions, staying in a single one for a few frames.
From the equivalent forge code (1.12.2, MCP data version "snapshot_20170629") it appears that minecraft calls GuiScreen.drawScreen with a parameter for "partialTicks" with "Minecraft.getTickLength()" rather than "Minecraft.getRenderPartialTicks()". (The former is the amount of time, in ticks, from when the last frame was rendered, the latter is the amount of time, in ticks, since the last tick). Note that this
issueis reproducible without forge, so it is not caused by a broken forge patch,it is just muchmore obvious in modded GUI's that have larger animated elements than the enchanting table.In 1.11.2 the enchantment GUI's book animation opened and closed smoothly, at the the same framerate as the game was running. In 1.12.2 (and in snapshot 17w45a) the animation jumps between positions, staying in a single one for a few frames.
From the equivalent forge code (1.12.2, MCP data version "snapshot_20170629") it appears that minecraft calls GuiScreen.drawScreen with a parameter for "partialTicks" with "Minecraft.getTickLength()" rather than "Minecraft.getRenderPartialTicks()". (The former is the amount of time, in ticks, from when the last frame was rendered, the latter is the amount of time, in ticks, since the last tick). Note that this is reproducible without forge, so it is not caused by a broken forge patch, but it is more obvious in modded GUI's that have larger animated elements than the enchanting table.
![[Mojang] Georgii Gavrichev](../../../data/avatars/users/22428.png){kind=small}
[Mojang] Georgii Gavrichev![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
In 1.11.2 the enchantment GUI's book animation opened and closed smoothly, at the the same framerate as the game was running. In 1.12.2 (and in snapshot 17w45a) the animation jumps between positions, staying in a single one for a few frames.
From the equivalent forge code (1.12.2, MCP data version "snapshot_20170629") it appears that minecraft calls GuiScreen.drawScreen with a parameter for "partialTicks" with "Minecraft.getTickLength()" rather than "Minecraft.getRenderPartialTicks()". (The former is the amount of time, in ticks, from when the last frame was rendered, the latter is the amount of time, in ticks, since the last tick). Note that this is reproducible without forge, so it is not caused by a broken forge patch, but it is more obvious in modded GUI's that have larger animated elements than the enchanting table.
In 1.11.2 the enchantment GUI's book animation opened and closed smoothly, at the the same framerate as the game was running. In 1.12.2 (and in snapshot 17w45a) the animation jumps between positions, staying in a single one for a few frames.
From the equivalent forge code (1.12.2, MCP data version "snapshot_20170629") it appears that minecraft calls GuiScreen.drawScreen with a parameter for partialTicks with Minecraft.getTickLength() rather than Minecraft.getRenderPartialTicks(). (The former is the amount of time, in ticks, from when the last frame was rendered, the latter is the amount of time, in ticks, since the last tick). Note that this is reproducible without forge, so it is not caused by a broken forge patch, but it is more obvious in modded GUI's that have larger animated elements than the enchanting table.
Minecraft launcher 1.6.84-j
I thought something seemed iffy about that recently !