Changing or reloading resource packs does not reload core shaders until reloading a second time
When applying or removing resource packs with core shaders, the core shaders do not get reloaded and instead use the core shaders from the last reload. The core shaders only update after pressing F3+T after changing resource packs.
This also happens if you make an edit to a core shader and reload with F3+T. The change will only show if you press F3+T a second time.
The output log will also be filled with "Double closing program" warnings on reloads (relates to MC-226660).
To reproduce:
- Download the provided resource pack
- Make a world with solid blocks in it like stone
- Apply the resource pack
Observe that the solid blocks are not red- Press F3+T
- Observe that the solid blocks are now red
- Edit rendertype_solid.fsh in the resource pack and change the fragColor to vec4(0.0, 1.0, 0.0, 1.0)
- Press F3+T
Observe that the solid blocks are still red and not green- Press F3+T
- Observe that the solid blocks are now green
- Remove the resource pack
Observe that the solid blocks are still green- Press F3+T
- Observe that the solid blocks are now normal
Created Issue:
Changing resource packs does not reload core shaders until pressing F3+T
When applying or removing resource packs with core shaders, the core shaders do not get reloaded and instead use the core shaders from the last reload. The core shaders only update after pressing F3+T after changing resource packs.
To reproduce:
- Download the provided resource pack
- Make a world with solid blocks in it like stone
- Apply the resource pack
Observe that the solid blocks are not red
- Press F3+T
- Observe that the solid blocks are now red
- Remove the resource pack
Observe that the solid blocks are still red
- Press F3+T
- Observe that the solid blocks are now back to normal
Changing resource packs does not reload core shaders untilpressing F3+TChanging or reloading resource packs does not reload core shaders until reloading a second time
When applying or removing resource packs with core shaders, the core shaders do not get reloaded and instead use the core shaders from the last reload. The core shaders only update after pressing F3+T after changing resource packs.
This also happens if you make an edit to a core shader and reload with F3+T. The change will only show if you press F3+T a second time.
To reproduce:
- Download the provided resource pack
- Make a world with solid blocks in it like stone
- Apply the resource pack
Observe that the solid blocks are not red
- Press F3+T
- Observe that the solid blocks are now red
- Remove the resource pack
Observe that the solid blocks are still red
- Press F3+T
- Observe that the solid blocks are now back to normal
When applying or removing resource packs with core shaders, the core shaders do not get reloaded and instead use the core shaders from the last reload. The core shaders only update after pressing F3+T after changing resource packs.
This also happens if you make an edit to a core shader and reload with F3+T. The change will only show if you press F3+T a second time.
To reproduce:
- Download the provided resource pack
- Make a world with solid blocks in it like stone
- Apply the resource pack
Observe that the solid blocks are not red
- Press F3+T
- Observe that the solid blocks are now red
- Remove the resource pack
Observe that the solid blocks are still red
- Press F3+T
- Observe that the solid blocks are now
back to normalWhen applying or removing resource packs with core shaders, the core shaders do not get reloaded and instead use the core shaders from the last reload. The core shaders only update after pressing F3+T after changing resource packs.
This also happens if you make an edit to a core shader and reload with F3+T. The change will only show if you press F3+T a second time.
To reproduce:
- Download the provided resource pack
- Make a world with solid blocks in it like stone
- Apply the resource pack
Observe that the solid blocks are not red
- Press F3+T
- Observe that the solid blocks are now red
- (Additional testing steps for editing rp)
- Edit rendertype_solid.fsh in the resource pack and change the fragColor to vec4(0.0, 1.0, 0.0, 1.0)
- Press F3+T
Observe that the solid blocks are still red and not green
- Press F3+T
- Observe that the solid blocks are now green
When applying or removing resource packs with core shaders, the core shaders do not get reloaded and instead use the core shaders from the last reload. The core shaders only update after pressing F3+T after changing resource packs.
This also happens if you make an edit to a core shader and reload with F3+T. The change will only show if you press F3+T a second time.
To reproduce:
- Download the provided resource pack
- Make a world with solid blocks in it like stone
- Apply the resource pack
Observe that the solid blocks are not red
- Press F3+T
- Observe that the solid blocks are now red
- (Additional testing steps for editing rp)
- Edit rendertype_solid.fsh in the resource pack and change the fragColor to vec4(0.0, 1.0, 0.0, 1.0)
- Press F3+T
Observe that the solid blocks are still red and not green
- Press F3+T
- Observe that the solid blocks are now green
- Remove the resource pack
Observe that the solid blocks are still green
- Press F3+T
- Observe that the solid blocks are now normal
When applying or removing resource packs with core shaders, the core shaders do not get reloaded and instead use the core shaders from the last reload. The core shaders only update after pressing F3+T after changing resource packs.
This also happens if you make an edit to a core shader and reload with F3+T. The change will only show if you press F3+T a second time.
To reproduce:
- Download the provided resource pack
- Make a world with solid blocks in it like stone
- Apply the resource pack
Observe that the solid blocks are not red
- Press F3+T
- Observe that the solid blocks are now red
(Additional testing steps for editing rp)- Edit rendertype_solid.fsh in the resource pack and change the fragColor to vec4(0.0, 1.0, 0.0, 1.0)
- Press F3+T
Observe that the solid blocks are still red and not green
- Press F3+T
- Observe that the solid blocks are now green
- Remove the resource pack
Observe that the solid blocks are still green
- Press F3+T
- Observe that the solid blocks are now normal
When applying or removing resource packs with core shaders, the core shaders do not get reloaded and instead use the core shaders from the last reload. The core shaders only update after pressing F3+T after changing resource packs.
This also happens if you make an edit to a core shader and reload with F3+T. The change will only show if you press F3+T a second time.
To reproduce:
- Download the provided resource pack
- Make a world with solid blocks in it like stone
- Apply the resource pack
Observe that the solid blocks are not red
- Press F3+T
- Observe that the solid blocks are now red
- Edit rendertype_solid.fsh in the resource pack and change the fragColor to vec4(0.0, 1.0, 0.0, 1.0)
- Press F3+T
Observe that the solid blocks are still red and not green
- Press F3+T
- Observe that the solid blocks are now green
- Remove the resource pack
Observe that the solid blocks are still green
- Press F3+T
- Observe that the solid blocks are now normal
When applying or removing resource packs with core shaders, the core shaders do not get reloaded and instead use the core shaders from the last reload. The core shaders only update after pressing F3+T after changing resource packs.
This also happens if you make an edit to a core shader and reload with F3+T. The change will only show if you press F3+T a second time.
The output log will also be filled with "Double closing program" warnings (relates to
MC-226660).
To reproduce:
- Download the provided resource pack
- Make a world with solid blocks in it like stone
- Apply the resource pack
Observe that the solid blocks are not red
- Press F3+T
- Observe that the solid blocks are now red
- Edit rendertype_solid.fsh in the resource pack and change the fragColor to vec4(0.0, 1.0, 0.0, 1.0)
- Press F3+T
Observe that the solid blocks are still red and not green
- Press F3+T
- Observe that the solid blocks are now green
- Remove the resource pack
Observe that the solid blocks are still green
- Press F3+T
- Observe that the solid blocks are now normal
When applying or removing resource packs with core shaders, the core shaders do not get reloaded and instead use the core shaders from the last reload. The core shaders only update after pressing F3+T after changing resource packs.
This also happens if you make an edit to a core shader and reload with F3+T. The change will only show if you press F3+T a second time.
The output log will also be filled with "Double closing program" warnings on reloads (relates to
MC-226660).
To reproduce:
- Download the provided resource pack
- Make a world with solid blocks in it like stone
- Apply the resource pack
Observe that the solid blocks are not red
- Press F3+T
- Observe that the solid blocks are now red
- Edit rendertype_solid.fsh in the resource pack and change the fragColor to vec4(0.0, 1.0, 0.0, 1.0)
- Press F3+T
Observe that the solid blocks are still red and not green
- Press F3+T
- Observe that the solid blocks are now green
- Remove the resource pack
Observe that the solid blocks are still green
- Press F3+T
- Observe that the solid blocks are now normal