MC-271786Empty block states in noise_provider does not cause validation to fail, causing crash
Summary
When noise_provider block state provider has empty states, it should cause pack validation to fail; currently it does not, instead causing a crash. (This issue exists in 1.20.6 as well.)
Steps to Reproduce
- Add the attached pack.
- Get a pair of boots with the enchantment test:noise.
- Wear it.
Expected Result
The data pack should fail to validate.
Actual Result
Game crashes.
![[Bot] Arisa](../../../data/avatars/users/43007.png){kind=small}
Created Issue:
Empty block states in noise_provider does not cause validation to fail, causing crash
Summary
When noise_provider block state provider has empty states, it should cause pack validation to fail; currently it does not, instead causing a crash. (This issue exists in 1.20.6 as well.)Steps to Reproduce
- Add the attached pack.
- Get a pair of boots with the enchantment test:noise.
- Wear it.
Expected Result
The data pack should fail to validate.Actual Result
Game crashes.
Attachments2
Added Attachments:
![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}
Removed Category: (Unassigned)
![[Mod] Chandler](../../../data/assets/gravatar/triwonder81.png){kind=small}
Added Affects Versions: 1.21
![[Mojang] Triage Team](../../../data/avatars/users/89842.png){kind=small}
Added Mojang Priority: 
Important
Important![[Bot] Piston](../../../data/avatars/users/31202.png){kind=small}
This also affects the minecraft:noise_threshold_provider block state provider's low_states and high_states fields, though the code paths are unrelated.
Code analysis (Yarn mappings)
These issues come from unchecked list sizes in the NoiseBlockStateProvider#getStateAtValue and NoiseThresholdBlockStateProvider#get methods.
The fix is the same for both: replacing the Codec.list(BlockState.CODEC) fields with Codecs.nonEmptyList(BlockState.CODEC). This is the same approach that, for example, world generation features take.