MC-272224'in_bounding_box' vertical position for 'spawn_particles' effect is anchored incorrectly
While working on a project of mine, I noticed that when I set the 'vertical_position' config in the 'spawn_particles' effect in the 'post_attack' component, particles weren't spawning in the upper half of attacked mob's bounding box. After a few tests, I discovered that the missing particles were spawning below the hit mob, and the maximum downwards distance from the entity's bounding box was equal to half the height of its hitbox. This likely suggests that the particles are anchored at the attacked mob's feet rather than the center of its bounding box.
This does not happen with 'horizontal_position' or with any other effect component.
EDIT: after further further testing in 1.21-pre1, I can confirm that this happens with EVERY effect component. I don't know if its always been the case and I can't test it
Steps to reproduce
Below I have attached a data pack with a singular enchantment that can be applied to a Diamond Sword with '/enchant @s bug:particle_post_damage'. Simply apply the enchantment to the sword and attack any mob. Notice that no particles are spawning in the upper part of its bounding box, and if done over see-through blocks (Glass, Barriers, etc.), some particles spawn underground, below hit entity.
I have also attached a screenshot of the issue. Notice how a lot of particles spawn under the attacked Husk, but none spawn near its head (or generally in the upper part of its hitbox, as I have previously mentioned), but some spawn below the Iron Block floor. The Husk had had its scale attribute set to 3 for showcase purposes, but the issue also happens if the scale is set to 1 (default). I set my entity_interaction_range attribute to 100 so that I can attack it from a distance to make the particles as visible as possible
Environment
Windows 10, Java 21.0.3
Created Issue:
'in_bounding_box' vertical position for 'spawn_particles' effect is anchored incorrectly when used in 'post_attack' effect component
While working on a project of mine, I noticed that when I set the 'vertical_position' config in the 'spawn_particles' effect in the 'post_attack' component, particles weren't spawning in the upper half of attacked mob's bounding box. After a few tests, I discovered that the missing particles were spawning below the hit mob, and the maximum downwards distance from the entity's bounding box was equal to half the height of its hitbox. This likely suggests that the particles are anchored at the attacked mob's feet rather than the center of its bounding box.
This does not happen with 'horizontal_position' or with any other effect component.
Steps to reproduce
Below I have attached a data pack with a singular enchantment that can be applied to a Diamond Sword with '/enchant kohara_ bug:particle_post_damage'. Simply apply the enchantment to the sword and attack any mob. Notice that no particles are spawning in the upper part of its bounding box, and if done over see-through blocks (Glass, Barriers, etc.), some particles spawn underground, below hit entity.
I have also attached a screenshot of the issue. Notice how a lot of particles spawn under the attacked Husk, but none spawn near its head (or generally in the upper part of its hitbox, as I have previously mentioned), but some spawn below the Iron Block floor. The Husk had had its scale attribute set to 3 for showcase purposes, but the issue also happens if the scale is set to 1 (default). I set my entity_interaction_range attribute to 100 so that I can attack it from a distance to make the particles as visible as possible
Environment
Windows 10, Java 21.0.3
Attachments2
While working on a project of mine, I noticed that when I set the 'vertical_position' config in the 'spawn_particles' effect in the 'post_attack' component, particles weren't spawning in the upper half of attacked mob's bounding box. After a few tests, I discovered that the missing particles were spawning below the hit mob, and the maximum downwards distance from the entity's bounding box was equal to half the height of its hitbox. This likely suggests that the particles are anchored at the attacked mob's feet rather than the center of its bounding box.
This does not happen with 'horizontal_position' or with any other effect component.
Steps to reproduce
Below I have attached a data pack with a singular enchantment that can be applied to a Diamond Sword with '/enchant
kohara_bug:particle_post_damage'. Simply apply the enchantment to the sword and attack any mob. Notice that no particles are spawning in the upper part of its bounding box, and if done over see-through blocks (Glass, Barriers, etc.), some particles spawn underground, below hit entity.
I have also attached a screenshot of the issue. Notice how a lot of particles spawn under the attacked Husk, but none spawn near its head (or generally in the upper part of its hitbox, as I have previously mentioned), but some spawn below the Iron Block floor. The Husk had had its scale attribute set to 3 for showcase purposes, but the issue also happens if the scale is set to 1 (default). I set my entity_interaction_range attribute to 100 so that I can attack it from a distance to make the particles as visible as possible
While working on a project of mine, I noticed that when I set the 'vertical_position' config in the 'spawn_particles' effect in the 'post_attack' component, particles weren't spawning in the upper half of attacked mob's bounding box. After a few tests, I discovered that the missing particles were spawning below the hit mob, and the maximum downwards distance from the entity's bounding box was equal to half the height of its hitbox. This likely suggests that the particles are anchored at the attacked mob's feet rather than the center of its bounding box.
This does not happen with 'horizontal_position' or with any other effect component.
Steps to reproduce
Below I have attached a data pack with a singular enchantment that can be applied to a Diamond Sword with '/enchant @s bug:particle_post_damage'. Simply apply the enchantment to the sword and attack any mob. Notice that no particles are spawning in the upper part of its bounding box, and if done over see-through blocks (Glass, Barriers, etc.), some particles spawn underground, below hit entity.
I have also attached a screenshot of the issue. Notice how a lot of particles spawn under the attacked Husk, but none spawn near its head (or generally in the upper part of its hitbox, as I have previously mentioned), but some spawn below the Iron Block floor. The Husk had had its scale attribute set to 3 for showcase purposes, but the issue also happens if the scale is set to 1 (default). I set my entity_interaction_range attribute to 100 so that I can attack it from a distance to make the particles as visible as possible
While working on a project of mine, I noticed that when I set the 'vertical_position' config in the 'spawn_particles' effect in the 'post_attack' component, particles weren't spawning in the upper half of attacked mob's bounding box. After a few tests, I discovered that the missing particles were spawning below the hit mob, and the maximum downwards distance from the entity's bounding box was equal to half the height of its hitbox. This likely suggests that the particles are anchored at the attacked mob's feet rather than the center of its bounding box.
This does not happen with 'horizontal_position' or with any other effect component.
EDIT: after further further testing in 1.21-pre1, I can confirm that this happens with EVERY effect component. I don't know if its always been the case and I can't test it
Steps to reproduce
Below I have attached a data pack with a singular enchantment that can be applied to a Diamond Sword with '/enchant @s bug:particle_post_damage'. Simply apply the enchantment to the sword and attack any mob. Notice that no particles are spawning in the upper part of its bounding box, and if done over see-through blocks (Glass, Barriers, etc.), some particles spawn underground, below hit entity.
I have also attached a screenshot of the issue. Notice how a lot of particles spawn under the attacked Husk, but none spawn near its head (or generally in the upper part of its hitbox, as I have previously mentioned), but some spawn below the Iron Block floor. The Husk had had its scale attribute set to 3 for showcase purposes, but the issue also happens if the scale is set to 1 (default). I set my entity_interaction_range attribute to 100 so that I can attack it from a distance to make the particles as visible as possible
'in_bounding_box' vertical position for 'spawn_particles' effect is anchored incorrectlywhen used in 'post_attack' effect component
![[Mojang] Triage Team](../../../data/avatars/users/89842.png){kind=small}
Normal![[Mojang] slicedlime](../../../data/assets/gravatar/slicedlime.jpeg){kind=small}
[Mojang] slicedlime![[Bot] Piston](../../../data/avatars/users/31202.png){kind=small}
I haven't tested it on versions earlier than 24w20a, but I am quite sure that this has been an issue since 24w18a, when the enchantments were made data-driven
UPDATE: I can confirm it still being that way in 1.21-pre1. Furthermore, I can confirm that this issue wasn't limited to just the 'post_attack' component, as it actually affects every effect component