MC-266248No error message when granting/revoking an advancement that is already granted/revoked
The bug
As of 23w41a, no error message is displayed when using /advancement to grant an advancement that is already attained, or when trying to revoke an advancement that is not attained.
The error message strings still exist, e.g. commands.advancement.grant.one.to.one.failure, but they are no longer displayed.
How to reproduce
- /gamerule sendCommandFeedback true
- /advancement revoke @s everything
- /advancement revoke @s only story/mine_stone
→
No error message is displayed - /advancement grant @s only story/mine_stone
→
You are granted the advancement, and command feedback is displayed - /advancement grant @s only story/mine_stone
→ No error message is displayed
Expected results
The following error messages should be displayed:
Couldn't revoke advancement [Stone Age] from <PLAYER> as they don't have it
Couldn't grant advancement [Stone Age] to <PLAYER> as they already have it
These messages are displayed in 23w40a and earlier.
![[Mod] j_p_smith](../../../data/avatars/users/92851.png){kind=small}
Created Issue:
No error message when granting/revoking an advancement that is already granted/revoked
The bug
As of 23w41a, no error message is displayed when using /advancement to grant an advancement that is already attained, or when trying to revoke an advancement that is not attained.
Additionally, no "success" or "result" is returned at all when using /execute store (this can be used to verify that 23w41a is affected).
How to reproduce
- /gamerule sendCommandFeedback true
- /advancement revoke @s everything
- /advancement revoke @s only story/mine_stone
→- /advancement grant @s only story/mine_stone
→- /advancement grant @s only story/mine_stone
→Expected results
The following error messages should be displayed:
Couldn't revoke advancement [Stone Age] from <PLAYER> as they don't have itCouldn't grant advancement [Stone Age] to <PLAYER> as they already have itThese messages are displayed in 23w40a and earlier.
![[Mod] turbo](../../../data/avatars/users/92867.png){kind=small}
![[Mojang] Timur Nazarov](../../../data/avatars/users/18945.svg){kind=small}
ImportantThe bug
As of 23w41a, no error message is displayed when using /advancement to grant an advancement that is already attained, or when trying to revoke an advancement that is not attained.
Additionally, no "success" or "result" is returned at all when using/execute store(this can be used to verify that 23w41a is affected).How to reproduce
- /gamerule sendCommandFeedback true
- /advancement revoke @s everything
- /advancement revoke @s only story/mine_stone
→- /advancement grant @s only story/mine_stone
→- /advancement grant @s only story/mine_stone
→Expected results
The following error messages should be displayed:
Couldn't revoke advancement [Stone Age] from <PLAYER> as they don't have itCouldn't grant advancement [Stone Age] to <PLAYER> as they already have itThese messages are displayed in 23w40a and earlier.
The bug
As of 23w41a, no error message is displayed when using /advancement to grant an advancement that is already attained, or when trying to revoke an advancement that is not attained.
The error message strings still exist, e.g. commands.advancement.grant.one.to.one.failure, but they are no longer displayed.
How to reproduce
- /gamerule sendCommandFeedback true
- /advancement revoke @s everything
- /advancement revoke @s only story/mine_stone
→- /advancement grant @s only story/mine_stone
→- /advancement grant @s only story/mine_stone
→Expected results
The following error messages should be displayed:
Couldn't revoke advancement [Stone Age] from <PLAYER> as they don't have itCouldn't grant advancement [Stone Age] to <PLAYER> as they already have itThese messages are displayed in 23w40a and earlier.
![[Mojang] eowyn36](../../../data/avatars/users/18935.svg){kind=small}
[Mojang] eowyn36![[Bot] Piston](../../../data/avatars/users/31202.png){kind=small}
Can confirm.