MCL-15522Crowdin translation request popups are not removed if the language is changed
The bug
I do not know if this is intentional or if this is unintentional.
When changing to a language that is not fully translated on Crowdin, a popup will appear asking the user if they'd like to help out with translations. If they then change their language again (maybe they selected the first language by mistake?), the popup for the previous language will remain (and a new popup will appear if the new language needs Crowdin translations).
Maybe I should say that popups are persistent and are not removed without the user removing them.
How to reproduce
- Open Minecraft Launcher and navigate to the settings menu
- Change your language to random languages until you get a Crowdin popup
- Change your language to English - US (a language that does not need Crowdin translation)
- Observe that the popup from the previous language is persistent and is not removed and does not fade away eventually
![[Mod] markderickson](../../../data/avatars/users/18946.svg){kind=small}
Created Issue:
Crowdin translation request popups are not removed if the language is changed
The bug
I do not know if this is intentional or if this is unintentional.
When changing to a language that is not fully translated on Crowdin, a popup will appear asking the user if they'd like to help out with translations. If they then change their language again (maybe they selected the first language by mistake?), the popup for the previous language will remain (and a new popup will appear if the new language needs Crowdin translations).
Maybe I should say that popups are persistent and are not removed without the user removing them.
How to reproduce
- Open Minecraft Launcher and navigate to the settings menu
- Change your language to random languages until you get a Crowdin popup
- Change your language to English - US (a language that does not need Crowdin translation)
- Observe that the popup from the previous language is persistent and is not removed and does not fade away eventually
The bug
Popups can get cut off incorrectly in certain cases. The launcher tries to ensure that if there are too many popups on the screen, they get cut off properly. However, when the language is set to Bahasa Melayu - Malaysia (please note that this probably isn't a Crowdin translation issue because it has nothing to do with translations), the launcher is in full screen mode on a 1440x900 monitor, and enough Crowdin popups are being shown so that they take up the space from the top to the bottom of the screen (maybe using the steps provided in MCL-15522?), then the uppermost popup is cut off incorrectly.
How to reproduce
- Set your screen resolution to 1440x900 in System Preferences
- Open the Minecraft Launcher and navigate to the settings page
- Click the green button in the menu bar to put your window into full screen mode
- Repeat the steps in
MCL-15522as many times as needed until no more popups can fit from the top to the bottom of the screen - Set your language to Bahasa Melayu - Malaysia
- Observe how the uppermost popup is cut off incorrectly, as shown in the screenshot above
As designed