Wesley Wolfe
- wolvereness
- wolvereness
- Europe/Stockholm
- Yes
- No
1 issues
Key
Summary
Status
Reporter
Assignee
Created
MC-5246Changed Summary:
Crash on thrown enchant from arrow in dispenserCrash on thorn enchant from arrow in dispenser
This is still 1.6.4, and likely snapshots.
Affected files (for this specific instance) are
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/RecipeFireworks.java#L60
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/RecipeFireworks.java#L81
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/BlockSkull.java#L93
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/ItemStack.java#L365 (on-enchant, however, enchants only work on unstackable items)
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/ItemStack.java#L386 (on-enchant, however, enchants only work on unstackable items)
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/ItemEnchantedBook.java#L45 (on-enchant, however, enchants only work on unstackable items)
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/ItemArmor.java#L75 (unstackable)
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/RecipeMapExtend.java#L47 (unstackable)
I suggest a fix of making the internal tag variable to be private (although nothing currently uses it), and add a 'rename' to the set-method, as performed in https://github.com/Bukkit/CraftBukkit/commit/e6087ea3fb84381e44efa981283cd33a77b981ec#diff-598d7c50bd4d7a7fcde8ba1dbd299de9R337 to fix all current (and future) instances of this problem.
Alternatively, all of the compounds can be initialized with the proper name on creation (but CB can't fix that without lots of diffs).
Fixing this issue, as described, also fixes this other issue, which I believe should be linked (as they have the same internal-cause):
https://mojang.atlassian.net/browse/MC-30468
Linking our internal CraftBukkit reported issue: https://bukkit.atlassian.net/browse/BUKKIT-4809