MC-13565Fireworks sometimes don't stack when they should
I have been working on producing fireworks that announce the start of nighttime. I had started producing fireworks with duration 3, white big balls. I had produced two batches; one of 19 and one of 8 (blame inconsistant gunpowder supplies). I had previously launched one from the batch of 19, as sort of a test fire, before going out for more gunpowder. After coming back, I produced the batch of 8, and tried to merge them with the existing stack of 18; the two stacks swapped instead, as they do when trying to swap different items. Eventually, after fiddling around with splitting the old stack, I was able to merge them all to a stack of 26.
I had found possible duplicates in a search prior to creating the issue; however, they were all closed as incomplete. Note however that I had only been looking at the summary field, on a search of 'MC firework stack'.
Possibly related (inversely) to MC-5214. That issue was resolved as fixed; the "fix" might be causing this bug. However, it being fixed was merely an assumption.
If I get the issue to occur again, I'll hold the stacks and upload my level.dat file. I still have to craft 6 more to get my desired count of 32 fireworks; I'll craft them in groups of 2.
— Receipe Trace —
6 BlazeRod -> 12 BlazePowder
11 Coal + 11 BlazePowder + 11 Gunpowder -> 33 FireCharge
11 Bone -> 33 BoneMeal
33 FireCharge + 33 BoneMeal + 33 Gunpowder -> 33 FireworkStar (White, BigBall)
57 Gunpowder + 19 Paper + 19 FireworkStar => Fireworks[19]
Fireworks[19] + RMB => Fireworks[18]
– Save? –
24 Gunpowder + 8 Paper + 8 FireworkStar => Fireworks[8]
Fireworks[8] + Fireworks[18] => Fireworks[18] + Fireworks[8]
– Messed around with splitting and merging stacks –
=> Fireworks[26]
– Save –
18 Gunpowder + 6 Paper + 6 FireworkStar => Fireworks[6]
– Does not merge with saved stack –
-- Save –
-- Upload level.dat –
Fireworks[6] + Fireworks[26] => Fireworks[32]
Environment
Same as MC-13505, but Java is 7.0.170.2
Linked Issues
Attachments1
Created Issue:
Fireworks sometimes don't stack when they should
I have been working on producing fireworks that announce the start of nighttime. I had started producing fireworks with duration 3, white big balls. I had produced two batches; one of 19 and one of 8 (blame inconsistant gunpowder supplies). I had previously launched one from the batch of 19, as sort of a test fire, before going out for more gunpowder. After coming back, I produced the batch of 8, and tried to merge them with the existing stack of 18; the two stacks swapped instead, as they do when trying to swap different items. Eventually, after fiddling around with splitting the old stack, I was able to merge them all to a stack of 26.
I had found possible duplicates in a search prior to creating the issue; however, they were all closed as incomplete. Note however that I had only been looking at the summary field, on a search of 'MC firework stack'.
Possibly related (inversely) to
MC-5214. That issue was resolved as fixed; the "fix" might be causing this bug. However, it being fixed was merely an assumption.If I get the issue to occur again, I'll hold the stacks and upload my level.dat file. I still have to craft 6 more to get my desired count of 32 fireworks; I'll craft them in groups of 2.
Environment
Same as
MC-13505, but Java is 7.0.170.2
I have been working on producing fireworks that announce the start of nighttime. I had started producing fireworks with duration 3, white big balls. I had produced two batches; one of 19 and one of 8 (blame inconsistant gunpowder supplies). I had previously launched one from the batch of 19, as sort of a test fire, before going out for more gunpowder. After coming back, I produced the batch of 8, and tried to merge them with the existing stack of 18; the two stacks swapped instead, as they do when trying to swap different items. Eventually, after fiddling around with splitting the old stack, I was able to merge them all to a stack of 26.
I had found possible duplicates in a search prior to creating the issue; however, they were all closed as incomplete. Note however that I had only been looking at the summary field, on a search of 'MC firework stack'.
Possibly related (inversely) to
MC-5214. That issue was resolved as fixed; the "fix" might be causing this bug. However, it being fixed was merely an assumption.If I get the issue to occur again, I'll hold the stacks and upload my level.dat file. I still have to craft 6 more to get my desired count of 32 fireworks; I'll craft them in groups of 2.
— Receipe Trace —
6 BlazeRod -> 12 BlazePowder
11 Coal + 11 BlazePowder + 11 Gunpowder -> 33 FireCharge
11 Bone -> 33 BoneMeal
33 FireCharge + 33 BoneMeal + 33 Gunpowder -> 33 FireworkStar (White, BigBall)57 Gunpowder + 19 Paper + 19 FireworkStar => Fireworks[19]
Fireworks[19] + RMB => Fireworks[18]
– Save? –
24 Gunpowder + 8 Paper + 8 FireworkStar => Fireworks[8]
Fireworks[8] + Fireworks[18] => Fireworks[18] + Fireworks[8]
– Messed around with splitting and merging stacks –
=> Fireworks[26]
– Save –
18 Gunpowder + 6 Paper + 6 FireworkStar => Fireworks[6]
– Does not merge with saved stack –
-- Save –
-- Upload level.dat –
Fireworks[6] + Fireworks[26] => Fireworks[32]
is duplicated by
Is this still a concern in the current Minecraft version 1.6.2 / Launcher version 1.1.3 ? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.
Okay, my batch of 6 merged correctly, but wouldn't merge with my stack of 26.
EDIT: Just loaded up the inventory with INVedit for MC 1.4...
To me, it claims that the two should stack properly (both ID 401, damage 0, stacks of 6 and 26). Gonna look at the tag tree myself, I think.
EDIT²: Look identical to me, less slot ID and stack count.
Please provide steps to reproduce your problem by using the Bug Report Guidelines Here.
Added what I recall of the steps.
It looks to me like fireworks crafted in the current session will not stack merge with fireworks from a prior session until save and reload. There might be some additional data [verification needed] attached to fireworks when crafted, which is not saved. This also explains why the stacks merge after reloading, as well as why they are identical in the savegame.
Check the timing on each stack of rockets again. 1 stack could be 3 second, while the other says 2 sec or 1 sec.
(I've been messing around with Tekkit, sorry for the delay)
(No, not modded MC for this issue)
I do not entirely understand what you are saying. The rockets all are practically identical; and become perfectly identical when the game is saved.
I can also confirm that I get a similar bug in Tekkit Lite, running MC 1.4.7, so the bug has been around since then at least; however it is with the mod-added redstone batteries rather than the fireworks. However, I believe that the core reason is identical. I will try testing the issue in a vanilla 1.4.7 at some point; if the issue still holds, we will know that the cause is not related to the Redstone Update.
This is still 1.6.4, and likely snapshots.
Affected files (for this specific instance) are
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/RecipeFireworks.java#L60
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/RecipeFireworks.java#L81
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/BlockSkull.java#L93
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/ItemStack.java#L365 (on-enchant, however, enchants only work on unstackable items)
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/ItemStack.java#L386 (on-enchant, however, enchants only work on unstackable items)
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/ItemEnchantedBook.java#L45 (on-enchant, however, enchants only work on unstackable items)
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/ItemArmor.java#L75 (unstackable)
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/RecipeMapExtend.java#L47 (unstackable)
I suggest a fix of making the internal tag variable to be private (although nothing currently uses it), and add a 'rename' to the set-method, as performed in https://github.com/Bukkit/CraftBukkit/commit/e6087ea3fb84381e44efa981283cd33a77b981ec#diff-598d7c50bd4d7a7fcde8ba1dbd299de9R337 to fix all current (and future) instances of this problem.
Alternatively, all of the compounds can be initialized with the proper name on creation (but CB can't fix that without lots of diffs).
Fixing this issue, as described, also fixes this other issue, which I believe should be linked (as they have the same internal-cause):
https://mojang.atlassian.net/browse/MC-30468
Linking our internal CraftBukkit reported issue: https://bukkit.atlassian.net/browse/BUKKIT-4809
Updated relations to currently existing issues.
After further research, discovered to be fixed in a 1.7 snapshot