MC-186455Persistent villagers without experience can despawn after converting to a witch
The bug
If a villager with no experience and {PersistenceRequired: 1b} is struck by lightning and converted into a witch, the witch that replaces the villager will have {PersistenceRequired: 0b}.
Code analysis (Yarn mappings)
LOGGER.info("Villager {} was struck by lightning {}.", this, lightning); WitchEntity witchEntity = (WitchEntity)EntityType.WITCH.create(this.world); witchEntity.refreshPositionAndAngles(this.getX(), this.getY(), this.getZ(), this.yaw, this.pitch); witchEntity.initialize(this.world, this.world.getLocalDifficulty(witchEntity.getBlockPos()), SpawnReason.CONVERSION, (EntityData)null, (CompoundTag)null); witchEntity.setAiDisabled(this.isAiDisabled()); if (this.hasCustomName()) { witchEntity.setCustomName(this.getCustomName()); witchEntity.setCustomNameVisible(this.isCustomNameVisible()); } // Unlike other conversion code, this does not check whether this.isPersistent() as well if (this.getExperience() > 0) { witchEntity.setPersistent(); } this.world.spawnEntity(witchEntity); this.remove();
Attachments1
NormalCreated Issue:
Villager to witch conversion loses persistence if the villager is not experienced
If a villager with no experience and
{PersistenceRequired: 1b}is struck by lightning and converted into a witch, the witch that replaces the villager will have
{PersistenceRequired: 0b}.
Code analysis (Yarn mappings)
LOGGER.info("Villager {} was struck by lightning {}.", this, lightning); WitchEntity witchEntity = (WitchEntity)EntityType.WITCH.create(this.world); witchEntity.refreshPositionAndAngles(this.getX(), this.getY(), this.getZ(), this.yaw, this.pitch); witchEntity.initialize(this.world, this.world.getLocalDifficulty(witchEntity.getBlockPos()), SpawnReason.CONVERSION, (EntityData)null, (CompoundTag)null); witchEntity.setAiDisabled(this.isAiDisabled()); if (this.hasCustomName()) { witchEntity.setCustomName(this.getCustomName()); witchEntity.setCustomNameVisible(this.isCustomNameVisible()); } // Unlike other conversion code, this does not check whether this.isPersistent() as well if (this.getExperience() > 0) { witchEntity.setPersistent(); } this.world.spawnEntity(witchEntity); this.remove();
Attachments1
Changed Description:
If a villager with no experience and
{PersistenceRequired: 1b}is struck by lightning and converted into a witch, the witch that replaces the villager will have
{PersistenceRequired: 0b}.
Code analysis (Yarn mappings)
LOGGER.info("Villager {} was struck by lightning {}.", this, lightning); WitchEntity witchEntity = (WitchEntity)EntityType.WITCH.create(this.world); witchEntity.refreshPositionAndAngles(this.getX(), this.getY(), this.getZ(), this.yaw, this.pitch); witchEntity.initialize(this.world, this.world.getLocalDifficulty(witchEntity.getBlockPos()), SpawnReason.CONVERSION, (EntityData)null, (CompoundTag)null); witchEntity.setAiDisabled(this.isAiDisabled()); if (this.hasCustomName()) { witchEntity.setCustomName(this.getCustomName()); witchEntity.setCustomNameVisible(this.isCustomNameVisible()); } // Unlike other conversion code, this does not check whether this.isPersistent() as well if (this.getExperience() > 0) { witchEntity.setPersistent(); } this.world.spawnEntity(witchEntity); this.remove();If a villager with no experience and
{PersistenceRequired: 1b}is struck by lightning and converted into a witch, the witch that replaces the villager will have
{PersistenceRequired: 0b}.
Code analysis (Yarn mappings)
LOGGER.info("Villager {} was struck by lightning {}.", this, lightning); WitchEntity witchEntity = (WitchEntity)EntityType.WITCH.create(this.world); witchEntity.refreshPositionAndAngles(this.getX(), this.getY(), this.getZ(), this.yaw, this.pitch); witchEntity.initialize(this.world, this.world.getLocalDifficulty(witchEntity.getBlockPos()), SpawnReason.CONVERSION, (EntityData)null, (CompoundTag)null); witchEntity.setAiDisabled(this.isAiDisabled()); if (this.hasCustomName()) { witchEntity.setCustomName(this.getCustomName()); witchEntity.setCustomNameVisible(this.isCustomNameVisible()); } // Unlike other conversion code, this does not check whether this.isPersistent() as well if (this.getExperience() > 0) { witchEntity.setPersistent(); } this.world.spawnEntity(witchEntity); this.remove();
![[Mod] violine1101](../../../data/avatars/users/92858.png){kind=small}
Removed Category: (Unassigned)
Changed Summary:
Villagerto witch conversion loses persistenceif the villageris notexperiencedVillagers hit by a lightning strike can despawn if the villager has no experience
Changed Description:
If a villager with no experience and
{PersistenceRequired: 1b}is struck by lightning and converted into a witch, the witch that replaces the villager will have
{PersistenceRequired: 0b}.
Code analysis (Yarn mappings)
LOGGER.info("Villager {} was struck by lightning {}.", this, lightning); WitchEntity witchEntity = (WitchEntity)EntityType.WITCH.create(this.world); witchEntity.refreshPositionAndAngles(this.getX(), this.getY(), this.getZ(), this.yaw, this.pitch); witchEntity.initialize(this.world, this.world.getLocalDifficulty(witchEntity.getBlockPos()), SpawnReason.CONVERSION, (EntityData)null, (CompoundTag)null); witchEntity.setAiDisabled(this.isAiDisabled()); if (this.hasCustomName()) { witchEntity.setCustomName(this.getCustomName()); witchEntity.setCustomNameVisible(this.isCustomNameVisible()); } // Unlike other conversion code, this does not check whether this.isPersistent() as well if (this.getExperience() > 0) { witchEntity.setPersistent(); } this.world.spawnEntity(witchEntity); this.remove();If a villager with no experience and {PersistenceRequired: 1b} is struck by lightning and converted into a witch, the witch that replaces the villager will have {PersistenceRequired: 0b}.
Code analysis (Yarn mappings)
LOGGER.info("Villager {} was struck by lightning {}.", this, lightning); WitchEntity witchEntity = (WitchEntity)EntityType.WITCH.create(this.world); witchEntity.refreshPositionAndAngles(this.getX(), this.getY(), this.getZ(), this.yaw, this.pitch); witchEntity.initialize(this.world, this.world.getLocalDifficulty(witchEntity.getBlockPos()), SpawnReason.CONVERSION, (EntityData)null, (CompoundTag)null); witchEntity.setAiDisabled(this.isAiDisabled()); if (this.hasCustomName()) { witchEntity.setCustomName(this.getCustomName()); witchEntity.setCustomNameVisible(this.isCustomNameVisible()); } // Unlike other conversion code, this does not check whether this.isPersistent() as well if (this.getExperience() > 0) { witchEntity.setPersistent(); } this.world.spawnEntity(witchEntity); this.remove();
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
Changed Description:
The bug
If a villager with no experience and {PersistenceRequired: 1b} is struck by lightning and converted into a witch, the witch that replaces the villager will have {PersistenceRequired: 0b}.
Code analysis (Yarn mappings)
LOGGER.info("Villager {} was struck by lightning {}.", this, lightning); WitchEntity witchEntity = (WitchEntity)EntityType.WITCH.create(this.world); witchEntity.refreshPositionAndAngles(this.getX(), this.getY(), this.getZ(), this.yaw, this.pitch); witchEntity.initialize(this.world, this.world.getLocalDifficulty(witchEntity.getBlockPos()), SpawnReason.CONVERSION, (EntityData)null, (CompoundTag)null); witchEntity.setAiDisabled(this.isAiDisabled()); if (this.hasCustomName()) { witchEntity.setCustomName(this.getCustomName()); witchEntity.setCustomNameVisible(this.isCustomNameVisible()); } // Unlike other conversion code, this does not check whether this.isPersistent() as well if (this.getExperience() > 0) { witchEntity.setPersistent(); } this.world.spawnEntity(witchEntity); this.remove();
Changed Summary:
Villagershitby a lightning strike can despawn if the villager has no experiencePersistent villagers without experience can despawn after converting to a witch
Added Assignee: ![[Mojang] Panda](../../../data/avatars/users/41658.png)
[Mojang] Panda
[Mojang] Panda![[Mojang] Adrian Östergård](../../../data/assets/gravatar/nighter.jpeg){kind=small}
![[Bot] Piston](../../../data/avatars/users/31202.png){kind=small}
Added Fixed Versions: 1.16-pre1