MC-265697After breaking a brush, the player's off-hand can't finish using some items
When a player breaks a brush after brushing a suspicious sand/or suspicious gravel block and continues to hold down the 'use' button, they will not be able to properly finish using some items.
Steps to Reproduce:
- Get a brush with 1 durrability, a suspicious sand, and a food item.
/give @s brush[minecraft:damage=63]
- Make sure the player is hungry
/effect give @p hunger 2 255
- Hold the food item in the off-hand, and the brush in the main hand
- Brush the suspicious gravel
Observed Results:
The player will brush the gravel to completion, but after the brush breaks and the player starts trying to eat the food item, they will be stuck in the animation unable to finish eating it completely.
Expected Results:
The player would brush the block, and eat the item.
Screenshots/Videos:
Code Analysis \ Possible Fix \ Mcp-Reborn 1.20.2
Here near the end of this method, the game checks for which hand the player is holding the brush in, and then will damage and/or break it. The problem lies in that the game does not properly state that the player has actually stopped using the item.
To fix this, first a check is done to see if the item's damage is equal to it's max damage (broken), and if it is, the player will stop using the item
Class: net\minecraft\world\item\BrushItem.java Method: onUseTick()
. . .
level.playSound(player, blockpos, soundevent, SoundSource.BLOCKS);
if (!level.isClientSide()) {
BlockEntity blockentity = level.getBlockEntity(blockpos);
if (blockentity instanceof BrushableBlockEntity) {
BrushableBlockEntity brushableblockentity = (BrushableBlockEntity)blockentity;
boolean flag1 = brushableblockentity.brush(level.getGameTime(), player, blockhitresult.getDirection());
if (flag1) {
EquipmentSlot equipmentslot = itemStack.equals(player.getItemBySlot(EquipmentSlot.OFFHAND)) ? EquipmentSlot.OFFHAND : EquipmentSlot.MAINHAND;
itemStack.hurtAndBreak(1, livingEntity, (livingEntity1) -> livingEntity1.broadcastBreakEvent(equipmentslot));
Fix Start
if (itemStack.getDamageValue() == itemStack.getMaxDamage()) {
player.stopUsingItem();
}
Fix End
}
}
}
. . .
This fix provides the following behavior:
2023-10-07_23-15-29.mp4
Notes:
- This issue relates to MC-168573
- This specifically affects using tridents, bows/crossbows, and food.
![[Mod] Jiingy](../../../data/avatars/users/91802.png){kind=small}
![[Mojang] Billy Sjöberg](../../../data/avatars/users/42806.png){kind=small}
LowCreated Issue:
After breaking a brush, the player's off-hand can't finish using some items
When a player breaks a brush after brushing a suspicious sand/or suspicious gravel block and continues to hold down the 'use' button, they will not be able to properly finish using some items.
Steps to Reproduce:
- Get a brush with 1 durrability, a suspicious sand, and a food item.
/give @p brush{Damage:63}- Make sure the player is hungry
/effect give @p hunger 2 254- Hold the food item in the off-hand, and the brush in the main hand
- Brush the suspicious gravel
Observed Results:
The player will brush the gravel to completion, but after the brush breaks and the player starts trying to eat the food item, they will be stuck in the animation unable to finish eating it completely.
Expected Results:
The player would brush the block, and eat the item.
Screenshots/Videos:
Code Analysis \ Possible Fix \ Mcp-Reborn 1.20.2
Here near the end of this method, the game checks for which hand the player is holding the brush in, and then will damage and/or break it. The problem lies in that the game does not properly state that the player has actually stopped using the item.
To fix this, first a check is done to see if the item's damage is equal to it's max damage (broken), and if it is, the player will stop using the item
Class: net\minecraft\world\item\BrushItem.java Method: onUseTick(). . . level.playSound(player, blockpos, soundevent, SoundSource.BLOCKS); if (!level.isClientSide()) { BlockEntity blockentity = level.getBlockEntity(blockpos); if (blockentity instanceof BrushableBlockEntity) { BrushableBlockEntity brushableblockentity = (BrushableBlockEntity)blockentity; boolean flag1 = brushableblockentity.brush(level.getGameTime(), player, blockhitresult.getDirection()); if (flag1) { EquipmentSlot equipmentslot = itemStack.equals(player.getItemBySlot(EquipmentSlot.OFFHAND)) ? EquipmentSlot.OFFHAND : EquipmentSlot.MAINHAND; itemStack.hurtAndBreak(1, livingEntity, (livingEntity1) -> livingEntity1.broadcastBreakEvent(equipmentslot)); Fix Start if (itemStack.getDamageValue() == itemStack.getMaxDamage()) { player.stopUsingItem(); } Fix End } } } . . .This fix provides the following behavior:
2023-10-07_23-15-29.mp4Notes:
- This issue relates to MC-168573
- This specifically affects using tridents, bows/crossbows, and food.
![[Mod] j_p_smith](../../../data/avatars/users/92851.png){kind=small}
![[Mod] Les3awe](../../../data/avatars/users/79847.png){kind=small}
![[Mojang] Maxime Lebrot](../../../data/avatars/users/18941.svg){kind=small}
When a player breaks a brush after brushing a suspicious sand/or suspicious gravel block and continues to hold down the 'use' button, they will not be able to properly finish using some items.
Steps to Reproduce:
- Get a brush with 1 durrability, a suspicious sand, and a food item.
/give @pbrush{Damage:63}- Make sure the player is hungry
/effect give @p hunger 2254- Hold the food item in the off-hand, and the brush in the main hand
- Brush the suspicious gravel
Observed Results:
The player will brush the gravel to completion, but after the brush breaks and the player starts trying to eat the food item, they will be stuck in the animation unable to finish eating it completely.
Expected Results:
The player would brush the block, and eat the item.
Screenshots/Videos:
Code Analysis \ Possible Fix \ Mcp-Reborn 1.20.2
Here near the end of this method, the game checks for which hand the player is holding the brush in, and then will damage and/or break it. The problem lies in that the game does not properly state that the player has actually stopped using the item.
To fix this, first a check is done to see if the item's damage is equal to it's max damage (broken), and if it is, the player will stop using the item
Class: net\minecraft\world\item\BrushItem.java Method: onUseTick(). . . level.playSound(player, blockpos, soundevent, SoundSource.BLOCKS); if (!level.isClientSide()) { BlockEntity blockentity = level.getBlockEntity(blockpos); if (blockentity instanceof BrushableBlockEntity) { BrushableBlockEntity brushableblockentity = (BrushableBlockEntity)blockentity; boolean flag1 = brushableblockentity.brush(level.getGameTime(), player, blockhitresult.getDirection()); if (flag1) { EquipmentSlot equipmentslot = itemStack.equals(player.getItemBySlot(EquipmentSlot.OFFHAND)) ? EquipmentSlot.OFFHAND : EquipmentSlot.MAINHAND; itemStack.hurtAndBreak(1, livingEntity, (livingEntity1) -> livingEntity1.broadcastBreakEvent(equipmentslot)); Fix Start if (itemStack.getDamageValue() == itemStack.getMaxDamage()) { player.stopUsingItem(); } Fix End } } } . . .This fix provides the following behavior:
2023-10-07_23-15-29.mp4Notes:
- This issue relates to MC-168573
- This specifically affects using tridents, bows/crossbows, and food.
When a player breaks a brush after brushing a suspicious sand/or suspicious gravel block and continues to hold down the 'use' button, they will not be able to properly finish using some items.
Steps to Reproduce:
- Get a brush with 1 durrability, a suspicious sand, and a food item.
/give @s brush[minecraft:damage=63]- Make sure the player is hungry
/effect give @p hunger 2 127- Hold the food item in the off-hand, and the brush in the main hand
- Brush the suspicious gravel
Observed Results:
The player will brush the gravel to completion, but after the brush breaks and the player starts trying to eat the food item, they will be stuck in the animation unable to finish eating it completely.
Expected Results:
The player would brush the block, and eat the item.
Screenshots/Videos:
Code Analysis \ Possible Fix \ Mcp-Reborn 1.20.2
Here near the end of this method, the game checks for which hand the player is holding the brush in, and then will damage and/or break it. The problem lies in that the game does not properly state that the player has actually stopped using the item.
To fix this, first a check is done to see if the item's damage is equal to it's max damage (broken), and if it is, the player will stop using the item
Class: net\minecraft\world\item\BrushItem.java Method: onUseTick(). . . level.playSound(player, blockpos, soundevent, SoundSource.BLOCKS); if (!level.isClientSide()) { BlockEntity blockentity = level.getBlockEntity(blockpos); if (blockentity instanceof BrushableBlockEntity) { BrushableBlockEntity brushableblockentity = (BrushableBlockEntity)blockentity; boolean flag1 = brushableblockentity.brush(level.getGameTime(), player, blockhitresult.getDirection()); if (flag1) { EquipmentSlot equipmentslot = itemStack.equals(player.getItemBySlot(EquipmentSlot.OFFHAND)) ? EquipmentSlot.OFFHAND : EquipmentSlot.MAINHAND; itemStack.hurtAndBreak(1, livingEntity, (livingEntity1) -> livingEntity1.broadcastBreakEvent(equipmentslot)); Fix Start if (itemStack.getDamageValue() == itemStack.getMaxDamage()) { player.stopUsingItem(); } Fix End } } } . . .This fix provides the following behavior:
2023-10-07_23-15-29.mp4Notes:
- This issue relates to MC-168573
- This specifically affects using tridents, bows/crossbows, and food.
When a player breaks a brush after brushing a suspicious sand/or suspicious gravel block and continues to hold down the 'use' button, they will not be able to properly finish using some items.
Steps to Reproduce:
- Get a brush with 1 durrability, a suspicious sand, and a food item.
/give @s brush[minecraft:damage=63]- Make sure the player is hungry
/effect give @p hunger 2127- Hold the food item in the off-hand, and the brush in the main hand
- Brush the suspicious gravel
Observed Results:
The player will brush the gravel to completion, but after the brush breaks and the player starts trying to eat the food item, they will be stuck in the animation unable to finish eating it completely.
Expected Results:
The player would brush the block, and eat the item.
Screenshots/Videos:
Code Analysis \ Possible Fix \ Mcp-Reborn 1.20.2
Here near the end of this method, the game checks for which hand the player is holding the brush in, and then will damage and/or break it. The problem lies in that the game does not properly state that the player has actually stopped using the item.
To fix this, first a check is done to see if the item's damage is equal to it's max damage (broken), and if it is, the player will stop using the item
Class: net\minecraft\world\item\BrushItem.java Method: onUseTick(). . . level.playSound(player, blockpos, soundevent, SoundSource.BLOCKS); if (!level.isClientSide()) { BlockEntity blockentity = level.getBlockEntity(blockpos); if (blockentity instanceof BrushableBlockEntity) { BrushableBlockEntity brushableblockentity = (BrushableBlockEntity)blockentity; boolean flag1 = brushableblockentity.brush(level.getGameTime(), player, blockhitresult.getDirection()); if (flag1) { EquipmentSlot equipmentslot = itemStack.equals(player.getItemBySlot(EquipmentSlot.OFFHAND)) ? EquipmentSlot.OFFHAND : EquipmentSlot.MAINHAND; itemStack.hurtAndBreak(1, livingEntity, (livingEntity1) -> livingEntity1.broadcastBreakEvent(equipmentslot)); Fix Start if (itemStack.getDamageValue() == itemStack.getMaxDamage()) { player.stopUsingItem(); } Fix End } } } . . .This fix provides the following behavior:
2023-10-07_23-15-29.mp4Notes:
- This issue relates to MC-168573
- This specifically affects using tridents, bows/crossbows, and food.
When a player breaks a brush after brushing a suspicious sand/or suspicious gravel block and continues to hold down the 'use' button, they will not be able to properly finish using some items.
Steps to Reproduce:
- Get a brush with 1 durrability, a suspicious sand, and a food item.
/give @s brush[minecraft:damage=63]- Make sure the player is hungry
/effect give @p hunger 2 255- Hold the food item in the off-hand, and the brush in the main hand
- Brush the suspicious gravel
Observed Results:
The player will brush the gravel to completion, but after the brush breaks and the player starts trying to eat the food item, they will be stuck in the animation unable to finish eating it completely.
Expected Results:
The player would brush the block, and eat the item.
Screenshots/Videos:
Code Analysis \ Possible Fix \ Mcp-Reborn 1.20.2
Here near the end of this method, the game checks for which hand the player is holding the brush in, and then will damage and/or break it. The problem lies in that the game does not properly state that the player has actually stopped using the item.
To fix this, first a check is done to see if the item's damage is equal to it's max damage (broken), and if it is, the player will stop using the item
Class: net\minecraft\world\item\BrushItem.java Method: onUseTick(). . . level.playSound(player, blockpos, soundevent, SoundSource.BLOCKS); if (!level.isClientSide()) { BlockEntity blockentity = level.getBlockEntity(blockpos); if (blockentity instanceof BrushableBlockEntity) { BrushableBlockEntity brushableblockentity = (BrushableBlockEntity)blockentity; boolean flag1 = brushableblockentity.brush(level.getGameTime(), player, blockhitresult.getDirection()); if (flag1) { EquipmentSlot equipmentslot = itemStack.equals(player.getItemBySlot(EquipmentSlot.OFFHAND)) ? EquipmentSlot.OFFHAND : EquipmentSlot.MAINHAND; itemStack.hurtAndBreak(1, livingEntity, (livingEntity1) -> livingEntity1.broadcastBreakEvent(equipmentslot)); Fix Start if (itemStack.getDamageValue() == itemStack.getMaxDamage()) { player.stopUsingItem(); } Fix End } } } . . .This fix provides the following behavior:
2023-10-07_23-15-29.mp4Notes:
- This issue relates to MC-168573
- This specifically affects using tridents, bows/crossbows, and food.
Related to MC-265697, which has recently been triaged. I mention that, as this issue is identical to the other, just with a different item.