MC-266540Players can't remove items from invulnerable item frames
The Bug
Although players remove items via left-clicking, it shouldn't be thought as damaging the item frames and cancel it.
How to Reproduce
- Place a item frame.
- Insert a item into that item frame.
- Change the invulnerable field to be true:
/data modify entity <item_frame> Invulnerable set value 1b
- Try to remove the item.
It doesn't affect insertion and rotation.
Code Analysis
This was due to the lack of further detection (decompiled 1.20.2 using vanilla mapping):
public boolean hurt(DamageSource $$0, float $$1) { ... if (isInvulnerableTo($$0)) return false; ... }
LowCreated Issue:
Players can't remove items from invulnerable item frames
The Bug
Although players remove items via left-clicking, it shouldn't be thought as damaging the item frames and cancel it.
How to Reproduce
- Place a item frame.
- Insert a item into that item frame.
- Change the invulnerable field to be true:
/data modify entity <item_frame> Invulnerable set value 1b- Try to remove it.
It doesn't affect insertion and rotation.
The Bug
Although players remove items via left-clicking, it shouldn't be thought as damaging the item frames and cancel it.
How to Reproduce
- Place a item frame.
- Insert a item into that item frame.
- Change the invulnerable field to be true:
/data modify entity <item_frame> Invulnerable set value 1b- Try to remove
it.
It doesn't affect insertion and rotation.
The Bug
Although players remove items via left-clicking, it shouldn't be thought as damaging the item frames and cancel it.
How to Reproduce
- Place a item frame.
- Insert a item into that item frame.
- Change the invulnerable field to be true:
/data modify entity <item_frame> Invulnerable set value 1b
- Try to remove the item.
It doesn't affect insertion and rotation.
Code Analysis
This was due to the lack of further detection (decompiled 1.20.2 using vanilla mapping:
net.minecraft.world.entity.decoration.ItemFrame.classpublic boolean hurt(DamageSource $$0, float $$1) { ... if (isInvulnerableTo($$0)) return false; ... }
![[Mod] turbo](../../../data/avatars/users/92867.png){kind=small}
The Bug
Although players remove items via left-clicking, it shouldn't be thought as damaging the item frames and cancel it.
How to Reproduce
- Place a item frame.
- Insert a item into that item frame.
- Change the invulnerable field to be true:
/data modify entity <item_frame> Invulnerable set value 1b
- Try to remove the item.
It doesn't affect insertion and rotation.
Code Analysis
This was due to the lack of further detection (decompiled 1.20.2 using vanilla mapping:
net.minecraft.world.entity.decoration.ItemFrame.classpublic boolean hurt(DamageSource $$0, float $$1) { ... if (isInvulnerableTo($$0)) return false; ... }The Bug
Although players remove items via left-clicking, it shouldn't be thought as damaging the item frames and cancel it.
How to Reproduce
- Place a item frame.
- Insert a item into that item frame.
- Change the invulnerable field to be true:
/data modify entity <item_frame> Invulnerable set value 1b- Try to remove the item.
It doesn't affect insertion and rotation.
Code Analysis
This was due to the lack of further detection (decompiled 1.20.2 using vanilla mapping):
net.minecraft.world.entity.decoration.ItemFrame.classpublic boolean hurt(DamageSource $$0, float $$1) { ... if (isInvulnerableTo($$0)) return false; ... }
![[Mod] ampolive](../../../data/avatars/users/18949.svg){kind=small}
![[Mojang] Maxime Lebrot](../../../data/avatars/users/18941.svg){kind=small}
![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}