MC-271159Banner pattern entries without colors are invalidated when upgrading to 1.20.5
In Minecraft 1.20.4, banner pattern entries without a color would default to white. For example, the following command would produce a black banner with a 'White Base Dexter Canton' pattern:
/give @s black_banner{BlockEntityTag:{Patterns:[{Pattern:"bl"}]}}
Upon upgrading to Minecraft 1.20.5, this pattern entry is removed from the banner in its block and item forms. I would expect the pattern to remain, including with the white color, as data loss is not expected between upgrades. Note that previous issues of this class have been considered valid, such as MC-268854 for firework rocket's Type.
This issue seems to be caused by the data fixer not setting a default color, meaning the data is invalidated in component serialization/deserialization.
The input NBT from 1.20.4 is:
{
"id": "minecraft:black_banner",
"Count": 1,
"tag": {
"BlockEntityTag": {
"Patterns": [{
"Pattern": "bl"
}]
}
}
}
This NBT gets upgraded to the following in 1.20.5:
{
"count": 1,
"components": {
"minecraft:banner_patterns": [{
"pattern": "minecraft:square_bottom_left"
}]
},
"id": "minecraft:black_banner"
}
When parsing, an exception is thrown due to the color key being missing:
java.lang.IllegalStateException: No key color in MapLike[{pattern:"minecraft:square_bottom_left"}]; Not a map: "minecraft:square_bottom_left" missed input: {"minecraft:banner_patterns":[{pattern:"minecraft:square_bottom_left"}
Created Issue:
Banner pattern entries without colors are invalidated when upgrading to 1.20.5
In Minecraft 1.20.4, banner pattern entries without a color would default to white. For example, the following command would produce a black banner with a 'White Base Dexter Canton' pattern:
/give @s black_banner{BlockEntityTag:{Patterns:[{Pattern:"bl"}]}}Upon upgrading to Minecraft 1.20.5, this pattern entry is removed from the banner in its block and item forms. I would expect the pattern to remain, including with the white color, as data loss is not expected between upgrades.
This issue seems to be caused by the data fixer not setting a default color, meaning the data is invalidated in component serialization/deserialization.
The input NBT from 1.20.4 is:
{ "id": "minecraft:black_banner", "Count": 1, "tag": { "BlockEntityTag": { "Patterns": [{ "Pattern": "bl" }] } } }This NBT gets upgraded to the following in 1.20.5:
{ "count": 1, "components": { "minecraft:banner_patterns": [{ "pattern": "minecraft:square_bottom_left" }] }, "id": "minecraft:black_banner" }When parsing, an exception is thrown due to the color key being missing:
java.lang.IllegalStateException: No key color in MapLike[{pattern:"minecraft:square_bottom_left"}]; Not a map: "minecraft:square_bottom_left" missed input: {"minecraft:banner_patterns":[{pattern:"minecraft:square_bottom_left"}
![[Mod] turbo](../../../data/avatars/users/92867.png){kind=small}
In Minecraft 1.20.4, banner pattern entries without a color would default to white. For example, the following command would produce a black banner with a 'White Base Dexter Canton' pattern:
/give @s black_banner{BlockEntityTag:{Patterns:[{Pattern:"bl"}]}}Upon upgrading to Minecraft 1.20.5, this pattern entry is removed from the banner in its block and item forms. I would expect the pattern to remain, including with the white color, as data loss is not expected between upgrades.
This issue seems to be caused by the data fixer not setting a default color, meaning the data is invalidated in component serialization/deserialization.
The input NBT from 1.20.4 is:
{ "id": "minecraft:black_banner", "Count": 1, "tag": { "BlockEntityTag": { "Patterns": [{ "Pattern": "bl" }] } } }This NBT gets upgraded to the following in 1.20.5:
{ "count": 1, "components": { "minecraft:banner_patterns": [{ "pattern": "minecraft:square_bottom_left" }] }, "id": "minecraft:black_banner" }When parsing, an exception is thrown due to the color key being missing:
java.lang.IllegalStateException: No key color in MapLike[{pattern:"minecraft:square_bottom_left"}]; Not a map: "minecraft:square_bottom_left" missed input: {"minecraft:banner_patterns":[{pattern:"minecraft:square_bottom_left"}In Minecraft 1.20.4, banner pattern entries without a color would default to white. For example, the following command would produce a black banner with a 'White Base Dexter Canton' pattern:
/give @s black_banner{BlockEntityTag:{Patterns:[{Pattern:"bl"}]}}Upon upgrading to Minecraft 1.20.5, this pattern entry is removed from the banner in its block and item forms. I would expect the pattern to remain, including with the white color, as data loss is not expected between upgrades. Note that previous issues of this class have been considered valid, such as
MC-268854for firework rocket's Type.This issue seems to be caused by the data fixer not setting a default color, meaning the data is invalidated in component serialization/deserialization.
The input NBT from 1.20.4 is:
{ "id": "minecraft:black_banner", "Count": 1, "tag": { "BlockEntityTag": { "Patterns": [{ "Pattern": "bl" }] } } }This NBT gets upgraded to the following in 1.20.5:
{ "count": 1, "components": { "minecraft:banner_patterns": [{ "pattern": "minecraft:square_bottom_left" }] }, "id": "minecraft:black_banner" }When parsing, an exception is thrown due to the color key being missing:
java.lang.IllegalStateException: No key color in MapLike[{pattern:"minecraft:square_bottom_left"}]; Not a map: "minecraft:square_bottom_left" missed input: {"minecraft:banner_patterns":[{pattern:"minecraft:square_bottom_left"}
![[Mojang] Triage Team](../../../data/avatars/users/89842.png){kind=small}
Important![[Bot] Arisa](../../../data/avatars/users/43007.png){kind=small}
![[Mojang] Gegy](../../../data/avatars/users/10122.svg){kind=small}
[Mojang] Gegy![[Bot] Piston](../../../data/avatars/users/31202.png){kind=small}