MC-68941Rotated maps in item frames are turned when updating to 1.8
When updating a world from the 1.7 format to the 1.8 format, maps in item frames become rotated twice as much as they should be.
This is closely related to bug MC-45892
This is likely related to the 1.8 feature of being able to rotate items in item frames by 45 degrees instead of 90. This requires multiplying ItemRotation by 2 for each item frame when updating it from 1.7 to 1.8.
However, maps in item frames still rotate by 90 degrees for every ItemRotation, so they become rotated twice as much as they should be.
Some possible ways to fix this:
1. When updating item frames from 1.7 to 1.8, check if the item contained is a map. If so, do nothing. Else, multiply ItemRotation by 2.
When a player rotates an item frame containing a map in the future, keep ItemRotation in the range 0-3.
2. Redefine ItemRotation for item frames containing maps, so that they are always one of
{0, 2, 4, 6}.
Steps to reproduce:
- Load a world in 1.7.10
- Get an item frame and a map.
- Place the item frame on a wall and place the map in it.
- Right click the item frame to rotate the map once.
- Notice how the map has rotated 90 degrees
- Close Minecraft.
- Load the same world in 1.8
- Notice how the map is now rotated by 180 degrees.
Environment
Windows 7
Java 1.7.0_55 64 bit
Linked Issues
Created Issue:
Updating 1.7 to 1.8 is wrong for item frames containing maps
When updating a world from the 1.7 format to the 1.8 format, maps in item frames become rotated twice as much as they should be.
This is closely related to bug MC-45892
This is likely related to the 1.8 feature of being able to rotate items in item frames by 45 degrees instead of 90. This requires multiplying ItemRotation by 2 for each item frame when updating it from 1.7 to 1.8.
However, maps in item frames still rotate by 90 degrees for every ItemRotation, so they become rotated twice as much as they should be.Some possible ways to fix this:
1. When updating item frames from 1.7 to 1.8, check if the item contained is a map. If so, do nothing. Else, multiply ItemRotation by 2.
When a player rotates an item frame containing a map in the future, keep ItemRotation in the range 0-3.2. Redefine ItemRotation for item frames containing maps, so that they are always one of
{0, 2, 4, 6}.
Steps to reproduce:
- Load a world in 1.7.10
- Get an item frame and a map.
- Place the item frame on a wall and place the map in it.
- Right click the item frame to rotate the map once.
- Notice how the map has rotated 90 degrees
- Close Minecraft.
- Load the same world in 1.8
- Notice how the map is now rotated by 180 degrees.
Environment
Windows 7
Java 1.7.0_55 64 bit
Updating 1.7 to 1.8 is wrong for item frames containing mapsRotated maps in item frames are turned when updating to 1.8
relates to
![[Mojang] Grum (Erik Broes)](../../../data/assets/gravatar/grum.png){kind=small}
[Mojang] Grum (Erik Broes)
Confirmed.
I suppose it's too late to fix this now as there's no way to know whether an item frame map was placed in 1.7 or 1.8.
I guess it's too late to prevent conversion problems, but the underlying bug can still be fixed.
How so? Changing the mapping so old maps align right will mis-align 1.8 maps.
Yes, it's too late to try to fix old maps, but the mapping is still doubled up. The directions 0-3 are visually identical to directions 4-7, but are technically different e.g. comparators give different values (MC45892). This can still be fixed, e.g. by coercing the direction values to a set half the size.
Most likely because the NBT range is different in 1.8