MC-7426Sheep breed in incorrect colors
Breeding two sheep in one color resulted in offspring in another color.
Happens probably only when breeding multiple colors simultanously.
I have built several pens using fences. Put a pair of sheep in each, one color in each pen.
Then gave them all wheat.
Result is that sometimes offspring got different color than their parents.
Screenshots after breeding attached.
Last screenshot is an overview of all pens. One can see that red sheep pen is not adjacent to cyan pen, so it was not possible that cyan sheep bred near the fence and offspring got created on the other side of the pen. Glitching through two fences at once is rather improbable too.
Environment
Windows 7 64bit
java version "1.7.0"
Java(TM) SE Runtime Environment (build 1.7.0-b147)
Java HotSpot(TM) 64-Bit Server VM (build 21.0-b17, mixed mode)
Created Issue:
Sheep breed in incorrect colors
Breeding two sheep in one color resulted in offspring in another color.
Happens probably only when breeding multiple colors simultanously.I have built several pens using fences. Put a pair of sheep in each, one color in each pen.
Then gave them all wheat.
Result is that sometimes offspring got different color than their parents.
Screenshots after breeding attached.Last screenshot is an overview of all pens. One can see that red sheep pen is not adjacent to cyan pen, so it was not possible that cyan sheep bred near the fence and offspring got created on the other side of the pen. Glitching through two fences at once is rather improbable too.
Environment
Windows 7 64bit
java version "1.7.0"
Java(TM) SE Runtime Environment (build 1.7.0-b147)
Java HotSpot(TM) 64-Bit Server VM (build 21.0-b17, mixed mode)
Attachments4
I can also confirm this issue. I had 16 pens of sheep. I wouldn't breed the pens right next to each other at the same time (to keep the sheep from breeding with different color sheep), when I breeded two collections of sheep they could be pretty far apart, the next sheep born would occasionally be the wrong color. I've attached a screenshot of the result after it happened a couple of times.
This could be intentional feature. A way to create sheeps with new colors when only 1 or 2 colors are available. However, I haven't yet spotted the necessary code to do so intentionally; I've only found the code that mixes two parent colors together, or picks either parent's color.
(Edit: on another thought, if it was intentional feature, it should only allow the colors in which sheep spawn normally, which obviously is not the case here, seeing yellow and green sheeplings..)
From MineCraft Wiki:
"If the parents have 'compatible' wool colors (meaning that the corresponding dye items could be combined into a third dye color), the resulting lamb will be a mix of their colors (e.g., blue sheep + white sheep = light blue lamb). Otherwise, the lamb will be the same color as one of the parents, chosen at random. It doesn't matter if either parent has been sheared."
While an intended feature, from the description Piotr said that two of the same color were bred, which should result in the same color sheep.
@Piotr You mentioned you were breeding multiple sheep at the same time. What color sheep were you breeding? (Even if they were not next to each other.)
Was also speaking with the other mods. It's a bit hard to tell in that screenshot but I believe sheep can breed up to 7 blocks away. At least 2 of the incorrect colors are within range for that to happen. The light blue in the red pen, I'm not sure about though.
Can you reproduce this if you put each color of sheep in pens that are a fair distance apart?
The AI code looks for "mates" in "axis aligned bounding box" + 8 blocks range (in all directions). So aboutish 8-9 blocks. I don't care to look into the details, so to play it safe and assuming "worst case", I'd use at least 16 blocks separation in testing. Flat worlds have space to waste.
@Talven I was going through the corridor between the pens and feeding the sheep as I approached them - probably first those on the left, then on the right. Not sure if I went on one side first then other, or one from each side alternatively.
I am quite sure that on the right side order was: pink, cyan, red, light blue, orange, blue, ...
I will test it today in the evening probably, this time taking care of the details.
@Markku Is that searching for mates done in order to make sheep come close to each other, or when they already "kissed" and offspring is spawned?
Observing animal behavior in game, I think the distance you and others are mentioning refers to movement algoritm at the beginning of the process (animals far away will not go to each other to mate) and not to actual creation of the offspring at the end, when they are required (?) to be touching each other.
The range I mentioned is both for looking and for when it can produce offspring. I just tested it with having separation of 5 empty blocks between pens; sheeps on each side were happy enough to make a child. They did try to move towards each other, but being close is not a requirement in the AI version of the breeding (it does only in the old code, where the requirement is iirc 2.5 blocks).
I was able to reproduce the "wrong" color case, too, with about 5-6 blocks between brown and green sheeps; the green sheep ended up getting brown baby. (They had back and white sheeps between).
Seems this issue is more about either player having too little separation between sheeps of different color, or a bug that the game allows getting the babies from too long distance.
(Edit: I did not check a case where two sheeps in love are first, say, 6 blocks away and get to detect each other, but are then moved further away... Maybe they can create baby even from longer distances as long as they have been near enough (that +8 blocks range) to detect each other first. However, this is typically not an issue, considering that they will try to get closer to each other.)
Unless there's evidence that this can happen with sheep completely separated, this works as intended.
I have just tried the same thing in the newest snapshot and it happened again. Even more buggy behavior this time, namely 2 yellow sheep in one pen and 2 red sheep in other pen (1 block distance between pen walls) produced 2 orange AND 1 red baby (3 babies total out of 2 pairs!). That happened twice - both screenshots attached (2013-01-24_20.10.55.png
and 2013-01-24_20.16.27.png
). Im not sure if I should make another bug report for that one? (because it is not only about colors and proximity, but about number of offspring).
To summarise, what I consider a bug here:
1) Sheep separated by more than one impassable block are reproducing, or babies have wrong colors.
2) 4 sheep (2 pairs) were able to produce 3 babies at once, instead of only 1.
Yes, please make another report.
2013-01-24_23.31.53.png
: Another case (from snapshot), where more offspring is created than expected and colors mix through the barrier - 2 blocks of dirt this time.
Apparently, this may have gotten fixed, as it was considered the consequence of
MC-10956, which is now fixed. I guess representation/summary matters in resolution