Rigner
- Rigner
- rigner
- Europe/Paris
- Yes
- No
MC-167447![[Mojang] etanaratsastaja](../../../data/avatars/users/10122.svg){kind=small}
In RenderStateShard, both LineStateShard and AlphaStateShard are named "alpha"
I don't think it affects anything, but it's worth noting
In RenderStateShard, both LineStateShard and AlphaStateShard are named "alpha"
I don't think it affects anything, but it's worth noting
In RenderStateShard, both LineStateShard and AlphaStateShard are named "alpha"
I don't think it affects anything, but it's worth noting
In RenderStateShard, both LineStateShard and AlphaStateShard are named "alpha"
I don't think it affects anything, but it's worth noting
image-2019-12-10-17-58-02-628.png
In RenderStateShard, both LineStateShard and AlphaStateShard are named "alpha"
I don't think it affects anything, but it's worth noting
In RenderStateShard, both LineStateShard and AlphaStateShard are named "alpha"
I don't think it affects anything, but it's worth noting
Edit : Since equals() and hashcode() both use the name, both instances will be considered the same in containers
In RenderStateShard, both LineStateShard and AlphaStateShard are named "alpha"
I don't think it affects anything, but it's worth noting
Edit : Since equals() and hashcode() both use the name, both class instances will be considered the same in containers
In RenderStateShard, both LineStateShard and AlphaStateShard are named "alpha"
I don't think it affects anything, but it's worth noting
Edit : Since equals() and hashcode() both use the name,both class instances will be considered the same in containersIn RenderStateShard, both LineStateShard and AlphaStateShard are named "alpha"
I don't think it affects anything, but it's worth noting
Edit : Since equals() and hashcode() both use the name, instances of these two classes will be considered the same in containers
ImportantSince Minecraft 1.1
4(or1.13), some of the font rendering was remade, and a minor performance issue was introduced.In the ChatFormatting class:
public static ChatFormatting getByCode(char c) { char lower = Character.toString(c).toLowerCase(Locale.ROOT).charAt(0);Here, there is a useless convertion from a character to a string, a lowercase string, then a character again. A simple `Character.toLowerCase(c)` would have been enough.
This issue was even worse before 1.12, where the whole rendered text was being changed to lowercase on each color character, and was causing a ~1% performance drop when rendering a lot of text. Here the impact is minor, but would still be a good improvement to clean it up.
Since Minecraft 1.12 (or a bit before), some of the font rendering was remade, and a minor performance issue was introduced.
In the ChatFormatting class:
public static ChatFormatting getByCode(char c) { char lower = Character.toString(c).toLowerCase(Locale.ROOT).charAt(0);Here, there is a useless convertion from a character to a string, a lowercase string, then a character again. A simple `Character.toLowerCase(c)` would have been enough.
This issue was even worse before 1.12, where the whole rendered text was being changed to lowercase on each color character, and was causing a ~1% performance drop when rendering a lot of text. Here the impact is minor, but would still be a good improvement to clean it up.
Very ImportantPerformance issue withfont parsingPerformance issue with text parsing
Since Minecraft 1.21.2, the ASM library was added to the game. Although, the version that was added is ASM 9.3, which is not even compatible with Java 21 (only up to 19).
Would be nice to upgrade it to ASM 9.5 at least (latest is 9.7.1).
https://asm.ow2.io/versions.html
I don't know exactly what is using it in the game, but it may not work properly.
Still an issue in 1.15.2-pre1
Still an issue in 1.15.2-pre2
Still an issue in 1.15.2 btw
Got fixed in 20w06a
Can reproduce on Vanilla 1.15.2. And if you click fast enough (like with a 100 CPS mouse), you won't move at all.
Also can reproduce on 20w15a (haven't tried 20w17a).
Duplicate of
MC-157436I've seen that happen on other versions as well (like 1.8) on modded clients. I don't know if can happen in vanilla as well.
Here is a video of the issue happening. Opening the chat makes it flicker.
Holding an enchanted item doesn't fix the issue for me.
You also have a very important security leak on this Jira. Anyone can set values that they shouldn't be able to, like Mojang Priority or Category, by just enabling the HTML elements in the edit form and sending it.
Still an issue in 21w37a.
Still an issue in 21w38a.
Still an issue in 21w39a.
Still an issue in 21w39a.
Still an issue in 21w40a.
Still an issue in 21w40a.
Still an issue in 21w41a.
Still an issue in 21w41a.
Noticed it's also happening in 1.17.1. Tested all previous versions of Minecraft and it seems to have started between 1.12.2 and 1.13.2.
Still an issue in 21w42a.
Still an issue in 21w43a.
Still an issue in 21w44a.
Still an issue in 1.18 Pre-release 1.
Yes like I said, it's happening on all directions, will just be on a different side. Can be reproduced on all directions depending on the placed order.
Hey, I originally made this private because it was showing Minecraft original codebase. As long as it's ok for you, you can make it public
This issue is still present in the game as of 23w05a.
It's a very small optimisation, just to get a few nanoseconds, but that's still an improvement when a lot of colored text is being rendered. It's not much, but for the time it takes to fix it (less than 5 minutes), that's definitely worth it. Also would make the code more readable and clear for the future.
Still happening in the most recent 1.21 snapshots.
Oh alright I see, thanks for the links. So yeah it wouldn't affect anything within the game, but would be good to keep in mind the library is outdated if they decide to use it for something in the future.