MC-1517Speed and Fire Resist potions Data values changed, causing weird effects on potions
The data values of all potions have changed on the shift from 1.3.2 to 1.4.2 - Speed potions (8 minutes) have gone from a value around 8K to 16K, Splash potions have gone from 16K to 32K - However the game is still brewing these potions under the 8K and 16K data value respectively, Although the potions with the 8K data value still work like they're supposed to they are now ending 3 minutes before they're designed and showing too (Effect and tooltip in inventory disappear at about (2:58), only potions taken directly from the creative menu are getting the new data value.
Environment
Not applicable - General bug of minecraft
Linked Issues
Created Issue:
Speed and Fire Resist potions Data values changed causing weird effects on potions
The data values of all potions have changed on the shift from 1.3.2 to 1.4.2 - Speed potions (8 minutes) have gone from a value around 8K to 16K, Splash potions have gone from 16K to 32K - However the game is still brewing speed potions under the 8K data value and the 8K data value potions are ending 3 minutes before they're designed and showing too - Which is causing huge trouble (I've personally died once from this due to swimming in lava)
Environment
Windows
Latest java
Vanilla/Bukkit/Singleplayer
The data values of all potions have changed on the shift from 1.3.2 to 1.4.2 - Speed potions (8 minutes) have gone from a value around 8K to 16K, Splash potions have gone from 16K to 32K - However the game is still brewing
speedpotions under the 8K data valueandthe 8K data value potions are ending 3 minutes before they're designed and showing too- Which is causing huge trouble (I've personally died once from this due to swimming in lava)The data values of all potions have changed on the shift from 1.3.2 to 1.4.2 - Speed potions (8 minutes) have gone from a value around 8K to 16K, Splash potions have gone from 16K to 32K - However the game is still brewing these potions under the 8K and 16K data value respectively the 8K data value potions although they still work like they're supposed to are ending 3 minutes before they're designed and showing too, only potions taken directly from the creative menu are getting the new data value.
Speed and Fire Resist potions Data values changed, causing weird effects on potions
The data values of all potions have changed on the shift from 1.3.2 to 1.4.2 - Speed potions (8 minutes) have gone from a value around 8K to 16K, Splash potions have gone from 16K to 32K - However the game is still brewing these potions under the 8K and 16K data value respectively
the 8K data value potions although theystill work like they're supposed toareending 3 minutes before they're designed and showing too, only potions taken directly from the creative menu are getting the new data value.The data values of all potions have changed on the shift from 1.3.2 to 1.4.2 - Speed potions (8 minutes) have gone from a value around 8K to 16K, Splash potions have gone from 16K to 32K - However the game is still brewing these potions under the 8K and 16K data value respectively, Although the potions with the 8K data value still work like they're supposed to they are now ending 3 minutes before they're designed and showing too (Effect and tooltip in inventory disappear at about (2:58), only potions taken directly from the creative menu are getting the new data value.
Windows
Latest java
Vanilla/Bukkit/SingleplayerNot applicable - General bug of minecraft
is duplicated by
is duplicated by
duplicates
I've also noticed that the drinkable Potion of Healing & Potion of Harming are not in the creative menu. They seem to map to the same potion effects as their splash versions, probably since they're instant.
Updating the description with a bit of MCP code that does the job of covering both the splash & non-splash instant potions and using the smallest potion value for each effect.
(Maybe you could make MC-1517 the duplicate instead of this issue, considering that this has more detail and a fix?)
(Note - I already reported this issue, but made the mistake of saying it was a duplicate of MC-1517. It's related to that issue but doesn't really duplicate it, also my issue provides a lot more information about the problem.)
ISSUE:
When you take a Potion from the Creative Menu brewing tab, its numeric value is larger than it should be. The bits that don't have to do with the potion effect requirements are all set to 1.
This doesn't seem to affect using the Potions, but since some of the bits set to 1 control whether you can add more ingredients, you can do some odd brewings.
I've also noticed that the potions used by the Witch use the larger "creative menu" potion values instead of their brewed potion values. It'd be good to fix that as well.
HOW TO CONFIRM:
1) Get a 3-minute Potion of Fire Resistance from the Creative Menu.
2) Put it in a Brewing Stand.
3) Add a Ghast Tear.
WHAT I EXPECT:
Nothing happens. Ghast Tear shouldn't brew with a finished potion.
WHAT I GET:
It brews a 22-second Potion of Regen II.
LIKELY CAUSE & FIX:
I took a look at (MCP)ItemPotion.getSubItems(), which generates the set of Potion items for the brewing tab. Currently it loops through the possible values 0 - 32767, adding values that create potions to a List indexed by the potion effect. This means that, if more than one potion value produces the same effect, the list will end up with the largest potion value for that particular effect - hence all the "don't-care" bits are set.
I've attached a piece of code for you to try in (MCP)ItemPotion.getSubItems(). It will account for missing Healing/Harming potions and use the smallest value for each potion effect.
Sounds like
MC-117, but with an explanation!See
MC-1705for more details on this problem with potions, the likely cause, and a possible fix.This ticket has been marked as a duplicate of
MC-6551, in favor of the better description/information provided.