MC-207824Adding ocean monuments to non-ocean/non-river biomes by datapack will not spawn the monument and causes the game to freeze upon '/locate monument'
The bug
If using the new worldgen datapack system and you add the ocean monument to a biome that does not have the ocean or river category, the structure will not spawn. Worse, if you make a dimension of just that biome and attempt to do /locate monument, the game will hang forever. Chunks will not load. Mobs freeze. Nothing in the logs.
Attached is a datapack that demonstrates this issue. Do /execute in testdim:testdim run tp ~ ~ ~ and then do /locate monument and your game will be stuck and forces you to use task manager to kill the game.
The reason for this is because in the code for the monument, the check it is doing is hardcoded to check for ocean and river category biomes which is a dangerous assumption as shown here with the datapack. In OceanMonumentFeature class, the isFeatureChunk method has this check biome.getBiomeCategory() == Biome.Category.OCEAN || biome.getBiomeCategory() == Biome.Category.RIVER. That means when it is in a dimension full of biomes that are not ocean or river category, the game will check every chunk forever in an attempt to try and find a spot to spawn the monument.
Instead, a better and far more safer solution would be to add this one extra check biome.getGenerationSettings().canGenerateStructure(this) || biome.getBiomeCategory() == Biome.Category.OCEAN || biome.getBiomeCategory() == Biome.Category.RIVER`
By checking if the biome has the structure, now ocean monuments can spawn in biomes that are not ocean or river if done so by datapacks without causing the game to hang forever. In fact, woodland mansions has a very similar check except they do biome.getGenerationSettings().canGenerateStructure(this) which is why that structure won't cause issues when added to other biomes by datapack.
Attachments1
ImportantCreated Issue:
Adding Ocean Monuments to non-ocean biomes by datapack will not spawn the monument.
If using the new worldgen datapack system and you add the Ocean Monument to a biome that does not have the Ocean or River category, the structure will not spawn. Worse, if you make a dimension of just that biome and attempt to do `/locate monument`, the game will hang forever. Chunks will not load. Mobs freeze. Nothing in the logs.
Attached is a datapack that demonstrates this issue. Do `/execute in testdim run tp ~ ~ ~` and then do `/locate monument` and your game will be stuck and forces you to use Task Manager to kill the game.
The reason for this is because in the code for the Monument, the check it is doing is hardcoded to check for Ocean and River category biomes which is a dangerous assumption as shown here with the datapack. In OceanMonumentFeature class, the isFeatureChunk method has this check `biome.getBiomeCategory() == Biome.Category.OCEAN || biome.getBiomeCategory() == Biome.Category.RIVER`
Instead, a better and far more safer solution would be to add this one extra check `biome.getGenerationSettings().canGenerateStructure(this) || biome.getBiomeCategory() == Biome.Category.OCEAN || biome.getBiomeCategory() == Biome.Category.RIVER`
By checking if the biome has the structure, now Ocean Monuments can spawn in biomes that are not Ocean or River if done so by datapacks without causing the game to hang forever. In fact, Woodland Mansions has a very similar check except they do `biome.getGenerationSettings().canGenerateStructure(this)` which is why that structure won't cause issues when added to other biomes by datapack.
Attachments1
Adding Ocean Monuments to non-ocean/non-river biomes by datapack will not spawn the monument.
If using the new worldgen datapack system and you add the Ocean Monument to a biome that does not have the Ocean or River category, the structure will not spawn. Worse, if you make a dimension of just that biome and attempt to do `/locate monument`, the game will hang forever. Chunks will not load. Mobs freeze. Nothing in the logs.
Attached is a datapack that demonstrates this issue. Do `/execute in testdim run tp ~ ~ ~` and then do `/locate monument` and your game will be stuck and forces you to use Task Manager to kill the game.
The reason for this is because in the code for the Monument, the check it is doing is hardcoded to check for Ocean and River category biomes which is a dangerous assumption as shown here with the datapack. In OceanMonumentFeature class, the isFeatureChunk method has this check `biome.getBiomeCategory() == Biome.Category.OCEAN || biome.getBiomeCategory() == Biome.Category.RIVER`. That means when it is in a dimension full of biomes that are not Ocean or River category, the game will check every chunk forever in an attempt to try and find a spot to spawn the Monument.
Instead, a better and far more safer solution would be to add this one extra check `biome.getGenerationSettings().canGenerateStructure(this) || biome.getBiomeCategory() == Biome.Category.OCEAN || biome.getBiomeCategory() == Biome.Category.RIVER`
By checking if the biome has the structure, now Ocean Monuments can spawn in biomes that are not Ocean or River if done so by datapacks without causing the game to hang forever. In fact, Woodland Mansions has a very similar check except they do `biome.getGenerationSettings().canGenerateStructure(this)` which is why that structure won't cause issues when added to other biomes by datapack.
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
If using the new worldgen datapack system and you add the Ocean Monument to a biome that does not have the Ocean or River category, the structure will not spawn. Worse, if you make a dimension of just that biome and attempt to do `/locate monument`, the game will hang forever. Chunks will not load. Mobs freeze. Nothing in the logs.
Attached is a datapack that demonstrates this issue. Do `/execute in testdim run tp ~ ~ ~` and then do `/locate monument` and your game will be stuck and forces you to use Task Manager to kill the game.
The reason for this is because in the code for the Monument, the check it is doing is hardcoded to check for Ocean and River category biomes which is a dangerous assumption as shown here with the datapack. In OceanMonumentFeature class, the isFeatureChunk method has this check `biome.getBiomeCategory() == Biome.Category.OCEAN || biome.getBiomeCategory() == Biome.Category.RIVER`. That means when it is in a dimension full of biomes that are not Ocean or River category, the game will check every chunk forever in an attempt to try and find a spot to spawn the Monument.
Instead, a better and far more safer solution would be to add this one extra check `biome.getGenerationSettings().canGenerateStructure(this) || biome.getBiomeCategory() == Biome.Category.OCEAN || biome.getBiomeCategory() == Biome.Category.RIVER`
By checking if the biome has the structure, now Ocean Monuments can spawn in biomes that are not Ocean or River if done so by datapacks without causing the game to hang forever. In fact, Woodland Mansions has a very similar check except they do `biome.getGenerationSettings().canGenerateStructure(this)` which is why that structure won't cause issues when added to other biomes by datapack.
The bug
If using the new worldgen datapack system and you add the ocean monument to a biome that does not have the ocean or river category, the structure will not spawn. Worse, if you make a dimension of just that biome and attempt to do /locate monument, the game will hang forever. Chunks will not load. Mobs freeze. Nothing in the logs.
Attached is a datapack that demonstrates this issue. Do /execute in testdim:testdim run tp ~ ~ ~ and then do /locate monument and your game will be stuck and forces you to use task manager to kill the game.
The reason for this is because in the code for the monument, the check it is doing is hardcoded to check for ocean and river category biomes which is a dangerous assumption as shown here with the datapack. In OceanMonumentFeature class, the isFeatureChunk method has this check biome.getBiomeCategory() == Biome.Category.OCEAN || biome.getBiomeCategory() == Biome.Category.RIVER. That means when it is in a dimension full of biomes that are not ocean or river category, the game will check every chunk forever in an attempt to try and find a spot to spawn the monument.
Instead, a better and far more safer solution would be to add this one extra check biome.getGenerationSettings().canGenerateStructure(this) || biome.getBiomeCategory() == Biome.Category.OCEAN || biome.getBiomeCategory() == Biome.Category.RIVER`
By checking if the biome has the structure, now ocean monuments can spawn in biomes that are not ocean or river if done so by datapacks without causing the game to hang forever. In fact, woodland mansions has a very similar check except they do biome.getGenerationSettings().canGenerateStructure(this) which is why that structure won't cause issues when added to other biomes by datapack.
AddingOceanMonuments to non-ocean/non-river biomes by datapack will not spawn the monument.Adding ocean monuments to non-ocean/non-river biomes by datapack will not spawn the monument and causes the game to freeze upon '/locate monument'
![[Mojang] Adrian Östergård](../../../data/assets/gravatar/nighter.jpeg){kind=small}
![[Mojang] slicedlime](../../../data/assets/gravatar/slicedlime.jpeg){kind=small}
![[Mod] turbo](../../../data/avatars/users/92867.png){kind=small}
![[Mojang] Rebecca](../../../data/avatars/users/18936.svg){kind=small}
Can confirm in 1.17-pre5.
Can confirm in 1.17.1-pre1.
I am unable to reproduce this in 21w44a. The game does not freeze.
@WeslyMC , Did you make a new datapack specifically for 21w44a that adds ocean monument to a non-ocean/river biome and did /locate in a dimension that only has that biome? I know worldgen changed a bit do I am assuming the attached 1.17.1 datapack will not work in 21w44a so a new datapack has to be made
Can confirm for 1.21.3
Can you confirm that you are still able to reproduce this issue on the latest version?