MC-253277The percentage symbol used within all volume sound sliders is untranslatable
The Bug:
The "%" symbol used within all volume sound sliders is untranslatable and is missing a translation key. Every other slider throughout the game has the "%" symbol correctly translatable, therefore introducing an inconsistency.
Steps to Reproduce:
- Attempt to search for the existence of this string by using this search filter on the official Minecraft crowdin project.
- Take note as to whether or not the percentage symbol used within all volume sound sliders is untranslatable.
Observed Behavior:
The percentage symbol used within all volume sound sliders is untranslatable.
Expected Behavior:
The percentage symbol used within all volume sound sliders would be translatable.
Code Analysis:
Code analysis by [Mod] Avoma can be found below.
The following is based on a decompiled version of Minecraft 22w24a using Mojang mappings.
public class VolumeSlider extends AbstractOptionSliderButton { ... @Override protected void updateMessage() { Component component = (float)this.value == (float)this.getYImage(false) ? CommonComponents.OPTION_OFF : Component.literal((int)(this.value * 100.0) + "%"); this.setMessage(Component.translatable("soundCategory." + this.source.getName()).append(": ").append(component)); } ...
If we look at the above class, we can see that the percentage symbol used within all volume sound sliders is hardcoded, and as a result, is untranslatable. This is evident through the following piece of code:
... (this.value * 100.0) + "%");
Attachments1
![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}
LowCreated Issue:
The percentage symbol used within all volume sound sliders is untranslatable
The Bug:
The "%" symbol used within all volume sound sliders is untranslatable and is missing a translation key. Every other slider throughout the game has the "%" symbol correctly translatable, therefore introducing an inconsistency.
Steps to Reproduce:
- Attempt to search for the existence of this string by using this search filter on the official Minecraft crowdin project.
- Take note as to whether or not the percentage symbol used within all volume sound sliders is untranslatable.
Observed Behavior:
The percentage symbol used within all volume sound sliders is untranslatable.
Expected Behavior:
The percentage symbol used within all volume sound sliders would be translatable.
Code Analysis:
Code analysis by [Mod] Avoma can be found below.
The following is based on a decompiled version of Minecraft 22w24a using Mojang mappings.
net.minecraft.client.gui.components.VolumeSlider.javapublic class VolumeSlider extends AbstractOptionSliderButton { ... @Override protected void updateMessage() { Component component = (float)this.value == (float)this.getYImage(false) ? CommonComponents.OPTION_OFF : Component.literal((int)(this.value * 100.0) + "%"); this.setMessage(Component.translatable("soundCategory." + this.source.getName()).append(": ").append(component)); } ...If we look at the above class, we can see that the percentage symbol used within all volume sound sliders is hardcoded, and as a result, is untranslatable. This is evident through the following piece of code:
... (this.value * 100.0) + "%");
![[Mod] ampolive](../../../data/avatars/users/18949.svg){kind=small}
![[Mojang] Moesh](../../../data/avatars/users/10122.svg){kind=small}
The Bug:
The "%" symbol used within all volume sound sliders is untranslatable and is missing a translation key. Every other slider throughout the game has the "%" symbol correctly translatable, therefore introducing an inconsistency.
Steps to Reproduce:
- Attempt to search for the existence of this string by using this search filter on the official Minecraft crowdin project.
- Take note as to whether or not the percentage symbol used within all volume sound sliders is untranslatable.
Observed Behavior:
The percentage symbol used within all volume sound sliders is untranslatable.
Expected Behavior:
The percentage symbol used within all volume sound sliders would be translatable.
Code Analysis:
Code analysis by [Mod] Avoma can be found below.
The following is based on a decompiled version of Minecraft 22w24a using Mojang mappings.
net.minecraft.client.gui.components.VolumeSlider.javapublic class VolumeSlider extends AbstractOptionSliderButton { ... @Override protected void updateMessage() { Component component = (float)this.value == (float)this.getYImage(false) ? CommonComponents.OPTION_OFF : Component.literal((int)(this.value * 100.0) + "%"); this.setMessage(Component.translatable("soundCategory." + this.source.getName()).append(": ").append(component)); } ...If we look at the above class, we can see that the percentage symbol used within all volume sound sliders is hardcoded, and as a result, is untranslatable. This is evident through the following piece of code:
... (this.value * 100.0) + "%");
![[Mojang] slicedlime](../../../data/assets/gravatar/slicedlime.jpeg){kind=small}
Can confirm.
Sound settings should use the options.percent_value string like other settings with a percentage value
Issue is marked as affecting 22w45a, 1.19.3, 1.19.4 and 1.20.1, yet the percentage symbol in question is options.percent_value and has been since 22w42a. The code listed in the issue has not existed since that version. Closing as Cannot Reproduce.