Youmiel
- Youmiel
- youmiel
- Australia/Sydney
- Yes
- No
MCL-18110
MC-240984
Low![[Mojang] Cory Scheviak](../../../data/avatars/users/92893.png){kind=small}
Raiders can't pick up ominous banner if the leader is removed not because of death.
This is because removeFromRaid() method only update groupRaiderMap but leaders are stored in groupToLeaderMap.
// net.minecraft.world.entity.raid.Raid public void removeFromRaid(Raider raider, boolean bl) { boolean bl2; Set<Raider> set = this.groupRaiderMap.get(raider.getWave()); if (set != null && (bl2 = set.remove(raider))) { if (bl){this.totalHealth -= raider.getHealth();} raider.setCurrentRaid(null); this.updateBossbar(); this.setDirty(); } }
What Happened
- Raider can pick up ominous banner item dropped from anywhere(player in any gamemode/chests/mob loot/etc.) after leader's death.
- But raiders can't pick up ominous banner if the leader is removed not because of death.
Expected Behavior
- Raiders can pick up ominous banners if the leader is removed for any reason. Or any intension the game designer wishes to reach.
Attachement CorrectBehaviour(and_banner_dropped_by_player_is_pickable).mp4
shows raiders can courrectly pick up ominous banner items after leader's death.
Attachement javaw 2022-01-03 13-49-29-388_1.mp4
This is because removeFromRaid() method only update groupRaiderMap but leaders are stored in groupToLeaderMap.
// net.minecraft.world.entity.raid.Raid public void removeFromRaid(Raider raider, boolean bl) { boolean bl2; Set<Raider> set = this.groupRaiderMap.get(raider.getWave()); if (set != null && (bl2 = set.remove(raider))) { if (bl) { this.totalHealth -= raider.getHealth(); } raider.setCurrentRaid(null); this.updateBossbar(); this.setDirty(); } }
What Happened
- Raider can pick up ominous banner item dropped from anywhere(player in any gamemode/chests/mob loot/etc.) after leader's death.
- But raiders can't pick up ominous banner if the leader is removed not because of death.
Expected Behavior
- Raiders can pick up ominous banners if the leader is removed for any reason. Or any intension the game designer wishes to reach.
Attachement CorrectBehaviour(and_banner_dropped_by_player_is_pickable).mp4
Attachement javaw 2022-01-03 13-49-29-388_1.mp4
This is because removeFromRaid() method only update groupRaiderMap but leaders are stored in groupToLeaderMap.
// net.minecraft.world.entity.raid.Raid public void removeFromRaid(Raider raider, boolean bl) { boolean bl2; Set<Raider> set = this.groupRaiderMap.get(raider.getWave()); if (set != null && (bl2 = set.remove(raider))) { if (bl){ this.totalHealth -= raider.getHealth(); } raider.setCurrentRaid(null); this.updateBossbar(); this.setDirty(); } }
What Happened
- Raider can pick up ominous banner item dropped from anywhere(player in any gamemode/chests/mob loot/etc.) after leader's death.
- But raiders can't pick up ominous banner if the leader is removed not because of death.
Expected Behavior
- Raiders can pick up ominous banners if the leader is removed for any reason. Or any intension the game designer wishes to reach.
Attachement CorrectBehaviour(and_banner_dropped_by_player_is_pickable).mp4
Attachement javaw 2022-01-03 13-49-29-388_1.mp4
This is because removeFromRaid() method only update groupRaiderMap but leaders are stored in groupToLeaderMap.
// net.minecraft.world.entity.raid.Raid public void removeFromRaid(Raider raider, boolean bl) { boolean bl2; Set<Raider> set = this.groupRaiderMap.get(raider.getWave()); if (set != null && (bl2 = set.remove(raider))) { if (bl){ this.totalHealth -= raider.getHealth(); } raider.setCurrentRaid(null); this.updateBossbar(); this.setDirty(); } }
What Happened
- Raiders can't pick up ominous banner if the leader is removed not because of death.
Expected Behavior
- Raiders can pick up ominous banners if the leader is removed for any reason.
- MC-247440 shouldn't be marked as invalid because it reports the same bug.
Attachement CorrectBehaviour(and_banner_dropped_by_player_is_pickable).mp4
Attachement WrongBehavour.mp4
This is because removeFromRaid() method only update groupRaiderMap but leaders are stored in groupToLeaderMap.
// net.minecraft.world.entity.raid.Raid public void removeFromRaid(Raider raider, boolean bl) { boolean bl2; Set<Raider> set = this.groupRaiderMap.get(raider.getWave()); if (set != null && (bl2 = set.remove(raider))) { if (bl) { this.totalHealth -= raider.getHealth(); } raider.setCurrentRaid(null); this.updateBossbar(); this.setDirty(); } }
WrongBehavour-1.mp4
As the page said:
- A triggered raid will no longer start if the raiders cannot find a place to spawn within a reasonable distance of the village they are trying to raid
To Reporduce
- Create a default type world with seed: 23925373020405760
- Teleport to (204, 65, 110)
- Place a composter at (202, 62, 111), and summon a villager beside it
- Drink a ominous bottle
- Wait for a minute and the raid ends without any raiders spawned
- Repeat 4 and 5
As the page sa
id:
- A triggered raid will no longer start if the raiders cannot find a place to spawn within a reasonable distance of the village they are trying to raid
To Reporduce
- Create a default type world with seed: 23925373020405760
- Teleport to (204, 65, 110)
- Place a composter at (202, 62, 111), and summon a villager beside it
- Drink a ominous bottle
- Wait for a minute and the raid ends without any raiders spawned
- Repeat 4 and 5
As the page says:
- A triggered raid will no longer start if the raiders cannot find a place to spawn within a reasonable distance of the village they are trying to raid
To Reporduce
- Create a default type world with seed: 23925373020405760
- Teleport to (204, 65, 110)
- Place a composter at (202, 62, 111), and summon a villager beside it
- Drink a ominous bottle
- Wait for a minute and the raid ends without any raiders spawned
- Repeat 4 and 5
As the page says:
- A triggered raid will no longer start if the raiders cannot find a place to spawn within a reasonable distance of the village they are trying to raid
However, I notice that
To Reporduce
- Create a default type world with seed: 23925373020405760
- Teleport to (204, 65, 110)
- Place a composter at (202, 62, 111), and summon a villager beside it
- Drink a ominous bottle
- Wait for a minute and the raid ends without any raiders spawned
- Repeat 4 and 5
As the page says:
- A triggered raid will no longer start if the raiders cannot find a place to spawn within a reasonable distance of the village they are trying to raid
However, I notice that
To Reporduce
- Create a default type world with seed: 23925373020405760
- Teleport to (204, 65, 110)
- Place a composter at (202, 62, 111), and summon a villager beside it
- Drink a ominous bottle
- Wait for a minute and the raid ends without any raiders spawned
- Repeat 4 and 5
As the page says:
- A triggered raid will no longer start if the raiders cannot find a place to spawn within a reasonable distance of the village they are trying to raid
However, I notice that raiders sometimes would not spawn even if there are close enough places around village.
To Reporduce
- Create a default type world with seed: 23925373020405760
- Teleport to (204, 65, 110)
- Place a composter at (202, 62, 111), and summon a villager beside it
- Drink a ominous bottle
- Wait for a minute and the raid ends without any raiders spawned
- Repeat 4 and 5
If this is a bug, then rotten flesh, raw chicken and pufferfish cannot be eaten with full hunger should also be considered as bugs, because they also gives effects.
@MojangMoesh
Illager can pick up banners dropped by players, see attachment CorrectBehaviour(and_banner_dropped_by_player_is_pickable).mp4
for confirmation. They only check banner items' NBT tags(patterns, custom name, etc.) so there is no difference between the one dropped by player and the one dropped by leader.
@MojangMoesh There is no behavior matches what you mentioned. Maybe the raiders are designed to behave like this, but the code doesn't go this way.
The code in this ticket is the most important part of this bug, just let someone knows well in coding check this out. I don't want to add bunches of code and point out the associattion between every lines of code here. It's useless and no one would get any information.
Can confirm in 1.14 ~ 1.18.1.
@MojangMoesh Please recheck this issue. Just launch the game and test it.
It's not duplicate of
MC-270014because that issue is tested with Evoker captains. They aren't able to be spawned in pillager outpost and raid. Using /summon command might not summon vaild raid captains.This issue uses pillagers and vindicators from pillager outpost and raids. This is exactly the same as the release note says: Raid Captains which are defeated outside a Raid
The release notes clearly says "Ominous Bottles are dropped by Raid Captains which are defeated outside a Raid". I don't understand why captains other than pillagers should be excluded and not drop ominous bottles.
Please change the affected version to 1.21
Attached a world containing wither skeleton spawning platform and spawn rate counter datapack for reproduction. The world is saved in 1.16.5, but it is safe to upgrade to higher versions.
The rate of three situations shown in the world save is different across different versions.
Note: if you want to use the datapack in 1.21, don't forget to rename these folders in all namespaces: functions -> function, tags/functions -> tags/function, tags/entity_types -> tags/entity_type
Since
MC-203748andMC-240948are marked as fixed, this report should be reconsidered.Since
MC-203748andMC-240948are marked as fixed, this issue should be reconsidered.Please don't add unrelated screenshot and issues. This is a new issue that only exists in 24w33a Java Edition, since Mojang has made changes to raid and stated that raiders would spawn "within a reasonable distance"
If you flip the lever and then put a block beside the piston, the piston would extend. Conversely. if you switch the lever off with the piston extended, it wouldn't retract until you put another block beside it.
I believe the report should be confirmed as a bug.