MC-116696Animated textures in resource packs aren't animated in advancement icons
While having an animated resource pack enabled, The advancement section of your pause menu does not animate the items/blocks in it's icons and tabs. for example, the advancement "Hot stuff" has a lava bucket and this item is animated in the game. but whenever the advancement section is open, the icon for any animated item including the lava bucket is frozen in its last frame before the game was paused.
Attachments1
Created Issue:
Animated textures in resource packs aren't animated in advancement icons
While having an animated resource pack enabled, The advancement section of your pause menu does not animate the items/blocks in it's icons and tabs. for example, the advancement "Hot stuff" has a lava bucket and this item is animated in the game. but whenever the advancement section is open, the icon for any animated item including the lava bucket is frozen in its last frame before the game was paused.
Environment
Advancement section in the pause menu
![[Mod] Neko](../../../data/avatars/users/92901.png){kind=small}
I have figured out why this happens. It is because that technically the game is paused while the advancement menu is opened, and all the block/item animations stop when the game is paused. A solution is to make it so that the block/item animations do not stop when you pause the game.
Advancement section in the pause menu
![[Mojang] Nathan Adams](../../../data/assets/gravatar/dinnerbone.png){kind=small}
[Mojang] Nathan Adams
This issue also affects particle "minecraft:vibration", because it uses the same animation method as blocks. Video attached reproducing this issue in latest snapshot (23w44a).
The main reason (I think) Dinnerbone marked this issue as WAI is because the fix applied for MC-116696 directly contradicts the fix this bug needs, inside the code. What it's happening here is that the advancements screen is a menu that also pauses the game, so if this bug got fixed the easiest way (just readding the "if not paused" check to the TextureManager.tick() call on Minecraft.tick()), MC-116696 would reappear because AdvancementsScreen is a "pausing screen".
//class Minecraft.java public void tick() { if (this.rightClickDelay > 0) { --this.rightClickDelay; } this.profiler.push("gui"); this.chatListener.tick(); this.gui.tick(this.pause); this.profiler.pop(); this.gameRenderer.pick(1.0F); this.tutorial.onLookAt(this.level, this.hitResult); this.profiler.push("gameMode"); if (!this.pause && this.level != null) { this.gameMode.tick(); } this.profiler.popPush("textures"); if (this.level != null) {//what should be here is " && !this.pause" but can't really do it because of MC-116696 this.textureManager.tick(); } //... }
Yeah, you would say that by simply adding a "is advancements screen", the two bugs would get fixed, but no, instead, textures would get animated when you have the advancements screen open. Making the advancements screen a non-pausing screen wouldn't be a good option either, because that wouldn't make much sense since this is very often opened from the pause menu. Also I forgot to mention that MC-116696 also affected the statistics screen.
I think the best way of solving this problem is by fixing this the way I described before (that "easy" way) and marking MC-116696 as WAI, which makes a lot more sense since the advancements & statistics screens are considered to be pause screens, (and this bug has been re-opened, which inherently means that things aren't supposed to move in pause).
Can I request the ownership for this issue? Of course if user33 agrees first...
Can you please attach a resource pack which can be used to easily reproduce the bug?
Same thing happens to me in 17w18b. I have attached a resource pack that demonstrates this glitch by changing the texture of the empty map to constantly rotate, however in the advancement gui, it does not.
Can a mod please update the confirmation status?
It'd also be nice if the affected versions was updated.