MC-118354Advancement backgrounds repeat incorrectly for non-square images
The bug
When an advancement tab's background image is not square, the way it repeats is inversely related to its aspect ratio. I expect the way it repeats to be directly related to its aspect ratio.
For example, the chain command block side texture is 16x64, or an aspect ratio of 0.25. With "GUI Scale: Normal", the texture repeats every 32px on the x-axis, and 4px on the y-axis. I would expect the texture to repeat on the y-axis every 128px at this scale.
On a related note, the texture isn't animated, but as far as I'm concerned, that can wait for another day.
How to reproduce
- Download the attached advancement background_test.json
and place it in the following directory of your world folder
datapacks/MC-118354/data/custom/advancements/background_test.json
- Load the world
- Open the advancement GUI and look at the advancement
![[Mod] tryashtar](../../../data/avatars/users/41963.png){kind=small}
Created Issue:
Advancement backgrounds repeat incorrectly for non-square images
When an advancement tab's background image is not square, the way it repeats is inversely related to its aspect ratio. I expect the way it repeats to be directly related to its aspect ratio.
For example, the chain command block side texture is 16x64, or an aspect ratio of 0.25. With "GUI Scale: Normal", the texture repeats every 32px on the X axis, and 4px on the Y axis. I would expect the texture to repeat on the Y axis every 128px at this scale.
On a related note, the texture isn't animated, but as far as I'm concerned, that can wait for another day.
Environment
Java: 1.8.0_131 64bit
Mem: 17% 520/3059MB
Allocated: 25% 777MBCPU 4x AMD FX(tm)-4350 Quad-Core Processor
Display: 1920x1056 (NVIDIA Corporation)
GeForce GTX 660/PCIe/SSE2
4.5.0 NVIDIA 375.66
Attachments1
Java: 1.8.0_131 64bit
Mem: 17% 520/3059MB
Allocated: 25% 777MBCPU 4x AMD FX(tm)-4350 Quad-Core Processor
Display: 1920x1056 (NVIDIA Corporation)
GeForce GTX 660/PCIe/SSE2
4.5.0 NVIDIA 375.66
The bug
When an advancement tab's background image is not square, the way it repeats is inversely related to its aspect ratio. I expect the way it repeats to be directly related to its aspect ratio.
For example, the chain command block side texture is 16x64, or an aspect ratio of 0.25. With "GUI Scale: Normal", the texture repeats every 32px on the X axis, and 4px on the Y axis. I would expect the texture to repeat on the Y axis every 128px at this scale.
On a related note, the texture isn't animated, but as far as I'm concerned, that can wait for another day.
How to reproduce
- Download the attached advancement background_test.json
data\advancements\custom- Load the world
- Open the advancement GUI and look at the advancement
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
The bug
When an advancement tab's background image is not square, the way it repeats is inversely related to its aspect ratio. I expect the way it repeats to be directly related to its aspect ratio.
For example, the chain command block side texture is 16x64, or an aspect ratio of 0.25. With "GUI Scale: Normal", the texture repeats every 32px on the
Xaxis, and 4px on theYaxis. I would expect the texture to repeat on theYaxis every 128px at this scale.On a related note, the texture isn't animated, but as far as I'm concerned, that can wait for another day.
How to reproduce
- Download the attached advancement background_test.json
data\advancements\custom- Load the world
- Open the advancement GUI and look at the advancement
The bug
When an advancement tab's background image is not square, the way it repeats is inversely related to its aspect ratio. I expect the way it repeats to be directly related to its aspect ratio.
For example, the chain command block side texture is 16x64, or an aspect ratio of 0.25. With "GUI Scale: Normal", the texture repeats every 32px on the x-axis, and 4px on the y-axis. I would expect the texture to repeat on the y-axis every 128px at this scale.
On a related note, the texture isn't animated, but as far as I'm concerned, that can wait for another day.
How to reproduce
- Download the attached advancement background_test.json
data\advancements\custom- Load the world
- Open the advancement GUI and look at the advancement
![[Mojang] Nathan Adams](../../../data/assets/gravatar/dinnerbone.png){kind=small}
The bug
When an advancement tab's background image is not square, the way it repeats is inversely related to its aspect ratio. I expect the way it repeats to be directly related to its aspect ratio.
For example, the chain command block side texture is 16x64, or an aspect ratio of 0.25. With "GUI Scale: Normal", the texture repeats every 32px on the x-axis, and 4px on the y-axis. I would expect the texture to repeat on the y-axis every 128px at this scale.
On a related note, the texture isn't animated, but as far as I'm concerned, that can wait for another day.
How to reproduce
- Download the attached advancement background_test.json
data\advancements\custom- Load the world
- Open the advancement GUI and look at the advancement
The bug
When an advancement tab's background image is not square, the way it repeats is inversely related to its aspect ratio. I expect the way it repeats to be directly related to its aspect ratio.
For example, the chain command block side texture is 16x64, or an aspect ratio of 0.25. With "GUI Scale: Normal", the texture repeats every 32px on the x-axis, and 4px on the y-axis. I would expect the texture to repeat on the y-axis every 128px at this scale.
On a related note, the texture isn't animated, but as far as I'm concerned, that can wait for another day.
How to reproduce
- Download the attached advancement background_test.json
datapacks/MC-118354/data/custom/advancements/background_test.json- Load the world
- Open the advancement GUI and look at the advancement
![[Mod] Asteraoth](../../../data/avatars/users/92886.png){kind=small}
Affects 20w49a
background_test.json needs to be placed in
Affects 1.17