MC-122819Changes to the hitbox of hoppers makes them unable to pick up items
The bug
The changes to the hitboxes of a hopper affect items that get thrown onto the hopper from the side. In the picture I provided (2017-12-02_19.53.13.png
), you can see the bug in action. When you throw an item in from the top it gets pulled down to the lowest hopper; no problem. When you throw an item in from the side, like I did, they just don't get picked up. When you break the hoppers from the top down the items get picked up and end up in the lowest one.
Code analysis
TileEntityHopper.captureDroppedItems(IHopper) first checks if there is an inventory above it. If so, it will attempt to pull an item from it and then return true or false. If there is not an inventory above it, it will try to find item entities and put them in its inventory.
Since there is an inventory above the hopper here, it never checks for items above it.
Linked Issues
Created Issue:
Changes to the Hitbox of Hoppers makes them unable to pick up items
The changes to the hitbixes of a hopper affect items that get thrown onto the hopper from the side. In the Picture I provided you can see the bug in action. When you throw an item in from the top it gets pulled down to the lowest hopper: no problem. When you throw an item in from the side, like I did, they just don't get picked up.
Attachments1
2017-12-02_19.50.06.png
The changes to the hitbixes of a hopper affect items that get thrown onto the hopper from the side. In the Picture I provided you can see the bug in action. When you throw an item in from the top it gets pulled down to the lowest hopper: no problem. When you throw an item in from the side, like I did, they just don't get picked up. When you brek the hoppers from the top down the items get picked up and end up in the lowest one.
![[Mod] tryashtar](../../../data/avatars/users/41963.png){kind=small}
![[Mod] Neko](../../../data/avatars/users/92901.png){kind=small}
The changes to the hitbixes of a hopper affect items that get thrown onto the hopper from the side. In the Picture I provided you can see the bug in action. When you throw an item in from the top it gets pulled down to the lowest hopper: no problem. When you throw an item in from the side, like I did, they just don't get picked up. When you brek the hoppers from the top down the items get picked up and end up in the lowest one.
Code anaylsis
TileEntityHopper.captureDroppedItems(IHopper) first checks if there is a inventory above it. If so, it will attempt to pull an item from it and then return true or false. If there is not an inventory above it, it will try to find item entities and put them in its inventory.
The changes to the hitbixes of a hopper affect items that get thrown onto the hopper from the side. In the Picture I provided you can see the bug in action. When you throw an item in from the top it gets pulled down to the lowest hopper: no problem. When you throw an item in from the side, like I did, they just don't get picked up. When you brek the hoppers from the top down the items get picked up and end up in the lowest one.
Code anaylsis
TileEntityHopper.captureDroppedItems(IHopper) first checks if there is a inventory above it. If so, it will attempt to pull an item from it and then return true or false. If there is not an inventory above it, it will try to find item entities and put them in its inventory.
The bug
The changes to the hitbixes of a hopper affect items that get thrown onto the hopper from the side. In the picture I provided (2017-12-02_19.53.13.png
), you can see the bug in action. When you throw an item in from the top it gets pulled down to the lowest hopper; no problem. When you throw an item in from the side, like I did, they just don't get picked up. When you break the hoppers from the top down the items get picked up and end up in the lowest one.
Code anaylsis
TileEntityHopper.captureDroppedItems(IHopper) first checks if there is an inventory above it. If so, it will attempt to pull an item from it and then return true or false. If there is not an inventory above it, it will try to find item entities and put them in its inventory.
Since there is an inventory above the hopper here, it never checks for items above it.
The bug
The changes to the hitbixes of a hopper affect items that get thrown onto the hopper from the side. In the picture I provided (2017-12-02_19.53.13.png
Code ana
ylsisTileEntityHopper.captureDroppedItems(IHopper) first checks if there is an inventory above it. If so, it will attempt to pull an item from it and then return true or false. If there is not an inventory above it, it will try to find item entities and put them in its inventory.
Since there is an inventory above the hopper here, it never checks for items above it.
The bug
The changes to the hitbixes of a hopper affect items that get thrown onto the hopper from the side. In the picture I provided (2017-12-02_19.53.13.png
Code analysis
TileEntityHopper.captureDroppedItems(IHopper) first checks if there is an inventory above it. If so, it will attempt to pull an item from it and then return true or false. If there is not an inventory above it, it will try to find item entities and put them in its inventory.
Since there is an inventory above the hopper here, it never checks for items above it.
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
The bug
The changes to the hitb
ixes of a hopper affect items that get thrown onto the hopper from the side. In the picture I provided (2017-12-02_19.53.13.pngCode analysis
TileEntityHopper.captureDroppedItems(IHopper) first checks if there is an inventory above it. If so, it will attempt to pull an item from it and then return true or false. If there is not an inventory above it, it will try to find item entities and put them in its inventory.
Since there is an inventory above the hopper here, it never checks for items above it.
The bug
The changes to the hitboxes of a hopper affect items that get thrown onto the hopper from the side. In the picture I provided (2017-12-02_19.53.13.png
Code analysis
TileEntityHopper.captureDroppedItems(IHopper) first checks if there is an inventory above it. If so, it will attempt to pull an item from it and then return true or false. If there is not an inventory above it, it will try to find item entities and put them in its inventory.
Since there is an inventory above the hopper here, it never checks for items above it.
Changes to theHitbox ofHoppers makes them unable to pick up itemsChanges to the hitbox of hoppers makes them unable to pick up items
![[Mojang] Georgii Gavrichev](../../../data/avatars/users/22428.png){kind=small}
[Mojang] Georgii Gavrichevrelates to
As a side note: This would make all current designs of using block entities above hoppers to reduce lag ineffective. Possibly this check should only be done if the container above is not a full cube.
Edit: As pointed out by others (elsewhere) it might be wanted that hoppers can collect items travelling through a block tower and therefore hoppers should try collecting items all the time regardless of which block is above.
It's now picking up entities that are in the hopper-cavity, when items land on the rim, they don't get picked up. I'd say that's a wonderful solution/fix, well done!
