MC-125051Incorrect structure names in advancements cause java.lang.NullPointerException
The bug
The advancement condition feature causes a crash when specifiying an incorrect structure name:
"criteria": { "find_structure": { "trigger": "minecraft:location", "conditions": { "feature": "incorrect_structure_name" } } }
Steps to reproduce
- Put the attached data pack
in your world - Load up the world
- Notice that it crashes immediately
Crash report
Description: Ticking player java.lang.NullPointerException: Ticking player at bjo.a(SourceFile:167) at au.a(SourceFile:56) at au.a(SourceFile:36) at av$b.a(SourceFile:79) at av$a.a(SourceFile:106) at av.a(SourceFile:66) at sc.i(SourceFile:417) at sx.aa_(SourceFile:189) at hg.a(SourceFile:221) at sw.c(SourceFile:175) at net.minecraft.server.MinecraftServer.w(SourceFile:721) at net.minecraft.server.MinecraftServer.v(SourceFile:628) at cvl.v(SourceFile:155) at net.minecraft.server.MinecraftServer.run(SourceFile:533) at java.lang.Thread.run(Thread.java:745)
Linked Issues
![[Helper] Lord_Quadrato](../../../data/avatars/users/26105.png){kind=small}
Created Issue:
Ticking Player Crash
When I enter the world, it loads, then crashes for an unexplained reason. I tried to enter it again, and it still crashes. I checked the crash reports and the only thing I know that it has something to do with "Ticking Player". So I entered a different world, but it loaded normally, but when I attempted to put a "recipes" data pack, nothing happened when reloaded, but when I put an "advancements" data pack, suddenly it crashes, so I checked the latest report and it said "Ticking Player", so it must have something to do with the advancements in the data packs.
![[Mod] Neko](../../../data/avatars/users/92901.png){kind=small}
crash-2017-12-21_19.04.14-server.txt
![[Bot] Arisa](../../../data/assets/gravatar/mustek2.png){kind=small}
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
When I enter the world, it loads, then crashes for an unexplained reason. I tried to enter it again, and it still crashes. I checked the crash reports and the only thing I know that it has something to do with "Ticking Player". So I entered a different world, but it loaded normally, but when I attempted to put a "recipes" data pack, nothing happened when reloaded, but when I put an "advancements" data pack, suddenly it crashes, so I checked the latest report and it said "Ticking Player", so it must have something to do with the advancements in the data packs.
The bug
When I enter the world, it loads, then crashes for an unexplained reason. I tried to enter it again, and it still crashes. I checked the crash reports and the only thing I know that it has something to do with "Ticking Player". So I entered a different world, but it loaded normally, but when I attempted to put a "recipes" data pack, nothing happened when reloaded, but when I put an "advancements" data pack, suddenly it crashes, so I checked the latest report and it said "Ticking Player", so it must have something to do with the advancements in the data packs.
Crash report
Description: Ticking player java.lang.NullPointerException: Ticking player at bjo.a(SourceFile:167) at au.a(SourceFile:56) at au.a(SourceFile:36) at av$b.a(SourceFile:79) at av$a.a(SourceFile:106) at av.a(SourceFile:66) at sc.i(SourceFile:417) at sx.aa_(SourceFile:189) at hg.a(SourceFile:221) at sw.c(SourceFile:175) at net.minecraft.server.MinecraftServer.w(SourceFile:721) at net.minecraft.server.MinecraftServer.v(SourceFile:628) at cvl.v(SourceFile:155) at net.minecraft.server.MinecraftServer.run(SourceFile:533) at java.lang.Thread.run(Thread.java:745)
TickingPlayerCrashCrash: java.lang.NullPointerException: Ticking player
is duplicated by
![[Mod] Skylinerw](../../../data/assets/gravatar/skylinerw.png){kind=small}
is duplicated by
is duplicated by
The bug
When I enter the world, it loads, then crashes for an unexplained reason. I tried to enter it again, and it still crashes. I checked the crash reports and the only thing I know that it has something to do with "Ticking Player". So I entered a different world, but it loaded normally, but when I attempted to put a "recipes" data pack, nothing happened when reloaded, but when I put an "advancements" data pack, suddenly it crashes, so I checked the latest report and it said "Ticking Player", so it must have something to do with the advancements in the data packs.
Crash report
Description: Ticking player java.lang.NullPointerException: Ticking player at bjo.a(SourceFile:167) at au.a(SourceFile:56) at au.a(SourceFile:36) at av$b.a(SourceFile:79) at av$a.a(SourceFile:106) at av.a(SourceFile:66) at sc.i(SourceFile:417) at sx.aa_(SourceFile:189) at hg.a(SourceFile:221) at sw.c(SourceFile:175) at net.minecraft.server.MinecraftServer.w(SourceFile:721) at net.minecraft.server.MinecraftServer.v(SourceFile:628) at cvl.v(SourceFile:155) at net.minecraft.server.MinecraftServer.run(SourceFile:533) at java.lang.Thread.run(Thread.java:745)The bug
The advancement condition feature causes a crash when specifiying an incorrect structure name:
Example criteria"criteria": { "find_structure": { "trigger": "minecraft:location", "conditions": { "feature": "incorrect_structure_name" } } }Steps to reproduce
- Put the attached data pack
- Load up the world
- Notice that it crashes immediately
Crash report
Description: Ticking player java.lang.NullPointerException: Ticking player at bjo.a(SourceFile:167) at au.a(SourceFile:56) at au.a(SourceFile:36) at av$b.a(SourceFile:79) at av$a.a(SourceFile:106) at av.a(SourceFile:66) at sc.i(SourceFile:417) at sx.aa_(SourceFile:189) at hg.a(SourceFile:221) at sw.c(SourceFile:175) at net.minecraft.server.MinecraftServer.w(SourceFile:721) at net.minecraft.server.MinecraftServer.v(SourceFile:628) at cvl.v(SourceFile:155) at net.minecraft.server.MinecraftServer.run(SourceFile:533) at java.lang.Thread.run(Thread.java:745)
Crash:java.lang.NullPointerException: Ticking playerIncorrect structure names in advancements cause java.lang.NullPointerException
![[Mod] Asteraoth](../../../data/avatars/users/92886.png){kind=small}
That crash report is from December.
Instead, run the game, let it crash, then attach the launcher log (.minecraft/launcher_log.txt) here.
Once attached, the report will be reopened automatically.
Quick Links:
📓 Issue Guidelines – 💬 Community Support – 📧 Customer Support – 📖 Game Wiki
Report Update:
Updated Crash Report thanks to Neko
I would like to add that this seems to mainly affect advancements triggered by going into structures. If you are near a desert temple with an advancement that is granted by going in it, game crashes. My bug report, MC-127741. Hope this helps narrowing down the issue.
Is this still an issue in the latest 1.13 development snapshot?
This still happens in Minecraft 1.13-pre6. This probably is caused by advancements triggered by some/all structures (only tested for desert temples).
Still an issue in 1.13-pre7
Confirmed for 1.13-pre8. I am concerned this bug won't be fixed before the release of 1.13. Is there any way to bring the devs attention to this bug? I would consider it a pretty serious bug as it causes a complete game crash.
Did a little extra testing, and found that this bug appears to only affect structures that were detected by feature: temple. I also discovered that the game now recognizes these structures as "desert_pyramid" and "jungle_pyramid", and using these names instead doesn't crash the game. The actual trigger for this crash is any miss-spelled or non existent structure name crashes the game. This bug is not actually as serious as I thought, as it only happens on incorrectly made advancement files. This is still a bug though, as what should happen is the game gives an error in the game output log and not load the advancement, like it does with any other mistake. Below I've attached an example criteria that will trigger this bug.