MC-135431Scoreboard division is inconsistent with modulo
In 18w31a, the %= operation was changed to use Java's Math.floorMod instead of %. However, the /= operation still uses Java's / instead of Math.floorDiv, which is inconsistent.
To reproduce:
Create a new world:
Run the following commands:
/scoreboard objectives add test dummy /scoreboard objectives setdisplay sidebar test /scoreboard players set n test 3 /scoreboard players set a test -5 /scoreboard players set q test -5 /scoreboard players set r test -5 /scoreboard players operation q test /= n test /scoreboard players operation r test %= n test
With a consistent division algorithm, a = n*q + r, but this is not the case here.
Linked Issues
relates to1
Created Issue:
Scoreboard division is inconsistent with modulo
Environment
In 18w31a, the %= operation was changed to use Java's Math.floorMod instead of %. However, the /= operation still uses Java's / instead of Math.floorDiv, which is inconsistent.
To reproduce:
Create a new world:
Run the following commands:
/scoreboard objectives add test dummy /scoreboard objectives setdisplay sidebar test /scoreboard players set n test 3 /scoreboard players set a test -5 /scoreboard players set q test -5 /scoreboard players set r test -5 /scoreboard players operation q test /= n test /scoreboard players operation r test %= n testWith a consistent division algorithm, a = n*q + r, but this is not the case here.
![[Bot] Arisa](../../../data/assets/gravatar/mustek2.png){kind=small}
In 18w31a, the %= operation was changed to use Java's Math.floorMod instead of %. However, the /= operation still uses Java's / instead of Math.floorDiv, which is inconsistent.
To reproduce:
Create a new world:
Run the following commands:
/scoreboard objectives add test dummy /scoreboard objectives setdisplay sidebar test /scoreboard players set n test 3 /scoreboard players set a test -5 /scoreboard players set q test -5 /scoreboard players set r test -5 /scoreboard players operation q test /= n test /scoreboard players operation r test %= n testWith a consistent division algorithm, a = n*q + r, but this is not the case here.
In 18w31a, the %= operation was changed to use Java's Math.floorMod instead of %. However, the /= operation still uses Java's / instead of Math.floorDiv, which is inconsistent.
To reproduce:
Create a new world:
Run the following commands:
/scoreboard objectives add test dummy /scoreboard objectives setdisplay sidebar test /scoreboard players set n test 3 /scoreboard players set a test -5 /scoreboard players set q test -5 /scoreboard players set r test -5 /scoreboard players operation q test /= n test /scoreboard players operation r test %= n testWith a consistent division algorithm, a = n*q + r, but this is not the case here.
![[Mojang] Bartosz Bok](../../../data/avatars/users/10122.svg){kind=small}
[Mojang] Bartosz Bok![[Mod] CubeTheThird](../../../data/assets/gravatar/cubethethird.jpeg){kind=small}
relates to
![[Mod] SPGoding](../../../data/avatars/users/44622.png){kind=small}
![[Mod] tryashtar](../../../data/avatars/users/41963.png){kind=small}