MC-214810Cats remain sitting when damaged
The bug
What I expected to happen was that the cat would exit its sitting position upon being damaged.
What actually happened instead was the cat remained sitting when damaged.
To reproduce this bug:
- Spawn/find an untamed cat.
- Tame it and click it to place it in its sitting position.
- Damage it in any way you see fit.
Code analysis
Code analysis by [Mod] Avoma can be found in this comment.
Linked Issues
Normal![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}
Created Issue:
Cats remain sitting when damaged.
What I expected to happen was that the cat would exit its sitting position upon being damaged.
What actually happened instead was the cat remained sitting when damaged.
To reproduce this bug:
- Spawn/find an untamed cat.
- Tame it and click it to place it in its sitting position.
- Damage it in any way you see fit.
![[Mod] violine1101](../../../data/avatars/users/92858.png){kind=small}
Cats remain sitting when damaged.
relates to
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
![[Helper] Johnibur](../../../data/avatars/users/28381.png){kind=small}
![[Mod] Les3awe](../../../data/avatars/users/79847.png){kind=small}
relates to
![[Mod] ampolive](../../../data/avatars/users/18949.svg){kind=small}
What I expected to happen was that the cat would exit its sitting position upon being damaged.
What actually happened instead was the cat remained sitting when damaged.
To reproduce this bug:
- Spawn/find an untamed cat.
- Tame it and click it to place it in its sitting position.
- Damage it in any way you see fit.
The bug
What I expected to happen was that the cat would exit its sitting position upon being damaged.
What actually happened instead was the cat remained sitting when damaged.
To reproduce this bug:
- Spawn/find an untamed cat.
- Tame it and click it to place it in its sitting position.
- Damage it in any way you see fit.
Code analysis
Code analysis by [Mod] Avoma can be found in this comment.
relates to
![[Bot] Arisa](../../../data/avatars/users/43007.png){kind=small}
This is particularly detrimental in the case of drowning, as can be seen in
MC-209409.Can confirm in 21w07a.
Can confirm in 21w13a.
Can confirm in 21w17a.
Can confirm in 1.17.
Can confirm in 1.17.1.
Affects 1.18.1
I can also confirm this in 1.18.1.
Here's a code analysis along with a potential fix regarding this issue. The following is based on a decompiled version of Minecraft 1.18.1 using MCP-Reborn. Please note that I'm quite tentative about this analysis, although I'm persuaded to believe that this is likely the cause of the problem.
Code Analysis (tentative):
Normally, when a tamed entity receives damage, the this.setOrderedToSit(false) method is called which makes the entity stand up. This applies to all tamed entities except cats as the this.setOrderedToSit(false) method is never called.
Potential Fix (tentative):
Simply adding the below code somewhere within the net.minecraft.world.entity.animal.Cat.java class could potentially resolve this problem, judging by how the net.minecraft.world.entity.animal.Parrot.java class contains similar lines of code.
In 1.18.2.
Can confirm in 1.19 and 22w24a.
Can confirm in 1.19.2.
In 23w14a, they also seem to panic now (unless taking campfire damage) and then sit back down, which is inconsistent with the other pets still
Orbic, I've created a new ticket for that issue which can be found at MC-265381.
This issue was present in 23w06a but no longer occurs in 23w07a, therefore this problem has been fixed in 23w07a. I'm not sure why both 23w14a and 1.20.1 are marked as affected because I wasn't able to reproduce this problem in both of these versions. I can say with confidence though that this problem was fixed in 23w07a so I'm going to resolve this ticket as fixed. I've attached two screenshots to support my claims here.
MC-214810 - 23w06a.png
MC-214810 - 23w07a (Fixed).png