MC-248199/place feature/structure sometimes doesn't cause blocks/lights to update
The bug
Placing a structure or a feature doesn't appear to cause block updates or light updates, leaving water without a source in the world.
Code analysis
Code analysis by Hugman can be found in this comment.
Linked Issues
![[Mod] ampolive](../../../data/avatars/users/18949.svg){kind=small}
![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}
LowCreated Issue:
/placefeature sometimes not update block
Attachments7
![[Mojang] Moesh](../../../data/avatars/users/10122.svg){kind=small}
Summary: Placing a structure does not appear to cause block updates, leaving water without a source in the world.
/placefeature sometimesnot update block/placefeature sometimes does not cause block updates
![[Mod] Neko](../../../data/avatars/users/92901.png){kind=small}
relates to
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
/place feature/structure sometimes does not cause block updates
The bug
Placing a structure does not appear to cause block updates, leaving water without a source in the world.
Code analysis
Code analysis by Hugman can be found in this comment.
![[Mod] Les3awe](../../../data/avatars/users/79847.png){kind=small}
![[Mojang] slicedlime](../../../data/assets/gravatar/slicedlime.jpeg){kind=small}
![[Mod] turbo](../../../data/avatars/users/92867.png){kind=small}
/place feature/structure sometimes doesnot cause block updates/place feature/structure sometimes doesn't cause blocks/lights to update
The bug
Placing a structure does
not appear to cause block updates, leaving water without a source in the world.
Code analysis
Code analysis by Hugman can be found in this comment.
The bug
Placing a structure or a feature doesn't appear to cause block updates or light updates, leaving water without a source in the world.
Code analysis
Code analysis by Hugman can be found in this comment.
Can confirm in 22w14a. MC-248199.mp4
MC-248199.png
It seems like the method used in the features that are incorrectly placed provide an incorrect argument: the flags.
With Fabric's mappings I was able to indentify that there was a "setBlockState" method within the "Feature" class that should be used for all features, but is not. They call for the more generic "setBlockState" method, in the "ModifiableWorld" class with the flags argument set to 3, which means "notify the neighbor blocks, listeners and the client when the block is placed". You can also notify only the listeners and the client by using the value 2. However, some features call for the generic "setBlockState" method with 4 as the argument, which tells the client to suppress the render pass on clients.
Feature classes that do not use the "notify listener" include:
In 1.19 Pre-3 and 1.18.2.
Can confirm in 23w03a
can confirm in 1.19.4, it's also sometimes don't update light
Request me to be the reporter of the issue, not only does the original reporter (Brain180) is inactive but also that reporter it's literally me.
Can confirm in 1.21.4