MC-250076Shading is disabled for the two inner planes in mangrove roots, even though it isn't for all the other planes
Found while testing MC-250075, likely relates to MC-236474, may also relate to MC-249087
The resource pack attached offers a complete fix for this issue. Mojang have my full permission to (and are encouraged to) replace the affected vanilla model files with the contents of the resource pack.
Download resource pack:
The bug
The two inner crossed planes which exist inside of mangrove roots have shading disabled, unlike all other parts of the block. This results in them appearing slightly different from the rest of the block; in general, they appear slightly brighter, and do not seem to be affected by smooth lighting to the extent they should be. This also appears to be the cause of the majority of MC-249087.
This furthers my theory that the mangrove roots model was created by combining the existing "cross" model (with element rotations removed) with the powder snow model, as the cross model has shading disabled (MC-57159) whereas powder snow does not. As such, this introduces inconsistencies within the model which can be averted entirely by removing the "shade: false" limes from it.
How to reproduce
- Place mangrove roots
- Look very closely at the inner planes
Expected results
The inner two planes would have the same brightness as the outer planes.
Actual results
The inner planes appear a tad lighter than the outer planes for a block in isolation, and tend to appear darker when the block is surrounded.
How to fix
This is a very easy fix - all of the '"shade": false' limes in the model should be deleted.
Alternatively, the resource pack attached to this issue could be used instead, which also fixes MC-250075.
Further notes
The "inverse" of this fix (i.e. adding '"shade": false' to each element) can be used to fully fix MC-236474, a bug which should be reopened as it isn't actually a duplicate, and is just as easy of a fix as this is.
Attachments8
LowCreated Issue:
Shading is disabeld for the two inner planes in mangrove roots, even though it isn't for all the other planes
Found while testing
MC-250075, likely relates to MC-236474, may also relate to MC-249087The bug
The two inner crossed planes which exist inside of mangrove roots have shading disabled, unlike all other parts of the block. This results in them appearing slightly different from the rest of the block; in general, they appear slightly brighter, and do not seem to be affected by smooth lighting to the extent they should be. This also appears to be the cause of the majority of MC-249087.
This furthers my theory that the mangrove roots model was created by combining the existing "cross" model (with element rotations removed) with the powder snow model, as the cross model has shading disabled (
MC-57159) whereas powder snow does not. As such, this introduces inconsistencies within the model which can be averted entirely by removing the "shade: false" limes from it.How to reproduce
- Place mangrove roots
- Look very closely at the inner planes
Expected results
The inner two planes would have the same brightness as the outer planes.
Actual results
The inner planes appear a tad lighter than the outer planes for a block in isolation, and tend to appear darker when the block is surrounded.
How to fix
This is a very easy fix - all of the '"shade": false' limes in the model should be deleted.
Further notes
The "inverse" of this fix (i.e. adding '"shade": false' to each element) can be used to fully fix MC-236474, a bug which should be reopened as it isn't actually a duplicate, and is just as easy of a fix as this is.
Attachments6
Shading is disabeld for the two inner planes in mangrove roots, even though it isn't for all the other planesShading is disabled for the two inner planes in mangrove roots, even though it isn't for all the other planes
![[Mod] ampolive](../../../data/avatars/users/18949.svg){kind=small}
![[Mojang] Chi Wong](../../../data/avatars/users/18941.svg){kind=small}
[Mojang] Chi WongFound while testing
MC-250075, likely relates to MC-236474, may also relate to MC-249087The resource pack attached offers a complete fix for this issue. Mojang have my full permission to (and are encouraged to) replace the affected vanilla model files with the contents of the resource pack.
Download resource pack:
The bug
The two inner crossed planes which exist inside of mangrove roots have shading disabled, unlike all other parts of the block. This results in them appearing slightly different from the rest of the block; in general, they appear slightly brighter, and do not seem to be affected by smooth lighting to the extent they should be. This also appears to be the cause of the majority of MC-249087.
This furthers my theory that the mangrove roots model was created by combining the existing "cross" model (with element rotations removed) with the powder snow model, as the cross model has shading disabled (
MC-57159) whereas powder snow does not. As such, this introduces inconsistencies within the model which can be averted entirely by removing the "shade: false" limes from it.How to reproduce
- Place mangrove roots
- Look very closely at the inner planes
Expected results
The inner two planes would have the same brightness as the outer planes.
Actual results
The inner planes appear a tad lighter than the outer planes for a block in isolation, and tend to appear darker when the block is surrounded.
How to fix
This is a very easy fix - all of the '"shade": false' limes in the model should be deleted.
Alternatively, the resource pack attached to this issue could be used instead, which also fixes
MC-250075.Further notes
The "inverse" of this fix (i.e. adding '"shade": false' to each element) can be used to fully fix MC-236474, a bug which should be reopened as it isn't actually a duplicate, and is just as easy of a fix as this is.
![[Bot] Piston](../../../data/avatars/users/31202.png){kind=small}
Relates to MC-236476
The resource pack attached offers a complete fix for this issue. Mojang have my full permission to (and are encouraged to) replace the affected vanilla model files with the contents of the resource pack.
Download resource pack:
The bug
The two inner crossed planes which exist inside of mangrove roots do not stretch to the sides of the block. This results in several of the pixels not matchign up correctly between different parts of the block, and also distorts the shapes of the pixels slightly.
Specifically, this is due to the texture planes in question spanning from 0.8 to 15.2, rather than the 0 to 16 that would be expected for this block.
This strongly implies that the mangrove roots model was created by splicing part of the existing "cross" model (with element rotations removed) into what appears to be the powder snow model, as the cross model has planes that span between these two values as to not have their texture planes appear too wide. However, in the mangrove roots block's case, this is pointless and causes avoidable problems.
How to reproduce
- Place mangrove roots
- Look very closely at the top and bottom
Expected results
The inner two planes would align pixel-perfectly with the top and bottom planes of the block.
Actual results
There is a very significant "desynchronization" between the pixels on the inner cross and the rest of the block, intensifying as the distance from the center increases.
How to fix
This is a very easy fix - all of the "0.8" values in the model should be changed to "0" and every "15.2" to "16".
Alternatively, the resource pack attached to this ticket can be used instead, which also fixes MC-250076.
Further notes
The "inverse" of this fix (i.e. changing element dimensions from "0 to 16" to "0.8 to 15.2") can be used to fully fix MC-236476, a bug I'd strongly recommend looking at again because it's a very, very easy fix.
This issue still affects 22w16b and should be reopened, since it isn't a duplicate at all. MC-250076, which is effectively the opposite of this issue for another block, was triaged, so this resolution now makes even less sense.
I can confirm this behavior. This ticket closely relates to MC-249087.
An example of the insides of roots appearing noticeably brighter than the outsides:
