MC-59511Tellraw has incomplete error message when key determining text to display is missing
The bug
When no key determining the text to display is present, the game shows an error message, however this error message is incomplete.
How to reproduce
Perform this command:
/tellraw @p {}
The error message is:
Invalid json:
The correct error message would be:
Invalid json: Don't know how to turn {} into a Component
The reason
The following is based on decompiled version of Minecraft 1.8 using MCP. All method and class names are the names used in the decompiled version.
The reason for this bug is that the public void processCommand(ICommandSender sender, String[] args) throws CommandException method of the net.minecraft.command.server.CommandMessageRaw (command /tellraw) and the net.minecraft.command.CommandTitle (command /title) class display any exception that occurs when the Json string is parsed using Throwable org.apache.commons.lang3.exception.ExceptionUtils.getRootCause(Throwable throwable). As there are however exceptions that are not thrown by the Json parser but by the net.minecraft.util.IChatComponent.Serializer class itself. The root cause is null. Instead it should just print the message of the exception.
The following shows how this could by done for the net.minecraft.command.server.CommandMessageRaw class.
public void processCommand(ICommandSender sender, String[] args) throws CommandException { if (args.length < 2) { throw new WrongUsageException("commands.tellraw.usage", new Object[0]); } else { EntityPlayerMP var3 = getPlayer(sender, args[0]); String var4 = func_180529_a(args, 1); try { IChatComponent var5 = IChatComponent.Serializer.jsonToComponent(var4); var3.addChatMessage(ChatComponentProcessor.func_179985_a(sender, var5, var3)); } catch (JsonParseException var7) { // Changed this //Throwable var6 = ExceptionUtils.getRootCause(var7); //throw new SyntaxErrorException("commands.tellraw.jsonException", new Object[] {var6 == null ? "" : var6.getMessage()}); throw new SyntaxErrorException("commands.tellraw.jsonException", new Object[] {var7.getMessage()}); } } }
Created Issue:
Tellraw in command block has incorrect previous output when tag is incorrect
- Perform this command:
/tellraw @p {TTTText:"Hi"}The previous output of the command block is:
[14:08:13] Invalid json:
Tellraw in command block has incorrectprevious output when tag is incorrectTellraw in command block has incomplete previous output when tag is incorrect
- Perform this command:
/tellraw @p {TTTText:"Hi"}The previous output of the command block is:
[14:08:13] Invalid json:
- Perform this command:
/tellraw @p {"#text":"Hi"}The previous output of the command block is:
[14:08:13] Invalid json:
Tellrawin command block has incomplete previous outputwhen tag is incorrectTellraw has incomplete error message when tag is incorrect
Tellraw has incomplete error message when tag is incorrectTellraw has incomplete error message when text component tag is missing
- Perform this command:
/tellraw @p {"#text":"Hi"}The
previous output of the command blockis:[14:08:13]Invalid json:
- Perform this command:
/tellraw @p {}The error message is:
Invalid json:This happens because no text component tag was found (text, translate...)
- Perform this command:
/tellraw @p {}The error message is:
Invalid json:This happens because no text component tag was found (text, translate...)
Tellraw has incomplete error message when text component tagis missingTellraw has incomplete error message when tag determining text to display is missing
Tellraw has incomplete error message whentagdetermining text to display is missingTellraw has incomplete error message when key determining text to display is missing
Please reopen
The bug
When no key determining the text to display is present, the game shows an error message, however this error message is incomplete.
How to reproduce
Perform this command:
/tellraw @p {}The error message is:
Invalid json:The reason
The following is based on decompiled version of Minecraft 1.8 using MCP. All method and class names are the names used in the decompiled version.
The reason for this bug is that the public void processCommand(ICommandSender sender, String[] args) throws CommandException method of the net.minecraft.command.server.CommandMessageRaw (command /tellraw) and the net.minecraft.command.CommandTitle (command /title) class display any exception that occurs when the Json string is parsed using Throwable org.apache.commons.lang3.exception.ExceptionUtils.getRootCause(Throwable throwable). As there are however exceptions that are not thrown by the Json parser but by the net.minecraft.util.IChatComponent.Serializer class itself. The root cause is null. Instead it should just print the message of the exception.
The following shows how this could by done for the net.minecraft.command.server.CommandMessageRaw class.
The bug
When no key determining the text to display is present, the game shows an error message, however this error message is incomplete.
How to reproduce
Perform this command:
/tellraw @p {}The error message is:
Invalid json:The reason
The following is based on decompiled version of Minecraft 1.8 using MCP. All method and class names are the names used in the decompiled version.
The reason for this bug is that the public void processCommand(ICommandSender sender, String[] args) throws CommandException method of the net.minecraft.command.server.CommandMessageRaw (command /tellraw) and the net.minecraft.command.CommandTitle (command /title) class display any exception that occurs when the Json string is parsed using Throwable org.apache.commons.lang3.exception.ExceptionUtils.getRootCause(Throwable throwable). As there are however exceptions that are not thrown by the Json parser but by the net.minecraft.util.IChatComponent.Serializer class itself. The root cause is null. Instead it should just print the message of the exception.
The following shows how this could by done for the net.minecraft.command.server.CommandMessageRaw class.public void processCommand(ICommandSender sender, String[] args) throws CommandException { if (args.length < 2) { throw new WrongUsageException("commands.tellraw.usage", new Object[0]); } else { EntityPlayerMP var3 = getPlayer(sender, args[0]); String var4 = func_180529_a(args, 1); try { IChatComponent var5 = IChatComponent.Serializer.jsonToComponent(var4); var3.addChatMessage(ChatComponentProcessor.func_179985_a(sender, var5, var3)); } catch (JsonParseException var7) { // Changed this //Throwable var6 = ExceptionUtils.getRootCause(var7); //throw new SyntaxErrorException("commands.tellraw.jsonException", new Object[] {var6 == null ? "" : var6.getMessage()}); throw new SyntaxErrorException("commands.tellraw.jsonException", new Object[] {var7.getMessage()}); } } }
The bug
When no key determining the text to display is present, the game shows an error message, however this error message is incomplete.
How to reproduce
Perform this command:
/tellraw @p {}The error message is:
Invalid json:The correct error message would be:
Invalid json: Don't know how to turn {} into a ComponentThe reason
The following is based on decompiled version of Minecraft 1.8 using MCP. All method and class names are the names used in the decompiled version.
The reason for this bug is that the public void processCommand(ICommandSender sender, String[] args) throws CommandException method of the net.minecraft.command.server.CommandMessageRaw (command /tellraw) and the net.minecraft.command.CommandTitle (command /title) class display any exception that occurs when the Json string is parsed using Throwable org.apache.commons.lang3.exception.ExceptionUtils.getRootCause(Throwable throwable). As there are however exceptions that are not thrown by the Json parser but by the net.minecraft.util.IChatComponent.Serializer class itself. The root cause is null. Instead it should just print the message of the exception.
The following shows how this could by done for the net.minecraft.command.server.CommandMessageRaw class.public void processCommand(ICommandSender sender, String[] args) throws CommandException { if (args.length < 2) { throw new WrongUsageException("commands.tellraw.usage", new Object[0]); } else { EntityPlayerMP var3 = getPlayer(sender, args[0]); String var4 = func_180529_a(args, 1); try { IChatComponent var5 = IChatComponent.Serializer.jsonToComponent(var4); var3.addChatMessage(ChatComponentProcessor.func_179985_a(sender, var5, var3)); } catch (JsonParseException var7) { // Changed this //Throwable var6 = ExceptionUtils.getRootCause(var7); //throw new SyntaxErrorException("commands.tellraw.jsonException", new Object[] {var6 == null ? "" : var6.getMessage()}); throw new SyntaxErrorException("commands.tellraw.jsonException", new Object[] {var7.getMessage()}); } } }
blocks
![[Mojang] Grum (Erik Broes)](../../../data/assets/gravatar/grum.png){kind=small}
![[Mojang] Searge (Michael Stoyke)](../../../data/assets/gravatar/searge.png){kind=small}
[Mojang] Searge (Michael Stoyke)![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
![[Mod] tryashtar](../../../data/avatars/users/41963.png){kind=small}
![[Mod] Pokechu22](../../../data/avatars/users/92931.png){kind=small}
Fixed in some 1.9 snapshot.
Output now is
That is because the key was missing quotes around it, I changed the description now, please reopen this report
Don't see a bug here. The JSON text
{}is simply an empty container of zero bytes, so the JSON parser spits out
I updated the description
This is fixed in 17w45b and possibly earlier versions