MC-215540Crossbows take triple durability damage when using Multishot
Crossbows deal triple the damage (damage per projectile launched) when using multishot. This is documented on sites such as gamepedia however I believe this is unintentional behavior based on the way the code for crossbows is written.
From what I can tell, there are two methods inside of ItemCrossbow that need to be examined for this issue. The first method iterates for the amount of stored projectiles and then calls another method. Let's call the first method "unloadCrossbow" and the second method "fireProjectile" for the sake of this report.
The fireProjectile method does multiple things. It accepts an ItemStack and then converts it to a projectile. Then it proceeds to fire the projectile with the provided angle, force etc. Past this point it damages the crossbow which is fine however it also plays a sound effect here.
Playing a sound effect here means it plays the shoot sound effect three times at once. It also damages the crossbow three times instead of three times the damage, at once. This also means that the unbreaking enchantment is checked three times for a single crossbow fire which doesn't make much sense. This can essentially be summed up to firing the crossbow three times at the same instant which seems like inconsistent behavior. This damaging and playing sound should instead be delegated to the "unloadCrossbow" method.
In short, the issue lies less with the dealing triple the damage (although I believe this to be unintentional), it's with how it is implemented and the inconsistent behavior that arises from it.
Created Issue:
Crossbows deal triple item damage when using Multishot
Crossbows deal triple the damage (damage per projectile launched) when using multishot. This is documented on sites such as gamepedia however I believe this is unintentional behavior based on the way the code for crossbows is written.
From what I can tell, there are two methods inside of ItemCrossbow that need to be examined for this issue. The first method iterates for the amount of stored projectiles and then calls another method. Let's call the first method "unloadCrossbow" and the second method "fireProjectile" for the sake of this report.
The fireProjectile method does multiple things. It accepts an ItemStack and then converts it to a projectile. Then it proceeds to fire the projectile with the provided angle, force etc. Past this point it damages the crossbow which is fine however it also plays a sound effect here.
Playing a sound effect here means it plays the shoot sound effect three times at once. It also damages the crossbow three times instead of three times the damage, at once. This also means that the unbreaking enchantment is checked three times for a single crossbow fire which doesn't make much sense. This can essentially be summed up to firing the crossbow three times at the same instant which seems like inconsistent behavior. This damaging and playing sound should instead be delegated to the "unloadCrossbow" method.
In short, the issue lies less with the dealing triple the damage (although I believe this to be unintentional), it's with how it is implemented and the inconsistent behavior that arises from it.
Environment
Environment doesn't affect this issue as this is a niche nms issue.
Environment doesn't affect this issueasthis is a niche nms issue.This issue is platform independent
![[Mod] tryashtar](../../../data/avatars/users/41963.png){kind=small}
Crossbowsdealtripleitemdamage when using MultishotCrossbows take triple durability damage when using Multishot
![[Mod] markderickson](../../../data/avatars/users/18946.svg){kind=small}
This issue is platform independent
![[Mod] LateLag](../../../data/avatars/users/92884.png){kind=small}
relates to
![[Mod] ampolive](../../../data/avatars/users/18949.svg){kind=small}
![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}
![[Mod] Jarl-Penguin](../../../data/avatars/users/92849.png){kind=small}
![[Mod] turbo](../../../data/avatars/users/92867.png){kind=small}
Whenever you charge a crossbow, it saves the list of itemstacks that need to be shot out of it at time of loading. This means that if there is a multishot enchantment, it clones the itemstack and stores it three times and saves it to NBT.
The multishot enchantment is not checked beyond the point of loading the crossbow. Instead it pulls the NBT list of items whenever the crossbow goes to be unloaded and iterates through the items that need to be converted into projectiles.
This means that charging a crossbow with multishot and then removing the enchantment from a grindstone will still result in the crossbow firing three projectiles and damaging the crossbow the incorrect amount of times. (See MC-215540)