MC-237427Horse flashing heart background texture is unused
The bug
Unlike with the player's health bar, the horse's health bar's background does not flash white either when taking damage or being healed. While this is closely related to MC-237326, it is not identical; it concerns the center of the hearts flashing rather than the outline, and only deals with taking damage rather than both damage and healing.
This is despite the fact that horse/animal hearts do in fact have a dedicated texture in icons.png for flashing in situations like this, rendering it unused.
How to reproduce
- Cause yourself to take damage, and then heal it
- Note that the outlines of the hearts flash white in the process
- Now cause a horse, pig or other rideable mob with a health bar to take damage, and heal it as well
- Note how the background hearts do not, in fact, flash white, even though they did for the player
Other thoughts
icons.png being a predefined texture atlas is problematic for many reasons. I would strongly recommend splitting it into its constituent sprites, as was done with terrain.png, items.png, particles.png and paintings_kristoffer_zetterstrand.png, to alleviate many problems, such as acknowledging the presence of unused icons like these and resolving their unusedness (either through their removal or by giving them use), alongside other problems such as allowing forwards compatibility.
Created Issue:
Horse flashing heart background texture is unused
The bug
Unlike with the player's health bar, the horse's health bar's background does not flash white either when taking damage or being healed. While this is closely related to
MC-237326, it is not identical; it concerns the center of the hearts flashing rather than the outline, and only deals with taking damage rather than both damage and healing.This is despite the fact that horse/animal hearts do in fact have a dedicated texture in icons.png for flashing in situations like this, rendering it unused.
How to reproduce
- Cause yourself to take damage, and then heal it
- Note that the outlines of the hearts flash white in the process
- Now cause a horse, pig or other rideable mob with a health bar to take damage, and heal it as well
- Note how the background hearts do not, in fact, flash white, even though they did for the player
Other thoughts
icons.png being a predefined texture atlas is problematic for many reasons. I would strongly recommend splitting it into its constituent sprites, as was done with terrain.png, items.png, particles.png and paintings_kristoffer_zetterstrand.png, to alleviate many problems, such as acknowledging the presence of unused icons like these and resolving their unusedness (either through their removal or by giving them use), alongside other problems such as allowing forwards compatibility.
Attachments7
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
![[Mod] markderickson](../../../data/avatars/users/18946.svg){kind=small}
![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}
The bug
When the player is damaged or heals, the hearts displayed above the hotbar will blink accordingly. The same does not happen for horses and other rideable mobs, despite the existence of dedicated textures for this purpose. These textures are present in icons.png as of 1.20.1, but remain unused (MC-237326, MC-237427).
How to reproduce
- Take damage yourself
- Have a mob you're riding take damage
- Compare visuals
Expected results
Flashing in both cases.
Actual results
It only happens for the player - the rideable mob's decrease with no extra visual indication.
How to fix
I've attached the three textures needed for this to work, extracted from a 1.20.1 icons.png file. These textures are to be placed in assets/minecraft/textures/gui/sprites/hud/heart. Code changes will be required for the game to actually use these textures.
I am able to confirm this in 1.17.1 and 21w38a. The expected behavior would be that the horse flashing heart background texture (white heart online), would be displayed when horses take damage whilst riding them.
Affects 21w44a
Can confirm in 1.18.1.
In 1.18.2 and 22w16b.
Can confirm in 1.19.3 and 23w03a
This texture appears to have been removed in 23w31a and therefore this ticket might qualify as fixed. Can anyone confirm?