MC-255639Ancient city does not use camp_1, camp_2 or camp_3 structures, but instead generates a single union of all three combined
When ancient cities are generated, the camp site structure will be generated as a combined union of all three variants camp_1, camp_2, and camp_3, instead of a single structure from one of the listed variants.
Steps to Reproduce:
Generate a new world, and locate one or more ancient city with camp a site structure(s).
/locate structure minecraft:ancient_city
Expected Results:
Using the /place template command, these are the results of specifying the camp_1, camp_2, and camp_3 structure files, respectively, and are what would be expected to be seen in any Ancient City with one or more camp sites:
Observed Results:
Seed -977118593:
X: -353 Y: -40 Z: 1378 (Two identical camp sites of unknown structure):
X: 367 Y: -45 Z: 1327 (This is near the previous screenshot; the other identical campsites in previous image can be seen in the background. This one is also identical and unknown.)
Seed 5305220127415150578:
X: 163 Y: -45 Z: 122
X: 53 Y: -45 Z: 133
X: -306 Y: -45 Z: 542
Created Issue:
Java Ancient Cities use neither camp_1, camp_2 nor camp_3 structures and instead generate a single unknown camp site
When Ancient Cities are generated in Java Edition, they use a single camp site structure which is neither the place-available camp_1, camp_2, or camp_3 structures. It is a mystery as to where this structure data is coming from.
Steps to reproduce:
Generate a new world and locate one or more Ancient Cities with camp site structures. See the Observed Results below for some examples seeds and coordinates.
Expected Results:
Using the /place template command, these are the results of specifying the camp_1, camp_2, and camp_3 structure files, respectively, and are what would be expected to be seen in any Ancient City with one or more camp sites:
Observed Results:
Seed -977118593:
X: -353 Y: -40 Z: 1378 (Two identical camp sites of unknown structure):
X: 367 Y: -45 Z: 1327 (This is near the previous screenshot; the other identical campsites in previous image can be seen in the background. This one is also identical and unknown.)
Seed 5305220127415150578 (20+ Ancient Cites around spawn; here are a few examples, all are consistently generating a single unknown camp site structure):
X: 163 Y: -45 Z: 122
X: 53 Y: -45 Z: 133
X: -306 Y: -45 Z: 542
Environment
Windows 10 21H2 16GB RAM GeForce GTX 980
Built-in Java 17.0.3 64-bit
-Xmx6G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
Attachments8
![[Mod] tryashtar](../../../data/avatars/users/41963.png){kind=small}
Windows 10 21H2 16GB RAM GeForce GTX 980
Built-in Java 17.0.3 64-bit
-Xmx6G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
![[Mojang] Moesh](../../../data/avatars/users/10122.svg){kind=small}
Low![[Mojang] slicedlime](../../../data/assets/gravatar/slicedlime.jpeg){kind=small}
![[Mod] Jiingy](../../../data/avatars/users/91802.png){kind=small}
When Ancient Cities are generated in Java Edition, they use a single camp site structure which is neither the place-available camp_1, camp_2, or camp_3 structures. It is a mystery as to where this structure data is coming from.
Steps to reproduce:Generate a new world and locate one or more
AncientCitieswith camp site structures. See the Observed Results below for some examples seeds and coordinates.Expected Results:
Using the /place template command, these are the results of specifying the camp_1, camp_2, and camp_3 structure files, respectively, and are what would be expected to be seen in any Ancient City with one or more camp sites:
Observed Results:
Seed -977118593:
X: -353 Y: -40 Z: 1378 (Two identical camp sites of unknown structure):
X: 367 Y: -45 Z: 1327 (This is near the previous screenshot; the other identical campsites in previous image can be seen in the background. This one is also identical and unknown.)
Seed 5305220127415150578 (20+ Ancient Cites around spawn; here are a few examples, all are consistently generating a single unknown camp site structure):
X: 163 Y: -45 Z: 122
X: 53 Y: -45 Z: 133
X: -306 Y: -45 Z: 542
When ancient cities are generated, the camp site structure will be generated as a combined union of all three variants camp_1, camp_2, and camp_3, instead of a single structure from one of the listed variants.
Steps to Reproduce:
Generate a new world, and locate one or more ancient city with camp a site structure(s).
/locate structure minecraft:ancient_cityExpected Results:
Using the /place template command, these are the results of specifying the camp_1, camp_2, and camp_3 structure files, respectively, and are what would be expected to be seen in any Ancient City with one or more camp sites:
Observed Results:
Seed -977118593:
X: -353 Y: -40 Z: 1378 (Two identical camp sites of unknown structure):
X: 367 Y: -45 Z: 1327 (This is near the previous screenshot; the other identical campsites in previous image can be seen in the background. This one is also identical and unknown.)
Seed 5305220127415150578:
X: 163 Y: -45 Z: 122
X: 53 Y: -45 Z: 133
X: -306 Y: -45 Z: 542
JavaAncientCities use neithercamp_1, camp_2nor camp_3 structuresandinstead generate a single unknown camp siteAncient city does not use camp_1, camp_2 or camp_3 structures, but instead generates a single union of all three combined
![[Mod] Jarl-Penguin](../../../data/avatars/users/92849.png){kind=small}
Looks to me like all 3 camps are generating on top of each other
That could very well be what's happening. Good eye!
If you open up the Minecraft jar and look at the worldgen JSON files it ships with it, under data/minecraft/worldgen/template_pool/ancient_cities/structures.json, you will find in there that the city uses a "minecraft:list_pool_element" type to intentionally combine the three nbt files. Likely an attempt at combining them with a rot processor like Outpost towers do. however, they all run "minecraft:ancient_city_generic_degradation" processor list which only rots blocks under #minecraft:ancient_city_replaceable block tag which does not include Blue Wool or Light Blue Wool. Which means all three NBT camp files will combine always with no change.
Maybe the bug is a missing rot processor for Blue Wool and Light Blue Wool for this template pool entry. It is intended they all spawn in the same spot. The missing rotting is likely the actual bug part. That or they decided against the rotting and just replaced it with the normal processor to disable the wool rotting.
Quick way to see what I am talking about: https://github.com/misode/mcmeta/blob/ce568022daf9a26bf6625e96fd56fb3e0f068c32/data/minecraft/worldgen/template_pool/ancient_city/structures.json#L108-L134
Thank you TelepathicGrunt for the info! I still find it odd these well-designed camp site structures would be allowed to generate on top of one another and rely on wool block degradation to uncover something of the original design. My reasoning for this is due to it being unlikely the rot would ever work reliably enough to allow the lit campfire present in camp_3 to actually function as designed.
I feel like the use of list_pool_element was perhaps a placeholder until a "random_pool_element" node could be implemented, kind of like how the randomize node works over in the Bedrock Edition entity event system.
I hope they change things so the three separate structures are generated in their original designs. The ones with the campfires make for great oases when exploring the Ancient Cities when playing over on Bedrock Edition.