Sharp lag spike caused by incorrect upper limit on particles created by mace smash attack
There is no obvious upper limit to the particles created by the mace, leading to a decrease in FPS when finishing the attack from high distances. Related very closely to MC-270216
Steps to Reproduce:
- Place down an armor stand
- Hold a mace
- Teleport the player 10 blocks into the air
/tp @p ~ ~10 ~
- Land a 'heavy' attack
→ Observe results - Repeat steps 3 and 4, this time increasing the height to 200 blocks up
/tp @p ~ ~200 ~
→ Observe results
Expected & Observed Results:
- There will be a heavy amount of particles creating, leading to a large FPS decrease upon landing a heavy attack.
- The particles would have an upper limit to avoid FPS problems when scaling the attack with height.
Screenshots/Videos:
Created Issue:
Incorrect upper limit on particles created by mace smash attack, leading to FPS decrease
There is no upper limit to the particles created by the mace, leading to a decrease in FPS when finishing the attack
Steps to Reproduce:
- Place down an armor stand
- Hold a mace
- Teleport the player 10 blocks into the air
/tp @p ~ ~10 ~- Land a 'heavy' attack
→ Observe results- Repeat steps 3 and 4, this time increasing the height to 200 blocks up
/tp @p ~ ~200 ~Expected & Observed Results:
- There will be a heavy amount of particles creating, leading to a large FPS decrease upon landing a heavy attack.
- The particles would have an upper limit to avoid FPS problems when scaling the attack with height.
Screenshots/Videos:
There is no upper limit to the particles created by the mace, leading to a decrease in FPS when finishing the attack
Steps to Reproduce:
- Place down an armor stand
- Hold a mace
- Teleport the player 10 blocks into the air
/tp @p ~ ~10 ~- Land a 'heavy' attack
→ Observe results- Repeat steps 3 and 4, this time increasing the height to 200 blocks up
/tp @p ~ ~200 ~→ Observe results
Expected & Observed Results:
- There will be a heavy amount of particles creating, leading to a large FPS decrease upon landing a heavy attack.
- The particles would have an upper limit to avoid FPS problems when scaling the attack with height.
Screenshots/Videos:
There is no upper limit to the particles created by the mace, leading to a decrease in FPS when finishing the attack
Steps to Reproduce:
- Place down an armor stand
- Hold a mace
- Teleport the player 10 blocks into the air
/tp @p ~ ~10 ~- Land a 'heavy' attack
→ Observe results- Repeat steps 3 and 4, this time increasing the height to 200 blocks up
/tp @p ~ ~200 ~→ Observe results
Expected & Observed Results:
- There will be a heavy amount of particles creating, leading to a large FPS decrease upon landing a heavy attack.
- The particles would have an upper limit to avoid FPS problems when scaling the attack with height.
Screenshots/Videos:
There is no obvious upper limit to the particles created by the mace, leading to a decrease in FPS when finishing the attack from high distances
Steps to Reproduce:
- Place down an armor stand
- Hold a mace
- Teleport the player 10 blocks into the air
/tp @p ~ ~10 ~
- Land a 'heavy' attack
→ Observe results- Repeat steps 3 and 4, this time increasing the height to 200 blocks up
/tp @p ~ ~200 ~→ Observe results
Expected & Observed Results:
- There will be a heavy amount of particles creating, leading to a large FPS decrease upon landing a heavy attack.
- The particles would have an upper limit to avoid FPS problems when scaling the attack with height.
Screenshots/Videos:
FPS dipcaused by incorrect upper limit on particles created by mace smash attackSharp FPS loss caused by incorrect upper limit on particles created by mace smash attack
There is no obvious upper limit to the particles created by the mace, leading to a decrease in FPS when finishing the attack from high distances
Steps to Reproduce:
- Place down an armor stand
- Hold a mace
- Teleport the player 10 blocks into the air
/tp @p ~ ~10 ~
- Land a 'heavy' attack
→ Observe results- Repeat steps 3 and 4, this time increasing the height to 200 blocks up
/tp @p ~ ~200 ~→ Observe results
Expected & Observed Results:
- There will be a heavy amount of particles creating, leading to a large FPS decrease upon landing a heavy attack.
- The particles would have an upper limit to avoid FPS problems when scaling the attack with height.
Screenshots/Videos:
There is no obvious upper limit to the particles created by the mace, leading to a decrease in FPS when finishing the attack from high distances. Related very closely to
MC-270216Steps to Reproduce:
- Place down an armor stand
- Hold a mace
- Teleport the player 10 blocks into the air
/tp @p ~ ~10 ~- Land a 'heavy' attack
→ Observe results- Repeat steps 3 and 4, this time increasing the height to 200 blocks up
/tp @p ~ ~200 ~→ Observe results
Expected & Observed Results:
- There will be a heavy amount of particles creating, leading to a large FPS decrease upon landing a heavy attack.
- The particles would have an upper limit to avoid FPS problems when scaling the attack with height.
Screenshots/Videos:
SharpFPS losscaused by incorrect upper limit on particles created by mace smash attackSharp lag spike caused by incorrect upper limit on particles created by mace smash attack
The particles created from a mace's smash attack cannot be reduced by turning the Particles option to a lower setting, such as Decreased, or Minimal. This is a problem, as the smash attack creates a lot of particles which visually clutter the player's screen when preforming the attack. Some players may have difficulty with these particles and their density.
Steps to Reproduce:
- Turn the Particles setting to All
- Get a mace
- Perform a smash attack from 3 blocks up or higher
→
Particles function as usual - Turn the Particles setting to Decreased, or Minimal
- Repeat step 3
→
Nothing changes, and the particle count is the same.
Screenshots/Videos:
Notes:
(This issue originates from snapshot 24w13a, when the smash attack particles were added)
If the player performs a smash attack onto a player (or entity in general) that is standing on top of a shulker entity, no particles will be created. This is unexpected, as the "crackling" sounds are created, indicating the attacked entity is standing on solid ground.
Steps to Reproduce:
- Spawn a shulker with NoAI
/summon shulker ~ ~ ~ {NoAI:1b} - Place a player or entity on top of the shulker
- With a mace, fall far enough to perform a smash attack onto the targeted entity
Observed Behavior:
The smash attack sound, and the crackling block sounds will play, the entity will take damage, but no particles will be produced.
Expected Result:
Because shulkers appear as blocks, and their actual block counterparts produce particles, it would be expected that shulkers also would create particles, as they are a solid surface that the player can stand on.
Screenshots/Videos:
Notes:
Related to:
MC-129795 MC-101950 MC-112653 MC-269370 MC-269379
Would it be possible to take the logarithm of the height and use that to generate the particles instead of it scaling linearly?
Effect is even more noticable now, with additional particles
MaceParticle_24w13a.mp4