Dispenser Recipe uses Enchanted Bow
If you make an dispenser using the recipe book, it also uses your special full enchanted bow. If you click to fast (like i did) your bow is gone...
How to reproduce it:
1. Start creative world.
2. Go to Inventory and grab a stack of cobblestone, redstone, one bow and crafting table.
3. Place down the Crafting Table.
4. Select the bow on your hotbar and type /enchant <player> minecraft:infinity .
5. Now open the Crafting Table and make a dispenser using the recipe book.
Possible way(s) to fix:
1. It is no longer possible to craft dispensers with a enchanted bow using the recipe book.
2. If a bow is renamed the bow can not be used to craft a dispenser.
Linked Issues
relates to5
MC-160904Right clicking on obstructed chest/shulker box plays hand animation despite no action actually taking place, overriding item uses
NormalMC-117563Crash when using enchanted bow to craft dispenser via recipe bookFixedMC-117714Clicking on dispenser recipe while only having enchanted bow in inventory places other ingredients anywaysFixedMC-118030The recipe book shows dispenser as unavailable when you only have enchanted bowsWorks As IntendedMC-129057The recipe book doesn't move ingredients that have NBT dataWorks As Intended
Created Issue:
Dispenser Recipe uses Enchanted Bow
If you make an dispenser using the recipe book, it also uses your special full enchanted bow. If you click to fast (like i did) your bow is gone...
Possible way(s) to fix:
1. It is no longer possible to craft dispensers with a enchanted bow using the recipe book.
2. If a bow is renamed the bow can not be used to craft a dispenser.
If you make an dispenser using the recipe book, it also uses your special full enchanted bow. If you click to fast (like i did) your bow is gone...
Possible way(s) to fix:1. It is no longer possible to craft dispensers with a enchanted bow using the recipe book.
2. If a bow is renamed the bow can not be used to craft a dispenser.
If you make an dispenser using the recipe book, it also uses your special full enchanted bow. If you click to fast (like i did) your bow is gone...
How to reproduce it:
1. Start creative world.
2. Go to Inventory and grab a stack of cobblestone, redstone, one bow and crafting table.
3. Place down the Crafting Table.
4. Select the bow on your hotbar and type /enchant <player> minecraft:infinity .
5. Now open the Crafting Table and make a dispenser using the recipe book.
Possible way(s) to fix:
1. It is no longer possible to craft dispensers with a enchanted bow using the recipe book.
2. If a bow is renamed the bow can not be used to craft a dispenser.
Maria Lemón![[Mod] Neko](../../../data/avatars/users/92901.png){kind=small}
relates to
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
relates to
![[Mod] Pokechu22](../../../data/avatars/users/92931.png){kind=small}
relates to
![[Mod] NeunEinser](../../../data/avatars/users/39263.png){kind=small}
When testing what the resolution had been to MC-116905 I tested a few scenarios.
1. A few unenchanted bows, a few curse of vanishing bows and a few mending bows.
2. Same as above, but with the unenchanted bows thrown onto the ground.
In scenario 1 I was pleased to see that no matter which order I placed the bows in my inventory, the unenchanted ones were always used.
In scenario 2, as soon as I clicked on the recipe, the game crashed (report attached).
Note that in scenario 2, the dispenser still showed as "available". I don't know if it is intended to be able to craft dispensers with enchanted (or damaged?) bows, but either way this is still causing issues.
-----------------------------------------------
Personally, I would vote for enchanted and damaged bows being valid when used manually, but not used by the recipe book since it is too easy to accidentally craft away your best bow. If that is too clunky, then I would vote against crafting with enchanted bows.
![[Mod] tryashtar](../../../data/avatars/users/41963.png){kind=small}
The bug
As of the snapshots, any shapeless recipe cannot be crafted if any of its reagents are named or enchanted. This does not affect shaped recipes.
For example, "flint and steel" cannot be crafted if either ingredient has been renamed in an anvil. Regarding single-item recipes (such as bones to bonemeal or ingots to nuggets), the crafting files are inconsistent, sometimes defining them as shapeless and sometimes as shaped, but with one ingredient. Only recipes defined as shapeless are affected.
Code analysis by [Mod] Pokechu22:
In the snapshots, the code for ShapelessRecipes.matches was changed from using a List<Ingredient> and several loops checking ingredient.apply to using RecipeItemHelper and accountStack. ingredient.apply did not care about NBT, but in RecipeItemHelper:
public void accountStack(ItemStack stack) { if (!stack.isEmpty() && !stack.isItemDamaged() && !stack.isItemEnchanted() && !stack.hasDisplayName()) { int i = pack(stack); int j = stack.getCount(); this.increment(i, j); } }
Shaped recipes continue to use ingredient.apply, so they are not affected.
RecipeItemHelper is "mainly for the recipe book" deciding which items should be selected (to fix MC-116905), but it's also rendering those items invalid in the recipe itself. Again, this only affects shapeless recipes. If it is intended that named/enchanted items should be disallowed as crafting reagents, then shaped recipes should follow suit.
And also MC-116905 – I think that's why the game explicitly ignores NBT, to avoid using enchanted items.
Probably invalid, there might be reasons as well why you would want to craft a dispenser with an enchanted / named bow, for example if it is enchanted with "Curse of Vanishing".
Yeah, that is true. However another option would be that the recipe book places all block in the right space except the bow. This ways you have to place it in yourself, so you can make sure which bow is used. I know this is not the idea behind the recipe book, however it saves a lot of time getting your enchanted bow back.
I agree that it can be valid to craft a dispenser with an enchanted bow, but I strongly believe that the recipe book's auto-fill should scan the inventory for any usable non-enchanted bow and use that before trying to use an enchanted bow.
I just accidentally lost my best bow because the enchanted bow always seems to be picked first (which may be because it's on the hotbar).
It looks like
MC-117569may relate to the fix for this.I just lost a strongly enchanted bow to this too. I understand how it might not technically be classed as a bug since it is a result of working features, however a system needs to be put in place to prevent excessive user error.
Issue : The dispenser prioritises your main enchanted bow in your hotbar over the unenchanted bows in your inventory. Since players often carry bows as a permanent fixture in their hotbar it is far too easy to forget that it is there. Most players will not wish to use enchanted bows in their recipes. I imagine that the vast majority of incidents where players have used enchanted bows have been in error.
Solution : Have the crafting for this item prioritise unenchanted items. Or better yet, make it so that you literally have to drag enchanted items into the recipe in order to use them.