MC-190053Bottom of liquids are not rendered from above
Likely relates to MC-34751 (recommending change of resolution from Closed to Resolved).
The bug
Despite having internal top and side faces, fluids do not render their bottom faces at all, even though they should.
A leftover bug from 1.7's changes - MC-35658 added back the top face and MC-40621 the side faces, but the bottom face remains absent despite existing beforehand.
How to fix
Could be fixed by making fluids use models like items and blocks do.
Linked Issues
MCPE-152993
![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}
NormalCreated Issue:
Bottom of liquids are not rendered from within
They should be, like all other faces.
Attachments3
![[Mod] violine1101](../../../data/avatars/users/92858.png){kind=small}
![[Mojang] Adrian Östergård](../../../data/assets/gravatar/nighter.jpeg){kind=small}
Bottom of liquids are not rendered fromwithinBottom of liquids are not rendered from above
![[Mod] Chandler](../../../data/assets/gravatar/triwonder81.png){kind=small}
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
relates to
They should be, like all other faces.
Could be fixed by making fluids use models like items and blocks do.
They should be, like all other faces.
Could be fixed by making fluids use models like items and blocks do.
![[Mod] ampolive](../../../data/avatars/users/18949.svg){kind=small}
Likely relates to
MC-34751(recommending change of resolution from Closed to Resolved).The bug
Despite having internal top and side faces, fluids do not render their bottom faces at all, even though they should.
A leftover bug from 1.7's changes -
MC-35658added back the top face andMC-40621the side faces, but the bottom face remains absent despite existing beforehand.How to fix
Could be fixed by making fluids use models like items and blocks do.
![[Mod] OcelotOnesie](../../../data/avatars/users/43220.png){kind=small}
relates to
![[Mojang] slicedlime](../../../data/assets/gravatar/slicedlime.jpeg){kind=small}
2024-05-05_19.31.48.png
I believe the effect of a "fix" for this issue can be simulated by removing ` || !this.isSideExposed(level, posX, posY, posZ, Direction.DOWN, 0.8888889F)` from [this line in sodium](https://github.com/CaffeineMC/sodium-fabric/blob/d2a68153e5bb6ad59258db5b8e3604e8292f565b/src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/compile/pipeline/DefaultFluidRenderer.java#L114). I've attached pictures of my result in two scenes: one in some water next to a tree and another scene under water in a river.
As you can see it's much darker overall and very different looking. I also think that for consistency reasons you'd need to apply the same effect to the sides of blocks, which makes it even weirder. Possibly making all the inner water surfaces underwater full brightness would make the whole scene less dark, but it would certainly be very blue.
IMO this is an art direction question and not simply an issue of "the fluid renderer is wrong". Even if it could be construed as a matter of visual consistency, it's anything but consistent with what I'd expect to see on the inside of a fluid. (Assuming this patch is actually correct)
You can see there's some lighting issues that would need to be addressed but I think it gets the point across. Realistically, it also doesn't make much sense to have inner water surfaces against blocks, because you know, that's not how water surfaces work irl either.(for some reason these images show up very large, idk how to do this better)
without:
with:
without:
with:
Found while testing MCPE-152993 and closely relates to MC-190053 and MCPE-34085.
The bug
Unlike water, lava does not have any interior planes corresponding to the outside six.
How to reproduce
- Recreate the setup shown in the screenshots attached
- Enter the lava such that it isn't foggy, as to make any inside planes clearly visible
Expected results
There would be planes inside of the lava cuboid.
Actual results
There are absolutely none.
Definitely related to MC-190053.
The bug
Snapshot 15w43b for 1.9 fixed MC-35790, an issue that made water hard to see through against glass due to it displaying the flowing texture. The fix made it display a flat, solid-colour texture instead. However, this also changed how glass looks from inside of the water - no texture is rendered against the glass at all. It'd be expected that the same flat water texture would be visible from inside the water, but this is not the case.
The inner top texture is correctly rendered against glass blocks (however it also renders some excess water textures incorrectly - see MC-175133). The inner bottom texture is not rendered in any circumstances at all, even though it should be - see MC-190053.
How to reproduce
- Build a hollow stone cube with glass windows (example world provided)
- View the windows from inside
Expected result
Translucent blue texture would be rendered on top of the glass.
Actual results
It is not.
Can confirm in 20w46a.
Can confirm in 1.16.5.
Can confirm in 1.17.
Can confirm in 1.17.1. MC-190053 - 1.17.1.png
Can confirm in 1.18.1.
Can confirm in 1.18.2.
Can confirm in 1.19 and 1.19.1 Pre-release 1.
Can confirm in 1.19.2.