MC-262410Brewing stand arms appear darker than they should
Finally time to get around to reporting this - I've been holding on to this one for a couple of years at this point. Closely related to MC-236474 (which is not a duplicate), MC-129826 and MC-214662.
The bug
The three arms that come off of brewing stands appear darker than they should due to the absence of '"shade": false' entries for these elements.
This was originally reported under MC-68302. Since three cases of this have been split off into other tickets (MC-129826, MC-214662 and MC-236474), this is following suit, as it's fixable via models only (unlike the mushroom case, for example, which is reported under MC-248703 and is a rendering issue rather than a model issue).
How to reproduce
This can be done easily by comparing a brewing stand (clearest if bottles are present within) in 1.7.10 or earlier to one in 1.8 or later. The older brewing stand will correctly have the bottles appear bright, whereas in modern versions they appear dark.
How to fix
I have attached two resource packs to this ticket to fix this issue. The "45-degree fix" is the simplest one, and is designed to work with the current model. It functionally only changes the arm models to include the parameter that disables shading. I've also cleaned up the model code and added a missing cullface parameter to the middle rod.
There is also a "60-degree fix", which rotates the arms to be at 120-degree angles from each other, which is another thing that changed in 1.8 (MC-257054). However, as Minecraft: Java Edition does not currently support rotation values in increments other than 22.5 degrees, the game's code will need to be modified to permit this. The screenshots of this model were taken in 1.16.1 using the ModelsUnlocked Fabric mod to permit this.
Linked Issues
MCPE-170432Attachments10
Created Issue:
Brewing stand arms appear darker than they should
Finally time to get around to reporting this - I've been holding on to this one for a couple of years at this point. Closely related to MC-236474 (which is not a duplicate),
MC-129826andMC-214662.The bug
The three arms that come off of brewing stands appear darker than they should due to the absence of '"shade": false' entries for these elements.
This was originally reported under
MC-68302. Since three cases of this have been split off into other tickets (MC-129826,MC-214662and MC-236474), this is following suit, as it's fixable via models only (unlike the mushroom case, for example, which is reported underMC-248703and is a rendering issue rather than a model issue).How to reproduce
This can be done easily by comparing a brewing stand (clearest if bottles are present within) in 1.7.10 or earlier to one in 1.8 or later. The older brewing stand will correctly have the bottles appear bright, whereas in modern versions they appear dark.
How to fix
I have attached two resource packs to this ticket to fix this issue. The "45-degree fix" is the simplest one, and is designed to work with the current model. It functionally only changes the arm models to include the parameter that disables shading. I've also cleaned up the model code and added a missing cullface parameter to the middle rod.
There is also a "60-degree fix", which rotates the arms to be at 120-degree angles from each other, which is another thing that changed in 1.8 (
MC-257054), and I believe would bring the model closer in parity to Bedrock Edition. However, as Minecraft: Java Edition does not currently support rotation values in increments other than 22.5 degrees, the game's code will need to be modified to permit this.
Attachments10
Finally time to get around to reporting this - I've been holding on to this one for a couple of years at this point. Closely related to MC-236474 (which is not a duplicate),
MC-129826andMC-214662.The bug
The three arms that come off of brewing stands appear darker than they should due to the absence of '"shade": false' entries for these elements.
This was originally reported under
MC-68302. Since three cases of this have been split off into other tickets (MC-129826,MC-214662and MC-236474), this is following suit, as it's fixable via models only (unlike the mushroom case, for example, which is reported underMC-248703and is a rendering issue rather than a model issue).How to reproduce
This can be done easily by comparing a brewing stand (clearest if bottles are present within) in 1.7.10 or earlier to one in 1.8 or later. The older brewing stand will correctly have the bottles appear bright, whereas in modern versions they appear dark.
How to fix
I have attached two resource packs to this ticket to fix this issue. The "45-degree fix" is the simplest one, and is designed to work with the current model. It functionally only changes the arm models to include the parameter that disables shading. I've also cleaned up the model code and added a missing cullface parameter to the middle rod.
There is also a "60-degree fix", which rotates the arms to be at 120-degree angles from each other, which is another thing that changed in 1.8 (
MC-257054), and I believe would bring the model closer in parity to Bedrock Edition. However, as Minecraft: Java Edition does not currently support rotation values in increments other than 22.5 degrees, the game's code will need to be modified to permit this. The screenshots of this model were taken in 1.16.1 using the ModelsUnlocked Fabric mod to permit this.
Finally time to get around to reporting this - I've been holding on to this one for a couple of years at this point. Closely related to MC-236474 (which is not a duplicate),
MC-129826andMC-214662.The bug
The three arms that come off of brewing stands appear darker than they should due to the absence of '"shade": false' entries for these elements.
This was originally reported under
MC-68302. Since three cases of this have been split off into other tickets (MC-129826,MC-214662and MC-236474), this is following suit, as it's fixable via models only (unlike the mushroom case, for example, which is reported underMC-248703and is a rendering issue rather than a model issue).How to reproduce
This can be done easily by comparing a brewing stand (clearest if bottles are present within) in 1.7.10 or earlier to one in 1.8 or later. The older brewing stand will correctly have the bottles appear bright, whereas in modern versions they appear dark.
How to fix
I have attached two resource packs to this ticket to fix this issue. The "45-degree fix" is the simplest one, and is designed to work with the current model. It functionally only changes the arm models to include the parameter that disables shading. I've also cleaned up the model code and added a missing cullface parameter to the middle rod.
There is also a "60-degree fix", which rotates the arms to be at 120-degree angles from each other, which is another thing that changed in 1.8 (
MC-257054), and I believe would bring the model closer in parity to Bedrock Edition. However, as Minecraft: Java Edition does not currently support rotation values in increments other than 22.5 degrees, the game's code will need to be modified to permit this. The screenshots of this model were taken in 1.16.1 using the ModelsUnlocked Fabric mod to permit this.
![[Mod] turbo](../../../data/avatars/users/92867.png){kind=small}
relates to
![[Mod] Les3awe](../../../data/avatars/users/79847.png){kind=small}
relates to
![[Mod] Jarl-Penguin](../../../data/avatars/users/92849.png){kind=small}
relates to
Relates to MC-262410.
The bug
The three arms of brewing stands appear much darker than one would expect, to the point of being even darker than they are in Java Edition.
How to reproduce
- Place a brewing stand
- Optional but recommended for clarity: fill all three slots
Expected results
The arms and bottles would not be shaded at all, and would appear just as bright as a flower, for example.
Actual results
They look very, very dark.
Closely relates to MC-129826, MC-214662, MC-236474 and MC-262410.
The bug
When placed, mangrove propagules appear darker than other cross models and darker than their item form would imply.
How to reproduce
- Place a mangrove propagule
- Compare it to its item texture
Expected results
The mangrove propagule would be brighter.
Actual results
It isn't.
How to fix
This is an incredibly easy fix - just add
"shade": false
to each of the four elements of models/block/mangrove_propagule.json. I've attached a fixed model file and fixed resource pack to demonstrate this fix. Mojang have my full permission to use this fix.
Further notes
Potted mangrove propagules are also affected and will need a separate fix (MC-129826's fix alone will not carry over to them). MC-262433's optimization fixes this issue for potted mangrove propagules.
Relates to: MC-129826 MC-214662 MC-236474 MC-262410 MC-262676 MC-262696
The bug
For normal potted cross models, shading is not applied to the cross planes (a 10-year-old issue that was finally fixed in 1.21.2: see MC-129826). However, the newly implemented flower_pot_cross_emissive.json model unaccountably shades each plane of the cross for unknown reasons. This causes one plane to look darker than the other.
How to fix
Very easy to fix - just add
"shade": false,
to the four last planes in that json model so that they appear at the correct brightness in-game.
This same general idea can also be used to fix MC-236474, MC-262410, MC-262676 and MC-262696, the other four extant erroneous model shading issues.
Can confirm 1.21.4.