Item frame models are quite unoptimized
The bug
The models that item frames use (normal and containing maps) define far more faces than are actually necessary. They both define 22 texture planes, whereas the exact same visual result can be achieved with 18 planes for the normal item frame and 14 planes for the map item frame. The only noticeable difference is how the item frame looks when the player clips inside, which is not a concern at all.
The end result is an item frame model whose file size is smaller, as well as an increase in performance if many item frames are present, which should make map walls and storage rooms less laggy, among other things.
How to reproduce
If you have a map room, storage area, or some other situation where a lot of item frames exist and you get noticeable FPS drops, try the attached resource pack and see if the situation improves.
How to fix
This is a very easy fix - all that needs done is for the template_item_frame.json and template_item_frame_map.json model files in vanilla to be replaced with those in the resource pack attached to this ticket. Mojang has my full permission (and strong encouragement) to use these models in the vanilla game to replace what is used currently.
Linked Issues
testing discovered1
relates to15
Created Issue:
Item frame models are quite unoptimized
Close relative of MC-262427,
MC-262433, MC-262452 and MC-262461.The bug
The models that item frames use (normal and containing maps) define far more faces than are actually necessary. They both define 22 texture planes, whereas the exact same visual result can be achieved with 18 planes for the normal item frame and 14 planes for the map item frame. The only noticeable difference is how the item frame looks when the player clips inside, which is not a concern at all.
The end result is an item frame model whose file size is smaller, as well as an increase in performance if many item frames are present, which should make map walls and storage rooms less laggy, among other things.
How to reproduce
If you have a map room, storage area, or some other situation where a lot of item frames exist and you get noticeable FPS drops, try the attached resource pack and see if the situation improves.
How to fix
This is a very easy fix - all that needs done is for the template_item_frame.json and template_item_frame_map.json model files in vanilla to be replaced with those in the resource pack attached to this ticket. Mojang has my full permission (and strong encouragement) to use these models in the vanilla game to replace what is used currently.
relates to
Close relative of
MC-262427,MC-262433, MC-262452andMC-262461.The bug
The models that item frames use (normal and containing maps) define far more faces than are actually necessary. They both define 22 texture planes, whereas the exact same visual result can be achieved with 18 planes for the normal item frame and 14 planes for the map item frame. The only noticeable difference is how the item frame looks when the player clips inside, which is not a concern at all.
The end result is an item frame model whose file size is smaller, as well as an increase in performance if many item frames are present, which should make map walls and storage rooms less laggy, among other things.
How to reproduce
If you have a map room, storage area, or some other situation where a lot of item frames exist and you get noticeable FPS drops, try the attached resource pack and see if the situation improves.
How to fix
This is a very easy fix - all that needs done is for the template_item_frame.json and template_item_frame_map.json model files in vanilla to be replaced with those in the resource pack attached to this ticket. Mojang has my full permission (and strong encouragement) to use these models in the vanilla game to replace what is used currently.
Close relative of
MC-260296, MC-262427,MC-262433, MC-262452, MC-262461 and MC-262470. Also relates toMC-252693.The bug
The models that item frames use (normal and containing maps) define far more faces than are actually necessary. They both define 22 texture planes, whereas the exact same visual result can be achieved with 18 planes for the normal item frame and 14 planes for the map item frame. The only noticeable difference is how the item frame looks when the player clips inside, which is not a concern at all.
The end result is an item frame model whose file size is smaller, as well as an increase in performance if many item frames are present, which should make map walls and storage rooms less laggy, among other things.
How to reproduce
If you have a map room, storage area, or some other situation where a lot of item frames exist and you get noticeable FPS drops, try the attached resource pack and see if the situation improves.
How to fix
This is a very easy fix - all that needs done is for the template_item_frame.json and template_item_frame_map.json model files in vanilla to be replaced with those in the resource pack attached to this ticket. Mojang has my full permission (and strong encouragement) to use these models in the vanilla game to replace what is used currently.
Close relative of
MC-260296, MC-262427,MC-262433, MC-262452, MC-262461andMC-262470. Also relates toMC-252693.The bug
The models that item frames use (normal and containing maps) define far more faces than are actually necessary. They both define 22 texture planes, whereas the exact same visual result can be achieved with 18 planes for the normal item frame and 14 planes for the map item frame. The only noticeable difference is how the item frame looks when the player clips inside, which is not a concern at all.
The end result is an item frame model whose file size is smaller, as well as an increase in performance if many item frames are present, which should make map walls and storage rooms less laggy, among other things.
How to reproduce
If you have a map room, storage area, or some other situation where a lot of item frames exist and you get noticeable FPS drops, try the attached resource pack and see if the situation improves.
How to fix
This is a very easy fix - all that needs done is for the template_item_frame.json and template_item_frame_map.json model files in vanilla to be replaced with those in the resource pack attached to this ticket. Mojang has my full permission (and strong encouragement) to use these models in the vanilla game to replace what is used currently.
Close relative of
MC-260296, MC-262427,MC-262433, MC-262452, MC-262461, MC-262470,MC-262652and MC-262689. Also relates toMC-252693.The bug
The models that item frames use (normal and containing maps) define far more faces than are actually necessary. They both define 22 texture planes, whereas the exact same visual result can be achieved with 18 planes for the normal item frame and 14 planes for the map item frame. The only noticeable difference is how the item frame looks when the player clips inside, which is not a concern at all.
The end result is an item frame model whose file size is smaller, as well as an increase in performance if many item frames are present, which should make map walls and storage rooms less laggy, among other things.
How to reproduce
If you have a map room, storage area, or some other situation where a lot of item frames exist and you get noticeable FPS drops, try the attached resource pack and see if the situation improves.
How to fix
This is a very easy fix - all that needs done is for the template_item_frame.json and template_item_frame_map.json model files in vanilla to be replaced with those in the resource pack attached to this ticket. Mojang has my full permission (and strong encouragement) to use these models in the vanilla game to replace what is used currently.
relates to
relates to
relates to
relates to
relates to
Close relative of
MC-260296, MC-262427,MC-262433, MC-262452, MC-262461, MC-262470,MC-262652and MC-262689. Also relates toMC-252693.The bug
The models that item frames use (normal and containing maps) define far more faces than are actually necessary. They both define 22 texture planes, whereas the exact same visual result can be achieved with 18 planes for the normal item frame and 14 planes for the map item frame. The only noticeable difference is how the item frame looks when the player clips inside, which is not a concern at all.
The end result is an item frame model whose file size is smaller, as well as an increase in performance if many item frames are present, which should make map walls and storage rooms less laggy, among other things.
How to reproduce
If you have a map room, storage area, or some other situation where a lot of item frames exist and you get noticeable FPS drops, try the attached resource pack and see if the situation improves.
How to fix
This is a very easy fix - all that needs done is for the template_item_frame.json and template_item_frame_map.json model files in vanilla to be replaced with those in the resource pack attached to this ticket. Mojang has my full permission (and strong encouragement) to use these models in the vanilla game to replace what is used currently.
Close relative of
MC-260296, MC-262427, MC-262452, MC-262461,MC-262470,MC-262652andMC-262689. Also relates toMC-252693.The bug
The models that item frames use (normal and containing maps) define far more faces than are actually necessary. They both define 22 texture planes, whereas the exact same visual result can be achieved with 18 planes for the normal item frame and 14 planes for the map item frame. The only noticeable difference is how the item frame looks when the player clips inside, which is not a concern at all.
The end result is an item frame model whose file size is smaller, as well as an increase in performance if many item frames are present, which should make map walls and storage rooms less laggy, among other things.
How to reproduce
If you have a map room, storage area, or some other situation where a lot of item frames exist and you get noticeable FPS drops, try the attached resource pack and see if the situation improves.
How to fix
This is a very easy fix - all that needs done is for the template_item_frame.json and template_item_frame_map.json model files in vanilla to be replaced with those in the resource pack attached to this ticket. Mojang has my full permission (and strong encouragement) to use these models in the vanilla game to replace what is used currently.
Close relative of
MC-260296, MC-262452, MC-262461, MC-262470 andMC-262652. Also relates toMC-252693.The bug
The models that item frames use (normal and containing maps) define far more faces than are actually necessary. They both define 22 texture planes, whereas the exact same visual result can be achieved with 18 planes for the normal item frame and 14 planes for the map item frame. The only noticeable difference is how the item frame looks when the player clips inside, which is not a concern at all.
The end result is an item frame model whose file size is smaller, as well as an increase in performance if many item frames are present, which should make map walls and storage rooms less laggy, among other things.
How to reproduce
If you have a map room, storage area, or some other situation where a lot of item frames exist and you get noticeable FPS drops, try the attached resource pack and see if the situation improves.
How to fix
This is a very easy fix - all that needs done is for the template_item_frame.json and template_item_frame_map.json model files in vanilla to be replaced with those in the resource pack attached to this ticket. Mojang has my full permission (and strong encouragement) to use these models in the vanilla game to replace what is used currently.
relates to
Close relative of
MC-260296, MC-262452, MC-262461, MC-262470 andMC-262652. Also relates toMC-252693.The bug
The models that item frames use (normal and containing maps) define far more faces than are actually necessary. They both define 22 texture planes, whereas the exact same visual result can be achieved with 18 planes for the normal item frame and 14 planes for the map item frame. The only noticeable difference is how the item frame looks when the player clips inside, which is not a concern at all.
The end result is an item frame model whose file size is smaller, as well as an increase in performance if many item frames are present, which should make map walls and storage rooms less laggy, among other things.
How to reproduce
If you have a map room, storage area, or some other situation where a lot of item frames exist and you get noticeable FPS drops, try the attached resource pack and see if the situation improves.
How to fix
This is a very easy fix - all that needs done is for the template_item_frame.json and template_item_frame_map.json model files in vanilla to be replaced with those in the resource pack attached to this ticket. Mojang has my full permission (and strong encouragement) to use these models in the vanilla game to replace what is used currently.
testing discovered
relates to
Relates to: MC-260296 MC-262427 MC-262452 MC-262461 MC-262470 MC-262527 MC-262641 MC-262652 MC-262689 MC-262953 MC-267127 MC-267315 MC-267864 MC-279350
The bug
The current multipart system for walls can use more quads than are necessary to achieve an identical visual result. Making Minecraft render more quads increases render lag, so decreasing the amount needed will improve performance.
The case in question is much the same as MC-267281, arising where two opposite connections of a wall are either both "low" or both "tall". Minecraft, by default, will render one model in each direction, with a total of two. However, the exact same visual outcome can be achieved using a single, continuous model, reducing the amount of quads used for this case from 10 to 6. Since there are no texture mapping issues on walls (unlike MC-109478 and MC-225819/MC-267871), this fix also completely preserves their appearance, so we get no bonus fixes.
How to reproduce
- Create this superflat world:
minecraft:barrier;minecraft:the_void
- Initiate flying mode
/fill -30 -63 -30 30 -56 30 cobblestone_wall
/fill -30 -55 -30 30 -48 30 cobblestone_wall
/tp @s 0 0 0 0 90
- Compare framerates with and without the attached resource pack using F3+2
Expected results
Vanilla's framerates would be ideal.
Actual results
The resource pack gives better results.
How to fix
Adopt the system demonstrated by this resource pack for walls. I give Mojang full permission to use this resource pack to fix this optimization problem.
Relates to: MC-260296 MC-262427 MC-262452 MC-262461 MC-262470 MC-262527 MC-262641 MC-262652 MC-262689 MC-262953 MC-267127 MC-267281 MC-267315 MC-267864 MC-279350 MC-279354
The bug
Bamboo fences, like other fence types (see MC-267281), are not modelled in a way which is optimal for rendering performances. As a result, areas which use large amounts of bamboo fences will decrease framerate much more than otherwise should be the case.
Bamboo fences use a fundamentally different system for modelling compared to other fences, which is why I'm reporting this separately from the other fences. Tragically the issues with the normal fence model have carried over to the system used for bamboo fences.
The model system bamboo fences use is also more complicated than is neccessary - it uses four models for orthogonal connections, whereas this optimized system achieves a visually identical outcome using just three.
Note that since bamboo models use a unique texture rather than just copying the bamboo planks texture, the texture mapping will need to be shifted around. A modified version is found within the attached resource pack - the visual outcome will be identical, but existing resource packs will need to be changed by their authors to fit around it (assuming they don't take the lazy route and just copy over the old, terrible models).
How to reproduce
- Create a creative Superflat world with the following preset:
minecraft:barrier;minecraft:the_void
- Enter flying mode by double pressing the jump button
- Run the command
/tp @s 0 -20 0 0 90
- Run the command
/fill -30 -63 -30 30 -56 30 bamboo_fence
- Open the performance graphs via F3+2
- Switch between the default resources and the attached resource pack, comparing the performance
Expected results
Good framerates in vanilla.
Actual results
We can do far better.
How to fix
Simply implement the resources in the attached resource pack into vanilla. I give Mojang my full permission and encouragement to use these files to make vanilla Minecraft run better.
Further notes
Mipmapping will be affected, however this is a non-issue.
The bamboo fence item model is also updated to fit the new system.
Many of the old model files can be safely deleted once the new ones are added, as this improved system renders them completely superseded.
Also affect the glow item frame?
As both item frames and glow item frames reference the same template model, that is correct.
Can confirm in 24w21b, the resource pack does seem to optimize the fps when around item frames.