Realms world upload uses HTTP instead of HTTPS
The bug
When uploading a Realms world HTTP instead of HTTPS (i.e. unencrypted) is used:
com.mojang.realmsclient.client.FileUpload.requestUpload(int) (Mojang name)
Code Analysis
private UploadResult requestUpload(int i) { UploadResult.Builder uploadRequestBuilder = new UploadResult.Builder(); if (this.cancelled.get()) { return uploadRequestBuilder.build(); } else { this.uploadStatus.totalBytes = this.file.length(); HttpPost httpPost = new HttpPost(this.uploadInfo.getUploadEndpoint().resolve("/upload/" + this.realmId + "/" + this.slotId)); CloseableHttpClient closeableHttpClient = HttpClientBuilder.create().setDefaultRequestConfig(this.requestConfig).build(); try { this.setupRequest(httpPost); CloseableHttpResponse closeableHttpResponse = closeableHttpClient.execute(httpPost); long var6 = this.getRetryDelaySeconds(closeableHttpResponse); if (this.shouldRetry(var6, i)) { UploadResult uploadResult = this.retryUploadAfter(var6, i); return uploadResult; } this.handleResponse(closeableHttpResponse, uploadRequestBuilder); } catch (Exception exception) { if (!this.cancelled.get()) { LOGGER.error("Caught exception while uploading: ", exception); } } finally { this.cleanup(httpPost, closeableHttpClient); } return uploadRequestBuilder.build(); }
Created Issue:
Realms world upload uses HTTP instead of HTTPS
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
![[Mod] violine1101](../../../data/avatars/users/92858.png){kind=small}
Added Category: Networking
Removed Category: (Unassigned)
![[Mojang] Adrian Östergård](../../../data/assets/gravatar/nighter.jpeg){kind=small}
Added Mojang Priority: 
Normal
NormalAdded Triaged Time:
![[Mod] SPGoding](../../../data/avatars/users/44622.png){kind=small}
Added Linked Issues:
relates to
WEB-3206Removed Linked Issues:
relates to
![[Mojang] slicedlime](../../../data/assets/gravatar/slicedlime.jpeg){kind=small}
![[Mod] ampolive](../../../data/avatars/users/18949.svg){kind=small}
Added Affects Versions: 1.21
![[Mod] Jiingy](../../../data/avatars/users/91802.png){kind=small}
Changed Description:
The bug
When uploading a Realms world HTTP instead of HTTPS (i.e. unencrypted) is used:
com.mojang.realmsclient.client.FileUpload.requestUpload(int) (Mojang name)Code Analysis
private UploadResult requestUpload(int i) { UploadResult.Builder uploadRequestBuilder = new UploadResult.Builder(); if (this.cancelled.get()) { return uploadRequestBuilder.build(); } else { this.uploadStatus.totalBytes = this.file.length(); HttpPost httpPost = new HttpPost(this.uploadInfo.getUploadEndpoint().resolve("/upload/" + this.realmId + "/" + this.slotId)); CloseableHttpClient closeableHttpClient = HttpClientBuilder.create().setDefaultRequestConfig(this.requestConfig).build(); try { this.setupRequest(httpPost); CloseableHttpResponse closeableHttpResponse = closeableHttpClient.execute(httpPost); long var6 = this.getRetryDelaySeconds(closeableHttpResponse); if (this.shouldRetry(var6, i)) { UploadResult uploadResult = this.retryUploadAfter(var6, i); return uploadResult; } this.handleResponse(closeableHttpResponse, uploadRequestBuilder); } catch (Exception exception) { if (!this.cancelled.get()) { LOGGER.error("Caught exception while uploading: ", exception); } } finally { this.cleanup(httpPost, closeableHttpClient); } return uploadRequestBuilder.build(); }
![[Mojang] Maxime Lebrot](../../../data/avatars/users/18941.svg){kind=small}
Moved Issue: 
MC-169038 → 
REALMS-12172
MC-169038 → REALMS-12172Removed Category: Networking
Removed Mojang Priority: Normal
NormalAdded Realms Platform: Java
Added Affects Versions: 1.21.1 (Java)
Is this still the case in the latest version?