MC-114779Stairs render faces that cannot be seen normally
Hi,
The bottom face of the top element of the stairs are render be never viewed, so it could be removed from the model I think.
It can be view in spectator mode.
Regards,
diff --git a/minecraft/models/block/inner_stairs.json b/minecraft/models/block/inner_stairs.json
index 51c02e2..236589a 100644
--- a/minecraft/models/block/inner_stairs.json
+++ b/minecraft/models/block/inner_stairs.json
@@ -17,7 +17,6 @@
{ "from": [ 8, 8, 0 ],
"to": [ 16, 16, 16 ],
"faces": {
- "down": { "uv": [ 8, 0, 16, 16 ], "texture": "#bottom", "cullface": "down" },
"up": { "uv": [ 8, 0, 16, 16 ], "texture": "#top", "cullface": "up" },
"north": { "uv": [ 0, 0, 8, 8 ], "texture": "#side", "cullface": "north" },
"south": { "uv": [ 8, 0, 16, 8 ], "texture": "#side", "cullface": "south" },
@@ -28,7 +27,6 @@
{ "from": [ 0, 8, 8 ],
"to": [ 8, 16, 16 ],
"faces": {
- "down": { "uv": [ 0, 0, 8, 8 ], "texture": "#bottom", "cullface": "down" },
"up": { "uv": [ 0, 8, 8, 16 ], "texture": "#top", "cullface": "up" },
"north": { "uv": [ 8, 0, 16, 8 ], "texture": "#side" },
"south": { "uv": [ 0, 0, 8, 8 ], "texture": "#side", "cullface": "south" },
diff --git a/minecraft/models/block/outer_stairs.json b/minecraft/models/block/outer_stairs.json
index 26fb37f..03bbe42 100644
--- a/minecraft/models/block/outer_stairs.json
+++ b/minecraft/models/block/outer_stairs.json
@@ -17,7 +17,6 @@
{ "from": [ 8, 8, 8 ],
"to": [ 16, 16, 16 ],
"faces": {
- "down": { "uv": [ 8, 0, 16, 8 ], "texture": "#bottom", "cullface": "down" },
"up": { "uv": [ 8, 8, 16, 16 ], "texture": "#top", "cullface": "up" },
"north": { "uv": [ 0, 0, 8, 8 ], "texture": "#side" },
"south": { "uv": [ 8, 0, 16, 8 ], "texture": "#side", "cullface": "south" },
diff --git a/minecraft/models/block/stairs.json b/minecraft/models/block/stairs.json
index e803812..986ce9c 100644
--- a/minecraft/models/block/stairs.json
+++ b/minecraft/models/block/stairs.json
@@ -34,7 +34,6 @@
{ "from": [ 8, 8, 0 ],
"to": [ 16, 16, 16 ],
"faces": {
- "down": { "uv": [ 8, 0, 16, 16 ], "texture": "#bottom", "cullface": "down" },
"up": { "uv": [ 8, 0, 16, 16 ], "texture": "#top", "cullface": "up" },
"north": { "uv": [ 0, 0, 8, 8 ], "texture": "#side", "cullface": "north" },
"south": { "uv": [ 8, 0, 16, 8 ], "texture": "#side", "cullface": "south" },
Linked Issues
Low
Created Issue:
[Optimize] Do not render useless faces for stairs
Hi,
The bottom face of the top element of the stairs are render be never viewed, so it could be removed from the model I think.
It can be view in spectator mode.
Regards,
diff --git a/minecraft/models/block/inner_stairs.json b/minecraft/models/block/inner_stairs.json index 51c02e2..236589a 100644 --- a/minecraft/models/block/inner_stairs.json +++ b/minecraft/models/block/inner_stairs.json @@ -17,7 +17,6 @@ { "from": [ 8, 8, 0 ], "to": [ 16, 16, 16 ], "faces": { - "down": { "uv": [ 8, 0, 16, 16 ], "texture": "#bottom", "cullface": "down" }, "up": { "uv": [ 8, 0, 16, 16 ], "texture": "#top", "cullface": "up" }, "north": { "uv": [ 0, 0, 8, 8 ], "texture": "#side", "cullface": "north" }, "south": { "uv": [ 8, 0, 16, 8 ], "texture": "#side", "cullface": "south" }, @@ -28,7 +27,6 @@ { "from": [ 0, 8, 8 ], "to": [ 8, 16, 16 ], "faces": { - "down": { "uv": [ 0, 0, 8, 8 ], "texture": "#bottom", "cullface": "down" }, "up": { "uv": [ 0, 8, 8, 16 ], "texture": "#top", "cullface": "up" }, "north": { "uv": [ 8, 0, 16, 8 ], "texture": "#side" }, "south": { "uv": [ 0, 0, 8, 8 ], "texture": "#side", "cullface": "south" }, diff --git a/minecraft/models/block/outer_stairs.json b/minecraft/models/block/outer_stairs.json index 26fb37f..03bbe42 100644 --- a/minecraft/models/block/outer_stairs.json +++ b/minecraft/models/block/outer_stairs.json @@ -17,7 +17,6 @@ { "from": [ 8, 8, 8 ], "to": [ 16, 16, 16 ], "faces": { - "down": { "uv": [ 8, 0, 16, 8 ], "texture": "#bottom", "cullface": "down" }, "up": { "uv": [ 8, 8, 16, 16 ], "texture": "#top", "cullface": "up" }, "north": { "uv": [ 0, 0, 8, 8 ], "texture": "#side" }, "south": { "uv": [ 8, 0, 16, 8 ], "texture": "#side", "cullface": "south" }, diff --git a/minecraft/models/block/stairs.json b/minecraft/models/block/stairs.json index e803812..986ce9c 100644 --- a/minecraft/models/block/stairs.json +++ b/minecraft/models/block/stairs.json @@ -34,7 +34,6 @@ { "from": [ 8, 8, 0 ], "to": [ 16, 16, 16 ], "faces": { - "down": { "uv": [ 8, 0, 16, 16 ], "texture": "#bottom", "cullface": "down" }, "up": { "uv": [ 8, 0, 16, 16 ], "texture": "#top", "cullface": "up" }, "north": { "uv": [ 0, 0, 8, 8 ], "texture": "#side", "cullface": "north" }, "south": { "uv": [ 8, 0, 16, 8 ], "texture": "#side", "cullface": "south" },
Attachments2
![[Mod] Neko](../../../data/avatars/users/92901.png){kind=small}
Added Attachments:
![[Mod] bemoty](../../../data/avatars/users/50554.png){kind=small}
Added Affects Versions: 1.12.1
Changed Summary:
[Optimize] Do not render useless faces for stairsStairs render faces that cannot be seen normally
Added Affects Versions: 1.13-pre10
![[Mod] tryashtar](../../../data/avatars/users/41963.png){kind=small}
![[Mod] Sonicwave](../../../data/avatars/users/94627.png){kind=small}
Added Affects Versions: 18w50a
![[Mod] Asteraoth](../../../data/avatars/users/92886.png){kind=small}
Added Affects Versions: 19w02a
Added Affects Versions: 19w03a
Added Affects Versions: 19w03b
![[Mod] violine1101](../../../data/avatars/users/92858.png){kind=small}
Added Linked Issues:
relates to
Added Labels: unneccessary-planes
Added Labels: unnecessary-planes
Removed Labels: unneccessary-planes
Or just remove the texture assigning, like in MC-114779, else you'll limit resource packs.
This is the same issue as MC-114779.
The bug
The uppermost cuboid of stairs has a bottom face which can never be seen under normal circumstances. Rendering it is pointless.
This face was removed from Java Edition in 2019 (see MC-114779).
How to reproduce
- Place a stairs block
- Enter Spectator mode
- Fly inside the stair block
Expected results
The bottom plane of the upper cuboid of the stairs would not exist.
Actual results
It does.
How to fix
Remove this face, since it isn't needed.
It's actually possible to remove two faces and still get a visually identical result - this solution is discussed in MC-262460 and is preferable.
There is another redered useless face
--- a/minecraft/models/block/inner_stairs.json +++ b/minecraft/models/block/inner_stairs.json @@ -30,8 +30,7 @@ "up": { "uv": [ 0, 8, 8, 16 ], "texture": "#top", "cullface": "up" }, "north": { "uv": [ 8, 0, 16, 8 ], "texture": "#side" }, "south": { "uv": [ 0, 0, 8, 8 ], "texture": "#side", "cullface": "south" }, - "west": { "uv": [ 8, 0, 16, 8 ], "texture": "#side", "cullface": "west" }, - "east": { "uv": [ 0, 0, 8, 8 ], "texture": "#side", "cullface": "east" } + "west": { "uv": [ 8, 0, 16, 8 ], "texture": "#side", "cullface": "west" } } } ]Confirmed for 1.12.1
Cannot reproduce in 18w47b, most likely fixed
actually, can reproduce in 18w48a
Affects 18w49a
Affects 18w50a
Changed the reporter to [~Awesoman3000].
Connor Steppie should work for Mojang
These were both fixed in 19w03c
Makes sense, given the recent cullface fixing.