MC-227202Slow world loading after 1.17-pre3
After upgrading one of my dedicated servers to 1.17-pre3 the world took significantly longer to load on server start up. The preparing spawn area phase counted all the way up to one hundred and threw an exception which was not the behavior on 1.17-pre2 and below. Before the console would output zero percent a few times and jump to something like 7 percent before stating that the world was done loading and displayed the time it took. In 1.17-pre2 the server took 2.644 seconds to load and in pre3 and pre4 it took 8.98 seconds and threw the following exception between 1% and 2% of the preparing spawn phase.
[Server thread/ERROR]: No key size in MapLike[{extra_size:2,min_size:1,type:"minecraft:column_placer"}]
[Server thread/ERROR]: Exception loading structure piece with id minecraft:jigsaw
java.lang.IllegalStateException: Invalid pool element found
at dbf.k(SourceFile:54) ~[server.jar:?]
at java.util.Optional.orElseThrow(Optional.java:403) ~[?:?]
at dbf.<init>(SourceFile:54) ~[server.jar:?]
at cuc.a(SourceFile:151) ~[server.jar:?]
at cni.a(SourceFile:415) ~[server.jar:?]
at cni.a(SourceFile:175) ~[server.jar:?]
at abe.l(SourceFile:511) ~[server.jar:?]
at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1764) ~[?:?]
at aqu.c(SourceFile:151) ~[server.jar:?]
at abp$a.c(SourceFile:527) ~[server.jar:?]
at aqu.z(SourceFile:125) ~[server.jar:?]
at abp$a.z(SourceFile:536) ~[server.jar:?]
at abp.d(SourceFile:279) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.bg(SourceFile:771) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.z(SourceFile:759) ~[server.jar:?]
at aqu.c(SourceFile:134) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.y(SourceFile:744) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.b(SourceFile:525) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.e_(SourceFile:357) ~[server.jar:?]
at aas.e(SourceFile:183) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.x(SourceFile:665) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.a(SourceFile:274) ~[server.jar:?]
at java.lang.Thread.run(Thread.java:831) [?:?]
[Server thread/ERROR]: No key size in MapLike[{extra_size:2,min_size:1,type:"minecraft:column_placer"}]
[Server thread/ERROR]: Exception loading structure piece with id minecraft:jigsaw
java.lang.IllegalStateException: Invalid pool element found
at dbf.k(SourceFile:54) ~[server.jar:?]
at java.util.Optional.orElseThrow(Optional.java:403) ~[?:?]
at dbf.<init>(SourceFile:54) ~[server.jar:?]
at cuc.a(SourceFile:151) ~[server.jar:?]
at cni.a(SourceFile:415) ~[server.jar:?]
at cni.a(SourceFile:175) ~[server.jar:?]
at abe.l(SourceFile:511) ~[server.jar:?]
at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1764) ~[?:?]
at aqu.c(SourceFile:151) ~[server.jar:?]
at abp$a.c(SourceFile:527) ~[server.jar:?]
at aqu.z(SourceFile:125) ~[server.jar:?]
at abp$a.z(SourceFile:536) ~[server.jar:?]
at abp.d(SourceFile:279) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.bg(SourceFile:771) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.z(SourceFile:759) ~[server.jar:?]
at aqu.c(SourceFile:134) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.y(SourceFile:744) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.b(SourceFile:525) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.e_(SourceFile:357) ~[server.jar:?]
at aas.e(SourceFile:183) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.x(SourceFile:665) ~[server.jar:?]
at net.minecraft.server.MinecraftServer.a(SourceFile:274) ~[server.jar:?]
at java.lang.Thread.run(Thread.java:831) [?:?]
- Unresolved
EcoBuilder13- 46
- 22
- Confirmed
Normal- Platform
- Datafixer Performance
1.17-pre4 - 1.19.2
1.17-pre4 1.17-pre5 1.17-rc1 1.17-rc2 1.17 1.17.1-pre1 1.17.1-pre2 1.17.1-pre3 1.17.1-rc1 1.17.1-rc2 1.17.1 21w39a 21w40a 21w41a 21w42a 21w43a 21w44a 1.18-pre1 1.18-pre2 1.18-pre3 1.18-pre4 1.18-pre5 1.18-pre6 1.18-pre7 1.18-pre8 1.18-rc1 1.18-rc3 1.18-rc4 1.18 1.18.1-pre1 1.18.1-rc1 1.18.1-rc2 1.18.1 22w03a 22w05a 22w06a 1.18.2 22w11a 22w12a 22w13a 22w14a 22w16b 22w17a 22w18a 22w19a 1.19-pre1 1.19-pre2 1.19-pre3 1.19-pre4 1.19-rc2 1.19 22w24a 1.19.1-pre1 1.19.1-rc1 1.19.1-pre4 1.19.1 1.19.2
Created Issue:
Slow world loading after 1.17-pre3
After upgrading one of my dedicated servers to 1.17-pre3 the world took significantly longer to load on server start up. The preparing spawn area phase counted all the way up to one hundred and threw an exception which was not the behavior on 1.17-pre2 and below. Before the console would output zero percent a few times and jump to something like 7 percent before stating that the world was done loading and displayed the time it took. In 1.17-pre2 the server took 2.644 seconds to load and in pre3 and pre4 it took 8.98 seconds and threw the following exception between 1% and 2% of the preparing spawn phase.
[Server thread/ERROR]: No key size in MapLike[{extra_size:2,min_size:1,type:"minecraft:column_placer"}] [Server thread/ERROR]: Exception loading structure piece with id minecraft:jigsaw java.lang.IllegalStateException: Invalid pool element found at dbf.k(SourceFile:54) ~[server.jar:?] at java.util.Optional.orElseThrow(Optional.java:403) ~[?:?] at dbf.<init>(SourceFile:54) ~[server.jar:?] at cuc.a(SourceFile:151) ~[server.jar:?] at cni.a(SourceFile:415) ~[server.jar:?] at cni.a(SourceFile:175) ~[server.jar:?] at abe.l(SourceFile:511) ~[server.jar:?] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1764) ~[?:?] at aqu.c(SourceFile:151) ~[server.jar:?] at abp$a.c(SourceFile:527) ~[server.jar:?] at aqu.z(SourceFile:125) ~[server.jar:?] at abp$a.z(SourceFile:536) ~[server.jar:?] at abp.d(SourceFile:279) ~[server.jar:?] at net.minecraft.server.MinecraftServer.bg(SourceFile:771) ~[server.jar:?] at net.minecraft.server.MinecraftServer.z(SourceFile:759) ~[server.jar:?] at aqu.c(SourceFile:134) ~[server.jar:?] at net.minecraft.server.MinecraftServer.y(SourceFile:744) ~[server.jar:?] at net.minecraft.server.MinecraftServer.b(SourceFile:525) ~[server.jar:?] at net.minecraft.server.MinecraftServer.e_(SourceFile:357) ~[server.jar:?] at aas.e(SourceFile:183) ~[server.jar:?] at net.minecraft.server.MinecraftServer.x(SourceFile:665) ~[server.jar:?] at net.minecraft.server.MinecraftServer.a(SourceFile:274) ~[server.jar:?] at java.lang.Thread.run(Thread.java:831) [?:?] [Server thread/ERROR]: No key size in MapLike[{extra_size:2,min_size:1,type:"minecraft:column_placer"}] [Server thread/ERROR]: Exception loading structure piece with id minecraft:jigsaw java.lang.IllegalStateException: Invalid pool element found at dbf.k(SourceFile:54) ~[server.jar:?] at java.util.Optional.orElseThrow(Optional.java:403) ~[?:?] at dbf.<init>(SourceFile:54) ~[server.jar:?] at cuc.a(SourceFile:151) ~[server.jar:?] at cni.a(SourceFile:415) ~[server.jar:?] at cni.a(SourceFile:175) ~[server.jar:?] at abe.l(SourceFile:511) ~[server.jar:?] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1764) ~[?:?] at aqu.c(SourceFile:151) ~[server.jar:?] at abp$a.c(SourceFile:527) ~[server.jar:?] at aqu.z(SourceFile:125) ~[server.jar:?] at abp$a.z(SourceFile:536) ~[server.jar:?] at abp.d(SourceFile:279) ~[server.jar:?] at net.minecraft.server.MinecraftServer.bg(SourceFile:771) ~[server.jar:?] at net.minecraft.server.MinecraftServer.z(SourceFile:759) ~[server.jar:?] at aqu.c(SourceFile:134) ~[server.jar:?] at net.minecraft.server.MinecraftServer.y(SourceFile:744) ~[server.jar:?] at net.minecraft.server.MinecraftServer.b(SourceFile:525) ~[server.jar:?] at net.minecraft.server.MinecraftServer.e_(SourceFile:357) ~[server.jar:?] at aas.e(SourceFile:183) ~[server.jar:?] at net.minecraft.server.MinecraftServer.x(SourceFile:665) ~[server.jar:?] at net.minecraft.server.MinecraftServer.a(SourceFile:274) ~[server.jar:?] at java.lang.Thread.run(Thread.java:831) [?:?]
![[Mod] violine1101](../../../data/avatars/users/92858.png){kind=small}
Added Affects Versions: 1.17-pre5
![[Mojang] Adrian Östergård](../../../data/assets/gravatar/nighter.jpeg){kind=small}
Important![[Mojang] slicedlime](../../../data/assets/gravatar/slicedlime.jpeg){kind=small}
Added Affects Versions: 1.17-rc1
Added Affects Versions: 1.17-rc2
![[Helper] Johnibur](../../../data/avatars/users/28381.png){kind=small}
Added Affects Versions: 1.17
Added Affects Versions: 1.17.1-pre1
Added Affects Versions: 1.17.1-pre2
Added Affects Versions: 1.17.1-pre3
Added Affects Versions: 1.17.1-rc1
Added Affects Versions: 1.17.1-rc2
Added Affects Versions: 1.17.1
Added Affects Versions: 21w39a
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
Added Affects Versions: 21w40a
Added Affects Versions: 21w41a
Added Affects Versions: 21w42a
![[Helper] gaspoweredpick](../../../data/avatars/users/80904.png){kind=small}
Added Affects Versions: 21w43a
Added Affects Versions: 21w44a
Added Affects Versions: 1.18-pre1
Added Affects Versions: 1.18-pre2
Added Affects Versions: 1.18-pre3
Added Affects Versions: 1.18-pre4
Added Affects Versions: 1.18-pre5
Added Affects Versions: 1.18-pre6
Added Affects Versions: 1.18-pre7
![[Mod] ampolive](../../../data/avatars/users/18949.svg){kind=small}
Added Affects Versions: 1.18-pre8
Added Affects Versions: 1.18-rc1
Added Affects Versions: 1.18-rc3
Added Affects Versions: 1.18-rc4
Added Affects Versions: 1.18
Added Affects Versions: 1.18.1-pre1
Added Affects Versions: 1.18.1-rc1
Added Affects Versions: 1.18.1-rc2
Added Affects Versions: 1.18.1
Added Affects Versions: 22w03a
Added Affects Versions: 22w05a
Added Affects Versions: 22w06a
Added Affects Versions: 1.18.2
Added Affects Versions: 22w11a
Added Affects Versions: 22w12a
Added Linked Issues:
relates to
Added Affects Versions: 22w13a
Added Affects Versions: 22w14a
Added Affects Versions: 22w16b
Added Affects Versions: 22w17a
Added Affects Versions: 22w18a
Added Affects Versions: 22w19a
Added Affects Versions: 1.19-pre1
Added Affects Versions: 1.19-pre2
Added Affects Versions: 1.19-pre3
Added Affects Versions: 1.19-pre4
Added Affects Versions: 1.19-rc2
Added Affects Versions: 1.19
Added Affects Versions: 22w24a
Added Affects Versions: 1.19.1-pre1
Added Affects Versions: 1.19.1-rc1
Added Affects Versions: 1.19.1-pre4
Added Affects Versions: 1.19.1
Added Affects Versions: 1.19.2
The bug
While reproducing MC-227202 and MC-227945, a frequent error is logged:
Exception loading structure piece with id minecraft:jigsaw java.lang.IllegalStateException: Invalid call to EmtyPoolElement.getBoundingBox, filter me!
This is a typo, the word is missing a "p". It is supposed to be EmptyPoolElement.
Analysis
There's a typo in the exception message.
net.minecraft.world.level.levelgen.feature.structures.EmptyPoolElement.java (Mojang mappings, 1.18-pre1)
...
@Override
public BoundingBox getBoundingBox(...) {
throw new IllegalStateException("Invalid call to EmtyPoolElement.getBoundingBox, filter me!");
}
...
Just to confirm, the same thing still happens in 1.17-pre4?
Yes it still occurs in pre4 and pre5, but the issue is no longer present if I downgrade the server to pre2 or below.
Do you have any world generation datapacks enabled?
No, I have left the world to generate with what the default generation for the snapshots. I also skipped updating to the snapshots with the noise caves and world height changes so I haven’t touched anything with the world nbt or used the 1.18 terrain on this server.
was testing 1.18 gen datapacks also lagging
On single player might I add
Given that this started in pre3, could this be caused by the attempted fix of MC-224893?
The exception thrown in this issue is similar to
MC-227945.I have a world from 1.16 that is throwing identical warnings as well. No issues on 1.16, however on 1.17 it sends this warning, but otherwise appears to run correctly. No apparent lag or other issues.
This happens in my world too, only difference is that it lags as well. The log also spams these error messages:
Exception loading structure piece with id minecraft:jigsaw java.lang.IllegalStateException: Invalid call to EmtyPoolElement.getBoundingBox, filter me! Invalid bounding box data, inverted bounds for: daq{minX=2147483647, minY=2147483647, minZ=2147483647, maxX=-2147483648, maxY=-2147483648, maxZ=-2147483648}I don't know if it is a different issue.
Get flooding with those as well.
It happens in a world that got updated since 1.14.
Having the same issue with a long-time world I started with 1.7. Load time in 1.16.5 was fairly modest but when I updated to 1.17 it shot up probably a good 3x - 4x.
I also see those same errors in the log file. Though even if I load the world in an area where those errors don't show up the load time is still very slow. I'm tempted to try 1.17-pre2 and see if that is faster.
I just made a copy of the effected world file and ran it on a fresh 21w39a vanilla server and the error in the log about column_placer feature is no longer present. Though there was still a major regression in load times even after first launch. The average start time is about ~17 seconds now; however, after using the --forceUpgrade option when starting the server it has returned to an average of ~7 seconds. That is still worse than 1.17-pre2 though a major improvement from the first few runs after updating to 21w39a. Can someone else that has this issue check if the error in the log is gone? If so I will update this ticket to state the log error has been fixed but not the performance regression.
The "No key" error seems to no longer be present, but the errors in this comment persist.
Can confirm in 21w40a.
Can confirm in 21w41a.
Can confirm in 21w42a.
Can confirm in 21w43a, and it has gotten significantly worse with the introduction of the chunk blending algorithm.
World loading time is something like 5x the time it took pre 1.17
(your results may vary....mine have been garbage)
Can confirm in 1.18 Pre-release 1.
Can confirm in 1.18 Pre-release 3.