Loot table creation message for spectators displays twice for entities
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce with MCP (1.11+) (easy)
- Locate net.minecraft.entity.player.EntityPlayerMP.displayGUIChest(IInventory chestInventory).
- Change the true in the following line to false.
this.addChatComponentMessage((new TextComponentTranslation("container.spectatorCantOpen", new Object[0])).setStyle((new Style()).setColor(TextFormatting.RED)), true); - Start Minecraft
- Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"} - Switch to Spectator mode
- Right-click the MinecartChest
How to reproduce (1.11+) (advanced)
Note: The following steps will cause the original version folder to be deteled
- Open the %appdata%\.minecraft\versions directory
- Copy the folder of the latest version and rename the copied folder to "
MC-94682" - Open the copied folder and apply [Mod] Pokechu22's modification (requires Python)
- Rename the .jar file to "
MC-94682" - Open the .json file in the copied folder with a text editor
- Set "
MC-94682" as id - Remove the contents of the downloads key at the end of the the file
- Set "
- Start Minecraft
- Select the version called "
MC-94682" - Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"} - Switch to Spectator mode
- Right-click the MinecartChest
Delete the folder of the version you modified again and rename the copy to the original name
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
Created Issue:
Loot table creation message for spectators displays twice for entities
Relates to:
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce
- Summon for example a MinecartChest
/summon MinecartChest ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch into Spectator mode
- Right-click the MinecartChest
Relates to:
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce
- Summon for example a MinecartChest
/summon MinecartChest ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch into Spectator mode
- Right-click the MinecartChest
relates to
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce
- Summon for example a MinecartChest
/summon MinecartChest ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch
into Spectator mode- Right-click the MinecartChest
is duplicated by
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce
- Summon for example a MinecartChest
/summon MinecartChest ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in creative mode.
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce
- Summon for example a MinecartChest
/summon MinecartChest ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in
creativemode.The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce
- Summon for example a MinecartChest
/summon MinecartChest ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
is duplicated by
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce
- Summon for example a MinecartChest
/summonMinecartChest~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce
- Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
Reporter notePlease leave this report open until MCP is released for 1.11+ and we can confirm that it is fixed for sure. Even though this has no negative impact anymore there is no reason why the message should appear twice.
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce
- Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
Reporter notePlease leave this report open until MCP is released for 1.11+ and we can confirm that it is fixed for sure. Even though this has no negative impact anymore there is no reason why the message should appear twice.
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce
- Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce
- Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce (1.11+) (advanced)
- Open the %appdata%\.minecraft\versions directory
- Copy the folder of the latest version and rename the copied folder
- Open the orginal folder and apply [Mod] Pokechu22's modification (requires Python)
- Open the .json file of this version with a text editor and remove the contents of the download key at the end of the the file
- Start Minecraft
- Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
Delete the folder of the version you modified again and rename the copy to the original name
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce (1.11+) (advanced)
- Open the %appdata%\.minecraft\versions directory
- Copy the folder of the latest version and rename the copied folder
- Open the
orginalfolder and apply [Mod] Pokechu22's modification (requires Python)- Open the .json file of this version with a text editor and remove the contents of the download key at the end of the the file
- Start Minecraft
- Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
Delete the folder of the version you modified again and rename the copy to the original name
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce (1.11+) (advanced)
Note: The following steps will cause the original version folder to be deteled
- Open the %appdata%\.minecraft\versions directory
- Copy the folder of the latest version and rename the copied folder to "
MC-94682"- Open the copied folder and apply [Mod] Pokechu22's modification (requires Python)
- Rename the .jar file to "
MC-94682"- Open the .json file in the copied folder with a text editor
- Set "
MC-94682" as id- Remove the contents of the downloads key at the end of the the file
- Start Minecraft
- Select the version called "
MC-94682"- Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
Delete the folder of the version you modified again and rename the copy to the original name
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce (1.11+) (
advanced)Note: The following steps will cause the original version folder to be deteled
- Open the %appdata%\.minecraft\versions directory
- Copy the folder of the latest version and rename the copied folder to "
MC-94682"- Open the copied folder and apply [Mod] Pokechu22's modification (requires Python)
- Rename the .jar file to "
MC-94682"- Open the .json file in the copied folder with a text editor
- Set "
MC-94682" as id- Remove the contents of the downloads key at the end of the the file
- Start Minecraft
- Select the version called "
MC-94682"- Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
Delete the folder of the version you modified again and rename the copy to the original name
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce with MCP (1.11+) (easy)
- Locate net.minecraft.entity.player.EntityPlayerMP.displayGUIChest(IInventory chestInventory).
- Change the true in the following line to false.
this.addChatComponentMessage((new TextComponentTranslation("container.spectatorCantOpen", new Object[0])).setStyle((new Style()).setColor(TextFormatting.RED)), true);- Start Minecraft
- Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
How to reproduce (1.11+) (advanced)
Note: The following steps will cause the original version folder to be deteled
- Open the %appdata%\.minecraft\versions directory
- Copy the folder of the latest version and rename the copied folder to "
MC-94682"- Open the copied folder and apply [Mod] Pokechu22's modification (requires Python)
- Rename the .jar file to "
MC-94682"- Open the .json file in the copied folder with a text editor
- Set "
MC-94682" as id- Remove the contents of the downloads key at the end of the the file
- Start Minecraft
- Select the version called "
MC-94682"- Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"}- Switch to Spectator mode
- Right-click the MinecartChest
Delete the folder of the version you modified again and rename the copy to the original name
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
Still in 16w21a and 16w21b
Still in 1.10-pre1
The bug
When a player in spectator mode right clicks a container entity (currently only MinecartChest and HopperMinecart) the "Unable to open. Loot not generated yet." message is printed twice.
Note: This message has also one space too much at the end.
How to reproduce with MCP (1.11+) (easy)
- Locate net.minecraft.entity.player.EntityPlayerMP.displayGUIChest(IInventory chestInventory).
- Change the true in the following line to false.
this.addChatComponentMessage((new TextComponentTranslation("container.spectatorCantOpen", new Object[0])).setStyle((new Style()).setColor(TextFormatting.RED)), true); - Start Minecraft
- Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"} - Switch to Spectator mode
- Right-click the MinecartChest
How to reproduce (1.11+) (advanced)
Note: The following steps will cause the original version folder to be deteled
- Open the %appdata%\.minecraft\versions directory
- Copy the folder of the latest version and rename the copied folder to "
MC-94682" - Open the copied folder and apply [Mod] Pokechu22's modification (requires Python)
- Rename the .jar file to "
MC-94682" - Open the .json file in the copied folder with a text editor
- Set "
MC-94682" as id - Remove the contents of the downloads key at the end of the the file
- Set "
- Start Minecraft
- Select the version called "
MC-94682" - Summon for example a MinecartChest
/summon chest_minecart ~ ~ ~ {LootTable:"chests/simple_dungeon"} - Switch to Spectator mode
- Right-click the MinecartChest
Delete the folder of the version you modified again and rename the copy to the original name
The reason
The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.
The reason why this happens is because the method net.minecraft.client.multiplayer.PlayerControllerMP.func_187097_a(EntityPlayer, Entity, ItemStack, EnumHand) returns EnumActionResult.PASS for players in spectator mode. Because of this the player right clicks with his main- and offhand on the entity. This could be solved by having the method net.minecraft.client.Minecraft.rightClickMouse() in general run only for the mainhand if the player is in spectator mode.
Thanks for reporting, but this is a duplicate of MC-94682.
Confirmed for 15w51b.
Confirmed for 1.10-pre2.
Confirmed for 1.10.
Confirmed for 1.10.1.
Can't tell whether this bug is fixed in 16w33a since the message was moved to the action bar.
You don't need MCP to check this. Just manipulate the bytecode using this python script that uses jawa. Should be easy enough to confirm in any version with it.
Thank you very much! How do you prevent the launcher from replacing the modified jar file when starting the game?
Open the JSON and delete the contents of the downloads section.
Is this still a issue in the latest version of the game(currently 1.13.1)?
If so, please add it to the affected versions, thanks!