MC-99680Heart jittering effect doesn't take absorption into account
The bug
The check to see if the player's hearts should shake only takes into account the actual health bar, not any health granted by the absorption status effect.
Steps to Reproduce by [Mod] j_p_smith
- Ensure you are in survival or adventure mode:
/gamemode survival
- Disable natural regeneration:
/gamerule naturalRegeneration false
- Damage yourself by running the following command three times:
/effect give @s instant_damage
→
Your health bar begins to shake - Give yourself the absorption status effect:
/effect give @s absorption
→
Your health bar continues to shake, despite your total health being greater than 4
Code analysis
Code analysis by [Mod] bemoty can be found in this comment.
![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}
Created Issue:
Heart jittering effect doesn't take absorption into account
The check to see if the player's hearts should shake only takes into account the actual health bar, not any health granted by the absorption status effect.
Environment
Operating system: OSX 10.9.5
Java Version: 1.6.0_65
Attachments1
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
Operating system: OSX 10.9.5
Java Version: 1.6.0_65
The bug
The check to see if the player's hearts should shake only takes into account the actual health bar, not any health granted by the absorption status effect.
Code analysis
Code analysis by [Mod] bemoty can be found in this comment .
![[Mod] bemoty](../../../data/avatars/users/50554.png){kind=small}
![[Mod] Asteraoth](../../../data/avatars/users/92886.png){kind=small}
![[Mojang] Nathan Adams](../../../data/assets/gravatar/dinnerbone.png){kind=small}
![[Mod] NeunEinser](../../../data/avatars/users/39263.png){kind=small}
The bug
The check to see if the player's hearts should shake only takes into account the actual health bar, not any health granted by the absorption status effect.
Code analysis
Code analysis by [Mod] bemoty can be found in this comment.
The bug
The check to see if the player's hearts should shake only takes into account the actual health bar, not any health granted by the absorption status effect.
Steps to Reproduce by [~Darth+Cobby]
- Ensure you are in survival or adventure mode:
/gamemode survival- Disable natural regeneration:
/gamerule naturalRegeneration false- Damage yourself by running the following command three times:
/effect give @s instant_damage→
- Give yourself the absorption status effect:
/effect give @s absorption→
Code analysis
Code analysis by [Mod] bemoty can be found in this comment.
![[Mod] LateLag](../../../data/avatars/users/92884.png){kind=small}
The bug
The check to see if the player's hearts should shake only takes into account the actual health bar, not any health granted by the absorption status effect.
Steps to Reproduce by [~Darth+Cobby]
- Ensure you are in survival or adventure mode:
/gamemode survival- Disable natural regeneration:
/gamerule naturalRegeneration false- Damage yourself by running the following command three times:
/effect give @s instant_damage→
- Give yourself the absorption status effect:
/effect give @s absorption→
Code analysis
Code analysis by [Mod] bemoty can be found in this comment.
The bug
The check to see if the player's hearts should shake only takes into account the actual health bar, not any health granted by the absorption status effect.
Steps to Reproduce by [Mod] j_p_smith
- Ensure you are in survival or adventure mode:
/gamemode survival- Disable natural regeneration:
/gamerule naturalRegeneration false- Damage yourself by running the following command three times:
/effect give @s instant_damage→
- Give yourself the absorption status effect:
/effect give @s absorption→
Code analysis
Code analysis by [Mod] bemoty can be found in this comment.
Um comentário com nível de segurança 'staff' foi removido.
Um comentário com nível de segurança 'staff' foi removido.
Um comentário com nível de segurança 'staff' foi removido.
Um comentário com nível de segurança 'staff' foi removido.
![[Bot] Arisa](../../../data/avatars/users/43007.png){kind=small}
The following is based on a decompiled version of Minecraft 1.12 using MCP 9.40pre-1. (Can confirm for 1.12.1)
In the method net.minecraft.client.gui.GuiIngame.renderPlayerStats() there is a small piece of code which modifies the y-position of the player's hearts in the ingame GUI by a random integer between 0 and 2 every tick if the player's health falls below 4 (2 hearts). However, this does not include hearts added by the absorption effect. This issue can be fixed very easily by adding those hearts added by absorption to the if-statement (entityplayer.getAbsorptionAmount()).
imo wai, as absoprion can dissapear at any time. Absorption is like magic shield, when you are still injured.
Confirmed in 1.16.1.
→
Your health bar begins to shake
→
Your health bar continues to shake, despite your total health being greater than 4
Can confirm in 20w51a.
Can confirm in 21w03a.
Can confirm in 21w05b.
Can confirm in 21w06a.
Video attached.
Requesting ownership as the current reporter has been inactive since 2017
Can confirm in 21w07a.
Can confirm in 1.16.5 and 21w08b.
Can confirm in 21w11a.
I can confirm that this was an issue in 21w20a, however, I can no longer reproduce this in 1.17 Pre-release 1, meaning that this issue was fixed in this version.
Is that 1.17 Pre-release 1 or 1.17.1 Pre-release 1? Either way, can confirm that this issue is not present in 1.17.1 Pre-release 2.
I just confirmed the fix version. It is 1.17 pre-1.