Biomes on land and landscape changed in new world generator
We wanted to do changes to the worldgen system to make it simple/clear and possible to datadrive it in the future.
While doing so we noticed at a certain moment that we generated some areas of the terrain differently than before (not meaning the things placed as decoration, but the actual shape of the land). It took a while to figure out why, but it turned out that in the old code, there had been a bug from the beginning. We forgot to reset the seed of a random when we merged rivers and the biomes.
In the new code there was no way to reproduce this wrong behavior and this is why [this issue] has been resolved as Working as Intended.
We're not happy that we ended up changing the world where the intention was not to. We found no way to keep the bug while also keeping the new functionality we've added. So we chose to keep the new bug-free implementation and hopefully be able to offer datadriven biome definitions in the future because of it.
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and hill of flower forest biomes (Seed 5178019746038571832, /tp @p 340 104 -3085 40 20)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
- Missing flower forest (Seed 554762737523904, /tp @p 394 118 -353)
Linked Issues
is duplicated by6
MC-125057More or less inconsistent terrain generation in comparison between Stable 1.12.2 and Snapshot 18w06aDuplicateMC-126345Flower Forests are Erased in Worlds Generated Pre 1.12 in 1.13 SnapshotsDuplicateMC-131025 Terrain generation sometimes generates different land biomes between 1.12.2 and 1.13DuplicateMC-131986Terrain generation boundariesDuplicateMC-133433World gen InconsistencyDuplicateMC-137007Terrain bug in 1.13.1DuplicateAttachments8
![[Mod] redstonehelper](../../../data/avatars/users/10122.svg){kind=small}
![[Helper] Michał](../../../data/avatars/users/43368.png){kind=small}
![[Mod] bemoty](../../../data/avatars/users/50554.png){kind=small}
Created Issue:
Biomes and landscape changed in new world generator
New world generator changed biomes and landscape in comparison with 1.12.2. Even whole ice spikes biome dissapeared with new world generator.
Example of pretty place in 1.12.2 that I'm waiting to generate in 1.13 to apply aquatic changes. Ice spikes next to flower forest in 1.12 - in 18w06a ice spikes are missing:Seed: 5178019746038571832
/gamemode spectator
/tp @p 323 104 -3066 40 40Dinnerbone mentionet that new world generator should speed up world generation, didn't mention about changing landscape
This bug also causes strange borders between old and new landscape. Attached screenshot.
Attachments3
2018-02-10_17.23.32.png
New world generator changed biomes and landscape in comparison with 1.12.2. Even whole ice spikes biome dissapeared with new world generator.
Example of pretty place in 1.12.2 that I'm waiting to generate in 1.13 to apply aquatic changes. Ice spikes next to flower forest in 1.12 - in 18w06a ice spikes are missing:Seed: 5178019746038571832
/gamemode spectator
/tp @p 323 104 -3066 40 40Dinnerbone mentione
tthat new world generator should speed up world generation, didn't mention about changing landscape
This bug also causes strange borders between old and new landscape. Attached screenshot.New world generator changed biomes and landscape in comparison with 1.12.2. Even whole ice spikes biome dissapeared with new world generator.
Example of pretty place in 1.12.2 that I'm waiting to generate in 1.13 to apply aquatic changes. Ice spikes next to flower forest in 1.12 - in 18w06a ice spikes are missing:Seed: 5178019746038571832
/gamemode spectator
/tp @p 323 104 -3066 40 40Dinnerbone mentioned that new world generator should speed up world generation, didn't mention about changing landscape
This bug also causes strange borders between old and new landscape. Attached screenshot.
New world generator changed biomes and landscape in comparison with 1.12.2. Even whole ice spikes biome dissapeared with new world generator.
Example of pretty place in 1.12.2 that I'm waiting to generate in 1.13 to apply aquatic changes. Ice spikes next to flower forest in 1.12 - in 18w06a ice spikes and flower forest "island" are missing:Seed: 5178019746038571832
/gamemode spectator
/tp @p 323 104 -3066 40 40Dinnerbone mentioned that new world generator should speed up world generation, didn't mention about changing landscape
This bug also causes strange borders between old and new landscape. Attached screenshot.
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
![[Mod] Neko](../../../data/avatars/users/92901.png){kind=small}
is duplicated by
relates to
New world generator changed biomes and landscape in comparison with 1.12.2. Even whole ice spikes biome dissapeared with new world generator.
Example of pretty place in 1.12.2 that I'm waiting to generate in 1.13 to apply aquatic changes. Ice spikes next to flower forest in 1.12 - in 18w06a ice spikes and flower forest "island" are missing:Seed: 5178019746038571832
/gamemode spectator
/tp @p 323 104 -3066 40 40Dinnerbone mentioned that new world generator should speed up world generation, didn't mention about changing landscape
This bug also causes strange borders between old and new landscape. Attached screenshot.The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and flower forest biomes (Seed 5178019746038571832, /tp @p 323 104 -3066 40 40)
!i
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and flower forest biomes (Seed 5178019746038571832, /tp @p 323 104 -3066 40 40)
!iThe new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and flower forest biomes (Seed 5178019746038571832, /tp @p 323 104 -3066 40 40)
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and flower forest biomes (Seed 5178019746038571832, /tp @p 323 104 -3066 40 40)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and flower forest biomes (Seed 5178019746038571832, /tp @p 323 104 -3066 40 40)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and flower forest biomes (Seed 5178019746038571832, /tp @p 323 104 -3066 40 40)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and flower forest biomes (Seed 5178019746038571832, /tp @p 323 104 -3066 40 40)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and flower forest biomes (Seed 5178019746038571832, /tp @p 323 104 -3066 40 40)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and hill of flower forest biomes (Seed 5178019746038571832, /tp @p 323 104 -3066 40 40)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and hill of flower forest biomes (Seed 5178019746038571832, /tp @p 3
23104 -30664040)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and hill of flower forest biomes (Seed 5178019746038571832, /tp @p 340 104 -3085 40 20)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
Biomes on land and landscape changed in new world generator
is duplicated by
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and hill of flower forest biomes (Seed 5178019746038571832, /tp @p 340 104 -3085 40 20)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
- Flower forests have (almost) no flowers (Seed 554762737523904, /tp @p 394 118 -353)
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and hill of flower forest biomes (Seed 5178019746038571832, /tp @p 340 104 -3085 40 20)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
Flower forests have (almost) no flowers(Seed 554762737523904, /tp @p 394 118 -353)
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and hill of flower forest biomes (Seed 5178019746038571832, /tp @p 340 104 -3085 40 20)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
- Missing flower forest (Seed 554762737523904, /tp @p 394 118 -353)
![[Mojang] Nathan Adams](../../../data/assets/gravatar/dinnerbone.png){kind=small}
[Mojang] Nathan Adams
is duplicated by
is duplicated by
is duplicated by
![[Mod] violine1101](../../../data/avatars/users/92858.png){kind=small}
WAI reasonWe wanted to do changes to the worldgen system to make it simple/clear and possible to datadrive it in the future.
While doing so we noticed at a certain moment that we generated some areas of the terrain differently than before (not meaning the things placed as decoration, but the actual shape of the land). It took a while to figure out why, but it turned out that in the old code, there had been a bug from the beginning. We forgot to reset the seed of a random when we merged rivers and the biomes.
In the new code there was no way to reproduce this wrong behavior and this is why [this issue] has been resolved as Working as Intended.
We're not happy that we ended up changing the world where the intention was not to. We found no way to keep the bug while also keeping the new functionality we've added. So we chose to keep the new bug-free implementation and hopefully be able to offer datadriven biome definitions in the future because of it.
The new world generator changed some biome and landscape generation compared to 1.12.2. Examples:
- Changed terrain and missing ice spikes and hill of flower forest biomes (Seed 5178019746038571832, /tp @p 340 104 -3085 40 20)
- Missing Desert M and Sunflower Plains biomes (Seed 1443894742985852992, /tp @p 100 200 100 0 90)
- Changed terrain and new Savanna M biome (Seed 1443894742985852992, /tp @p 195 115 555 60 27)
- Missing flower forest (Seed 554762737523904, /tp @p 394 118 -353)
is duplicated by
Added your examples to MC-125037.
Can you tell the seed and location?
Might be related to: MC-125037
I also took a look at those two bugs and they seem to be different than this one but most similar to MC-125037
![[Mod] NeunEinser](../../../data/avatars/users/39263.png){kind=small}
jredfox Yes, it does have to do with the world generator. The generator decides where the world spawn is located. The world spawn is the same for every world with the same seed.
Player spawn coords is not the same as the world spawn. The world spawn is basically the location in a world where you spawn when it is first generated or when you die without having a valid bed spawn.
Also, there are more changes then just ocean decorations, as described in MC-125037, MC-124950 and MC-124960. The latter ones are intentional changes, tho.
![[Mod] Skylinerw](../../../data/assets/gravatar/skylinerw.png){kind=small}
It's resolved as a "Duplicate" (you can see the resolution type after the text "Resolution"), and you can see under the heading "Issue Links" which report this one duplicates, being MC-125037.
Can confirm. Quoting ProfMobius (Thomas Guimbretiere) from
MC-124950, this seems to be an unintentional change.edited to replace my screenshots to make differences more visible. Screenshots made with 32 render distance from /tp @p 340 104 -3085 40 20
First time looked into the code with MCP to find how biomes works.
It seems that problem is caused by changed placement of Modified version of biomes. To be more precise - it's caused by modified biomes at edges of normal biomes. In 1.12 there was ability to generate Modified versions of 2 biomes next to each other. Probably caused by the same "Modifier". Now the Modifier doesn't spread to other biomes and doesn't enlarge the biome itself.
This will affect all modified versions of biomes: Sunflower plains, Savanna M, Flower Forest, Ice Spikes etc... Hope that will help finding a problem in the code.
[Helper] Michał The issue was marked as works as intended, you do not need to keep it updated
Hope dies the last.
Bit more info in here: https://www.reddit.com/r/Minecraft/comments/8zdfg4/i_thought_terrain_generation_wasnt_meant_to/e2j07jd/?context=3