The sounds of fishing bobbers aren't controlled by the "Players" sound slider
The Bug:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is producing these sounds and performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Players" sound slider to "OFF".
- Turn every other sound slider to "100%".
- Exit this menu, obtain a fishing rod, use it multiple times, and listen closely as you do this.
- Take note as to whether or not the sounds of fishing bobbers can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
The sounds of fishing bobbers would be controlled by the "Players" sound slider. The reason why the sounds of fishing bobbers should be controlled by the "Players" sound slider is that the player is retrieving or throwing the fishing bobbers and is the cause of these sounds being produced, thus should be controlled by the "Players" sound slider.
Code Analysis:
Code analysis by [Mod] Avoma can be found below.
The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
...
$$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F));
...
$$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F));
...
If we look at the above class, we can see that the sounds of fishing bobbers are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where the sounds of fishing bobbers are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
...
$$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F));
...
$$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F));
...
Linked Issues
is duplicated by3
relates to5
MC-112147Lava burning items or XP orbs sound muted when "Friendly Creatures" slider is turned offFixedMC-118616The sounds of magma cubes and slimes aren't controlled by the "Hostile Creatures" sound sliderFixedMC-137554Shearing sound is in "friendly creatures" sound categoryFixedMC-177604The sounds of many non-biological entities aren't controlled by the correct sound slider
LowMC-115643Can't hear punching blocks with 'Friendly Creatures' volume offFixedAttachments2
![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}
Created Issue:
Audio - Fishing - Casting and Catching sound error
The audio for casting a line and catching a fish is bound to the "Friendly Creatures" slider in Music & Sound Options.
Environment
Ingame
![[Mod] Neko](../../../data/avatars/users/92901.png){kind=small}
Ingame
![[Mojang] Nathan Adams](../../../data/assets/gravatar/dinnerbone.png){kind=small}
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
Audio - Fishing-Casting andCatching sounderrorAudio - Fishing: Casting and catching sound bound to bound to "Friendly Creatures" slider
Audio - Fishing: Casting and catching sound bound tobound to"Friendly Creatures" slider
relates to
relates to
relates to
is duplicated by
![[Bot] Arisa](../../../data/avatars/users/43007.png){kind=small}
is duplicated by
![[Mod] Anthony Cicinelli](../../../data/avatars/users/10122.svg){kind=small}
The Bug
The audio for casting a line and catching a fish is bound to the "Friendly Creatures" slider in Music & Sound Options.
Steps to Reproduce
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Friendly Creatures" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu and obtain a fishing rod.
- Use the fishing rod multiple times, and as you do this, listen closely.
- Take note as to whether or not fishing rod sounds can be heard, (are controlled by the "Friendly Creatures" sound slider).
Observed Behavior
Fishing rod sounds are controlled by the "Friendly Creatures" sound slider.
Expected Behavior
Fishing rod sounds would not be controlled by the "Friendly Creatures" sound slider.
The Bug
The audio for casting a line and catching a fish is bound to the "Friendly Creatures" slider in Music & Sound Options.Steps to Reproduce
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Friendly Creatures" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu and obtain a fishing rod.
- Use the fishing rod multiple times, and as you do this, listen closely.
- Take note as to whether or not fishing rod sounds can be heard, (are controlled by the "Friendly Creatures" sound slider).
Observed Behavior
Fishing rod sounds are controlled by the "Friendly Creatures" sound slider.
Expected Behavior
Fishing rod sounds would not be controlled by the "Friendly Creatures" sound slider.
The Bug:
Fishing rod sounds are controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Friendly Creatures" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu and obtain a fishing rod.
- Use the fishing rod multiple times, and as you do this, listen closely.
- Take note as to whether or not fishing rod sounds can be heard, (are controlled by the "Friendly Creatures" sound slider).
Observed Behavior:
Fishing rod sounds are controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
Fishing rod sounds would not be controlled by the "Friendly Creatures" sound slider.
Audio - Fishing: Casting and catching sound bound to"Friendly Creatures" sliderFishing rod sounds are controlled by the "Friendly Creatures" sound slider
The Bug:
Fishing rod sounds are controlled by the "
Friendly Creatures" sound slider.Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Friendly Creatures" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu and obtain a fishing rod.
- Use the fishing rod multiple times, and as you do this, listen closely.
- Take note as to whether or not fishing rod sounds can be heard, (are controlled by the "Friendly Creatures" sound slider).
Observed Behavior:
Fishing rod sounds are controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
Fishing rod sounds would
notbe controlled by the "Friendly Creatures" sound slider.The Bug:
Fishing rod sounds aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Friendly Creatures" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu and obtain a fishing rod.
- Use the fishing rod multiple times, and as you do this, listen closely.
- Take note as to whether or not fishing rod sounds can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
Fishing rod sounds aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
Fishing rod sounds would be controlled by the "Players" sound slider.
Fishing rod sounds are controlled by the "Friendly Creatures" sound sliderFishing rod sounds aren't controlled by the "Players" sound slider
The Bug:
Fishing rod sounds aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Friendly Creatures" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu and obtain a fishing rod.
- Use the fishing rod multiple times, and as you do this, listen closely.
- Take note as to whether or not fishing rod sounds can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
Fishing rod sounds aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
Fishing rod sounds would be controlled by the "Players" sound slider.
Code Analysis & Potential Fix:
Code analysis and a potential fix by [Mod] Avoma can be found in this comment.
The Bug:
Fishing rod sounds aren't controlled by the "Players" sound slider.Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Friendly Creatures" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu and obtain a fishing rod.
- Use the fishing rod multiple times, and as you do this, listen closely.
- Take note as to whether or not
fishing rod sounds can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).Observed Behavior:
Fishing rod sounds aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.Expected Behavior:
Fishing rod sounds would be controlled by the "Players" sound slider.Code Analysis & Potential Fix:
Code analysis and a potential fix by [Mod] Avoma can be found in
this comment.The Bug:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Friendly Creatures" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu and obtain a fishing rod.
- Use the fishing rod multiple times, and as you do this, listen closely.
- Take note as to whether or not the sounds of fishing bobbers can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
The sounds of fishing bobbers would be controlled by the "Players" sound slider.
Code Analysis:
The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...If we look at the above class, we can see that the sounds of fishing bobbers are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where the sounds of fishing bobbers are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...
Fishing rod sounds aren't controlled by the "Players" sound sliderThe sounds of fishing bobbers aren't controlled by the "Players" sound slider
The Bug:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "
Friendly Creatures" sound slider to "0%".- Turn every other sound slider to "100%".
- Exit this menu
andobtain a fishing rod.Use the fishing rod multiple times, and as you do this, listen closely.- Take note as to whether or not the sounds of fishing bobbers can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
The sounds of fishing bobbers would be controlled by the "Players" sound slider.
Code Analysis:
The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...If we look at the above class, we can see that the sounds of fishing bobbers are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where the sounds of fishing bobbers are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...The Bug:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is producing these sounds and performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Players" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu, obtain a fishing rod, use it multiple times, and listen closely as you do this.
- Take note as to whether or not the sounds of fishing bobbers can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider. The reason why the sounds of fishing bobbers should be controlled by the "Players" sound slider is that the player is performing these actions and is the cause of these sounds being produced, thus should be controlled by the "Players" sound slider.
Expected Behavior:
The sounds of fishing bobbers would be controlled by the "Players" sound slider.
Code Analysis:
The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...If we look at the above class, we can see that the sounds of fishing bobbers are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where the sounds of fishing bobbers are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...
The Bug:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is producing these sounds and performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Players" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu, obtain a fishing rod, use it multiple times, and listen closely as you do this.
- Take note as to whether or not the sounds of fishing bobbers can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
The reason why the sounds of fishing bobbers should be controlled by the "Players" sound slider is that the player is performing these actions and is the cause of these sounds being produced, thus should be controlled by the "Players" sound slider.Expected Behavior:
The sounds of fishing bobbers would be controlled by the "Players" sound slider.
Code Analysis:
The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...If we look at the above class, we can see that the sounds of fishing bobbers are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where the sounds of fishing bobbers are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...The Bug:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is producing these sounds and performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Players" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu, obtain a fishing rod, use it multiple times, and listen closely as you do this.
- Take note as to whether or not the sounds of fishing bobbers can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
The sounds of fishing bobbers would be controlled by the "Players" sound slider. The reason why the sounds of fishing bobbers should be controlled by the "Players" sound slider is that the player is performing these actions and is the cause of these sounds being produced, thus should be controlled by the "Players" sound slider.
Code Analysis:
The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...If we look at the above class, we can see that the sounds of fishing bobbers are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where the sounds of fishing bobbers are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...
The Bug:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is producing these sounds and performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Players" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu, obtain a fishing rod, use it multiple times, and listen closely as you do this.
- Take note as to whether or not the sounds of fishing bobbers can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
The sounds of fishing bobbers would be controlled by the "Players" sound slider. The reason why the sounds of fishing bobbers should be controlled by the "Players" sound slider is that the player is
performing these actions and is the cause of these sounds being produced, thus should be controlled by the "Players" sound slider.Code Analysis:
The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...If we look at the above class, we can see that the sounds of fishing bobbers are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where the sounds of fishing bobbers are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...The Bug:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is producing these sounds and performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Players" sound slider to "0%".
- Turn every other sound slider to "100%".
- Exit this menu, obtain a fishing rod, use it multiple times, and listen closely as you do this.
- Take note as to whether or not the sounds of fishing bobbers can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
The sounds of fishing bobbers would be controlled by the "Players" sound slider. The reason why the sounds of fishing bobbers should be controlled by the "Players" sound slider is that the player is retrieving or throwing the fishing bobbers and is the cause of these sounds being produced, thus should be controlled by the "Players" sound slider.
Code Analysis:
The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...If we look at the above class, we can see that the sounds of fishing bobbers are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where the sounds of fishing bobbers are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...
The Bug:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is producing these sounds and performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Players" sound slider to "
0%".- Turn every other sound slider to "100%".
- Exit this menu, obtain a fishing rod, use it multiple times, and listen closely as you do this.
- Take note as to whether or not the sounds of fishing bobbers can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
The sounds of fishing bobbers would be controlled by the "Players" sound slider. The reason why the sounds of fishing bobbers should be controlled by the "Players" sound slider is that the player is retrieving or throwing the fishing bobbers and is the cause of these sounds being produced, thus should be controlled by the "Players" sound slider.
Code Analysis:
The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...If we look at the above class, we can see that the sounds of fishing bobbers are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where the sounds of fishing bobbers are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...The Bug:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is producing these sounds and performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Players" sound slider to "OFF".
- Turn every other sound slider to "100%".
- Exit this menu, obtain a fishing rod, use it multiple times, and listen closely as you do this.
- Take note as to whether or not the sounds of fishing bobbers can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
The sounds of fishing bobbers would be controlled by the "Players" sound slider. The reason why the sounds of fishing bobbers should be controlled by the "Players" sound slider is that the player is retrieving or throwing the fishing bobbers and is the cause of these sounds being produced, thus should be controlled by the "Players" sound slider.
Code Analysis:
The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...If we look at the above class, we can see that the sounds of fishing bobbers are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where the sounds of fishing bobbers are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...
The Bug:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is producing these sounds and performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Players" sound slider to "OFF".
- Turn every other sound slider to "100%".
- Exit this menu, obtain a fishing rod, use it multiple times, and listen closely as you do this.
- Take note as to whether or not the sounds of fishing bobbers can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
The sounds of fishing bobbers would be controlled by the "Players" sound slider. The reason why the sounds of fishing bobbers should be controlled by the "Players" sound slider is that the player is retrieving or throwing the fishing bobbers and is the cause of these sounds being produced, thus should be controlled by the "Players" sound slider.
Code Analysis:
Code analysis by [Mod] Avoma can be found below.
The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...If we look at the above class, we can see that the sounds of fishing bobbers are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where the sounds of fishing bobbers are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...
![[Mod] markderickson](../../../data/avatars/users/18946.svg){kind=small}
is duplicated by
The Bug:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider.
Any action that is created through the player doing something that doesn't result in blocks being changed, is normally controlled by the "Players" sound slider. For example, the sounds of players milking cows, shearing sheep, and throwing tridents, are all controlled by the "Players" sound slider as they should be, because the player is producing these sounds and performing these actions.
The sounds of retrieving and throwing fishing bobbers aren't controlled by the "Players" sound slider when they should be, and are instead controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
- Navigate to the "Music & Sounds" settings menu.
- Turn the "Players" sound slider to "OFF".
- Turn every other sound slider to "100%".
- Exit this menu, obtain a fishing rod, use it multiple times, and listen closely as you do this.
- Take note as to whether or not the sounds of fishing bobbers can be heard, (are controlled by the "Friendly Creatures" sound slider instead of the "Players" sound slider).
Observed Behavior:
The sounds of fishing bobbers aren't controlled by the "Players" sound slider and are instead controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
The sounds of fishing bobbers would be controlled by the "Players" sound slider. The reason why the sounds of fishing bobbers should be controlled by the "Players" sound slider is that the player is retrieving or throwing the fishing bobbers and is the cause of these sounds being produced, thus should be controlled by the "Players" sound slider.
Code Analysis:
Code analysis by [Mod] Avoma can be found below.
The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...If we look at the above class, we can see that the sounds of fishing bobbers are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where the sounds of fishing bobbers are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
net.minecraft.world.item.FishingRodItem.java... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...
![[Mojang] Maxime Lebrot](../../../data/avatars/users/18941.svg){kind=small}
LowDuplicate of MC-139041
Thank you for your report!
However, we are already tracking this issue, and this report is a Duplicate of MC-139041, which is a report that has not been resolved yet.
If you want, you can upvote the parent ticket, and enable watching to receive any updates about it - if you believe you have any information that may be important for this issue, please leave a comment on the parent. Please also use the search function in the future to prevent duplicate reports.
Quick Links:
📓 Issue Guidelines – 🛠 Community Support – 📧 Customer Support – ✍️ Feedback and Suggestions – 📖 Game Wiki
💬 Mojira Subreddit – 💬 Mojira Discord
Thank you for your report!
We're tracking this issue in MC-139041, so this ticket is being resolved and linked as a duplicate.
If you would like to add a vote and any extra information to the main ticket it would be appreciated.
If you haven't already, you might like to make use of the search feature to see if the issue has already been mentioned.
Quick Links:
📓 Bug Tracker Guidelines – 💬 Community Support – 📧 Mojang Support
📓 Project Summary – ✍️ Feedback and Suggestions – 📖 Game Wiki
This is still an issue in 1.16.4
Can confirm in 21w03a.
Can confirm in 21w05b.
Can confirm in 1.17.
Can confirm in 1.17.1.
Can confirm in 21w42a. Here are some extra details regarding this problem.
The Bug:
Fishing rod sounds are controlled by the "Friendly Creatures" sound slider.
Steps to Reproduce:
Observed Behavior:
Fishing rod sounds are controlled by the "Friendly Creatures" sound slider.
Expected Behavior:
Fishing rod sounds would not be controlled by the "Friendly Creatures" sound slider.
Here's a code analysis along with a potential fix regarding this issue. The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.
Code Analysis:
... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.NEUTRAL, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...If we look at the above class, we can see that fishing rod sounds are sourced from SoundSource.NEUTRAL, otherwise known as the "Friendly Creatures" sound slider.
Potential Fix:
Simply changing where fishing rods sounds are sourced from to SoundSource.PLAYERS should resolve this problem. The correct line of code within its class should look something like the following:
... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.PLAYERS, 1.0F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ... $$0.playSound((Player)null, $$1.getX(), $$1.getY(), $$1.getZ(), SoundEvents.FISHING_BOBBER_THROW, SoundSource.PLAYERS, 0.5F, 0.4F / ($$0.getRandom().nextFloat() * 0.4F + 0.8F)); ...Can confirm in 23w33a
Along with the fix made by Avoma, include:
This makes all other sounds, such as splashing and sliding down a honey block use the Players category.