MC-169697Potted fern particles are discoloured
probably has the same root cause as MC-132734.
The particles generated from breaking, falling on, etc. potted ferns are a different colour from the particles produced by any other potted plant. This is due to the fern needing to change colour per biome, with this carrying on to the particles themselves.
Linked Issues
![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}
- Unresolved
Connor Steppie- 11
- 6
- Confirmed
Low- Gameplay
- Particles Rendering
- particle-testing-corner unexpected-tint
1.15.1 - 1.21.4
1.15.1 1.15.2-pre1 1.15.2-pre2 20w06a 20w07a 20w08a 20w09a 20w10a 20w11a 20w12a 20w13a 20w21a 1.16-pre2 1.16-pre3 1.16-pre5 20w28a 20w29a 20w30a 1.16.2-pre1 1.16.2 1.16.3 1.16.4 20w51a 21w03a 21w05b 21w06a 21w07a 21w13a 21w14a 21w20a 1.17-pre1 1.17 1.17.1 1.18.1 1.18.2 1.19 1.19.1-pre6 1.19.2 1.19.3 23w04a 1.21.4
Created Issue:
Potted fern particles are discoloured
Very closely relates to MC-132734 and probably has the same root cause.
The particles generated from breaking, falling on, etc. potted ferns are a different colour from the particles produced by any other potted plant. This is due to the fern needing to change colour per biome, with this carrying on to the particles themselves.
Attachments2
![[Mod] violine1101](../../../data/avatars/users/92858.png){kind=small}
![[Mojang] Adrian Östergård](../../../data/assets/gravatar/nighter.jpeg){kind=small}
Very closely relates toMC-132734 and probably has the same root cause.The particles generated from breaking, falling on, etc. potted ferns are a different colour from the particles produced by any other potted plant. This is due to the fern needing to change colour per biome, with this carrying on to the particles themselves.
probably has the same root cause as MC-132734.
The particles generated from breaking, falling on, etc. potted ferns are a different colour from the particles produced by any other potted plant. This is due to the fern needing to change colour per biome, with this carrying on to the particles themselves.
![[Mod] Chandler](../../../data/assets/gravatar/triwonder81.png){kind=small}
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
![[Mod] markderickson](../../../data/avatars/users/18946.svg){kind=small}
![[Helper] Johnibur](../../../data/avatars/users/28381.png){kind=small}
![[Mod] ampolive](../../../data/avatars/users/18949.svg){kind=small}
![[Mojang] slicedlime](../../../data/assets/gravatar/slicedlime.jpeg){kind=small}
Relates to MC-213503, MC-4040 and MC-29544.
The bug
Particles generated via commands or otherwise for blocks which are tinted themselves appear tinted to match this. However, for items (such as the direct item form of said blocks), no tint appears to be applied at all, despite the item also using a tint.
Tested for lily pads and leaves. Other items such as potions and spawn eggs are likely also affected, however are yet to be tested.
How to reproduce
- Place a lily pad
- Notice that it has a tint when placed
- Obtain a lily pad in the inventory
- Notice it also uses a tint
- /particle minecraft:block lily_pad ~ ~ ~
- Notice that the particles are green, like the block
- /particle minecraft:item lily_pad ~ ~ ~
- Notice that the particles are gray, unlike the item
Expected behaviour
The item particles would be tinted to match the item color.
Actual behaviour
The item particles just seem to use the raw texture of the item form, never taking tinting into consideration.
Suggested fix
Model files could have a new parameter added: "tint_particles": "true/false". This way, particle tints could be customized per model, allowing for these items to have them enabled through this parameter, as well as fixing bugs like MC-132734 and MC-169697 (and also disabling it for grass blocks through the model rather than hardcoding it) simply by having it be set to false.
The bug
The particles used for grass blocks do not appear tinted by default. This is likely due to grass blocks using the dirt texture for particles and not incorporating any grass textures, and therefore the tint is hardcoded not to appear as to avoid cases like MC-132734 and MC-169697. However, as a result, even if the model is changed to use the top texture for particles instead, they will never appear tinted, resulting in very out of place gray particles appearing.
How to reproduce
- Download and apply the attached TopOfTheGrass resource pack, whcih changes the grass model to use the top texture for particles
- Now cause any action which results in block particles appearing: breaking, sprinting, falling, iron golems walking, ...
- Note how the particles are completely gray and not tinted green as one would expect
Expected result
The particles used by the block would be tinted since the top texture of grass is now used as the particle.
Actual result
The particles are completely gray and therefore look very out of place.
How to fix
As this is due to whether or not particles are tinted being hardcoded, this cannot be fixed with models alone (outside of introducing a second faux top texture, which would only look good in some biomes anyway). There are two ways that could be used to fix this in a data-driven way, rather than having to rely on hardcoding:
- A new optional top level parameter could be added to model files, such as "tint_particles": "true/false", to configure whether or not the block's particles appear tinted or do not. This would allow for very easy fixes to issues like MC-132734, MC-169697 and
MC-213503, where this parameter could easily just be set to "false" (and grass blocks would also have this set to "false" by default as well, and could be set to "true" by a resource pack maker who desires tinted particles), as well as possiblyMC-238099, where a "true" may be missing somewhere. - There could also be a block tag which contains blocks which use tints, which specifically overrides its members to not use tints. As tags can only contain IDs and not specific state combinations, this may pose a problem in future if only a specific state needs to be tinted, but should work for now.
Can confirm in 20w51a.
Can confirm in 21w05b.
Can confirm in 21w06a.
Can confirm in 21w07a.
Can confirm in 21w13a.
Can confirm in 21w14a.
Can confirm in 1.17.
Can confirm in 1.17.1.
Can confirm in 1.18.
Can confirm in 1.18.1.
Can confirm in 1.19.
Can cnfirm in 1.19.1-pre6.
Can confirm in 1.19.2.
i can confirm in 1.19.3 and 23w04a