MC-80658Note blocks: Gray color for certain music notes
The bug
Up to Minecraft 1.8.1 the note symbols were always colored, since 1.8.2 there are certain gray colored notes.
How to reproduce
/particle note ~ ~1 ~ 0.08333333333333333333333333333333 0 0 1 0
Code analysis
Code analysis by Marcono1234 can be found in this comment.
Linked Issues
- Fixed
LuMo25- [Mojang] Bartosz Bok
- 20
- 12
- Confirmed
- block color colour gray grey music note_block
1.8.3 - 19w09a
1.8.3 1.8.4 1.8.5 1.8.6 1.8.7 1.8.8 15w31a 15w31b 15w33a 15w33b 15w34a 15w34b 15w34c 15w34d 15w35b 15w35d 15w35e 15w36b 15w36c 15w36d 15w39a 15w39b 15w39c 15w40a 15w40b 15w42a 15w43c 15w44a 15w45a 15w46a 15w47a 15w47b 15w47c 15w49a 15w49b 15w50a 15w51a 15w51b 16w02a 16w03a 16w05b 16w06a 1.9-pre1 1.9-pre2 1.9.4 1.10 1.11.2 17w17a 1.12.1 1.13 1.13.1 1.13.2 19w09a- 19w11a
Created Issue:
bad color for the musical notes
the color of certain musical notes are black and white
Attachments1
the color of certain musical notes are
black and whitethe color of certain musical notes are gray
badcolor forthemusicalnotesGray color for certain music notes
is duplicated by
![[Bot] Arisa](../../../data/assets/gravatar/mustek2.png){kind=small}
is duplicated by
![[Mojang] Grum (Erik Broes)](../../../data/assets/gravatar/grum.png){kind=small}
ProfMobius (Thomas Guimbretiere)A comment with security level 'global-moderators' was removed.
the color of certain musical notes are gray
/particle note ~ ~1 ~ 0.08333333333333333333333333333333 0 0 1
the color of certain musical notes are gray
/particle note ~ ~1 ~ 0.08333333333333333333333333333333 0 0 1
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
the color of certain musical notes are gray
/particle note ~ ~1 ~ 0.08333333333333333333333333333333 0 0 1
the color of certain musical notes are gray
/particle note ~ ~1 ~ 0.08333333333333333333333333333333 0 0 1
Code analysis by Marcono1234 can be found in this comment.
the color of certain musical notes are gray
/particle note ~ ~1 ~ 0.08333333333333333333333333333333 0 0 1
Code analysis by Marcono1234 can be found in this comment.
Up to Minecraft 1.8.1 the note symbols were always colored, since 1.8.2 there are certain gray colored notes.
/particle note ~ ~1 ~ 0.08333333333333333333333333333333 0 0 1
Code analysis by Marcono1234 can be found in this comment.
![[Mod] violine1101](../../../data/avatars/users/92858.png){kind=small}
Up to Minecraft 1.8.1 the note symbols were always colored, since 1.8.2 there are certain gray colored notes.
/particle note ~ ~1 ~ 0.08333333333333333333333333333333 0 0 1
Code analysis by Marcono1234 can be found in this comment.
The bug
Up to Minecraft 1.8.1 the note symbols were always colored, since 1.8.2 there are certain gray colored notes.
How to reproduce
/particle note ~ ~1 ~ 0.08333333333333333333333333333333 0 0 1
Code analysis
Code analysis by Marcono1234 can be found in this comment.
![[Mod] Asteraoth](../../../data/avatars/users/92886.png){kind=small}
The bug
Up to Minecraft 1.8.1 the note symbols were always colored, since 1.8.2 there are certain gray colored notes.
How to reproduce
/particle note ~ ~1 ~ 0.08333333333333333333333333333333 0 0 1 0
Code analysis
Code analysis by Marcono1234 can be found in this comment.
![[Mod] Sonicwave](../../../data/avatars/users/94627.png){kind=small}
![[Mojang] Adrian Östergård](../../../data/assets/gravatar/nighter.jpeg){kind=small}
Duplicates MC-80658
Confirmed
Up to Minecraft 1.8.1 the note symbols were always colored, since 1.8.2 there are certain gray colored notes.
I think it's the color green which has become gray.
Confirmed for
It seems like (nearly) all colors are incorrect, according to the wiki note 0 for example should be green
Please mention somewhere in this report "Note block" and also add labelsThank you
Can be reproduce for example with the following command:
This should equal the second note.
Please link to this comment in the description
The following is based on decompiled version of Minecraft 1.9 using MCP 9.24 beta. All method and class names are the names used in the decompiled version.
The reason why this happens seems to be that the method net.minecraft.client.particle.EntityFX.renderParticle(VertexBuffer, Entity, float, float, float, float, float, float) was changed in a way that it now sets the color differently. I am however not too familiar with what the methods do and how the rendering is done so I am unable to tell what the exact reason is.
Confirmed for 17w17a. I know this isn't high-priority, but since the upcoming update is 'World of colour' and note blocks have been worked on, perhaps it's time to bring back the vibrantly-coloured note particles.
Still happen on 1.13
Still happens in the latest snapshot (19w09a).
If I had to guess what causes this problem, I would say it's because the formula for calculating the note colors sometimes returns negative values.
Maybe the particle rendering code change in 1.8.2 made it no longer like negative colors.
In that case the easiest way to fix it would probably be changing the color formula in the particle class.
It would be really nice if this was fixed before 1.14 comes out with the new instruments. Cheers!