MC-212616"Dye stains" sound does not play when used on tamed wolves/cats
In 21w03a, a new sound was added for sign dyeing functionality which was also applied to sheep. However, despite wolf and cat collars being dyeable via the exact same functionality, the sound does not play here (note the lack of subtitles in the provided screenshots).
Attachments13
![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}
NormalCreated Issue:
"Dye stains" sound does not play when used on tamed wolves/cats
In 21w03a, a new sound was added for sign dyeing functionality which was also applied to sheep. However, despite wolf and cat collars being dyeable via the exact same functionality, the sound does not play here (note the lack of subtitles in the provided screenshots).
Attachments12
![[Helper] Jack McKalling](../../../data/avatars/users/92859.png){kind=small}
![[Mojang] Adrian Östergård](../../../data/assets/gravatar/nighter.jpeg){kind=small}
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
![[Mod] markderickson](../../../data/avatars/users/18946.svg){kind=small}
![[Helper] Johnibur](../../../data/avatars/users/28381.png){kind=small}
![[Mod] ampolive](../../../data/avatars/users/18949.svg){kind=small}
![[Mojang] slicedlime](../../../data/assets/gravatar/slicedlime.jpeg){kind=small}
![[Mod] EVGENSYPERPRO](../../../data/avatars/users/92853.png){kind=small}
That is actually a valid parity issue! The sound for using dye was added in 1.17 and on java it plays when used on signs and sheep. It is also supposed to play when used on cats and dogs MC-212616 and on bedrock it should also play when used on shulkers.
Also, the sound is already present in the bedrock and is used when dyeing signs.
Can confirm.
Can confirm in 21w05b.
Can confirm in 21w06a.
Can confirm in 21w08b. Video attached.
Can confirm in 21w14a.
1.16.5 should be removed from affected version list because the sound didn't even exist in 1.16.5
[Helper] Jack McKalling can you explain why you added it?
In 21w17a
In 21w18a
Can confirm in 1.17.1.
Can confirm in 21w39a.
Can confirm for 1.18 Pre-1
Can confirm in 1.18.1.
Here's a code analysis of this issue. The following is based on a decompiled version of Minecraft 1.18.1 using MCP-Reborn. Please note that I'm quite tentative about this analysis, although I'm persuaded to believe that this is likely the cause of the problem.
Code Analysis (tentative):
Normally, when a player interacts with an entity that produces a sound upon being interacted with, a method is called that plays the appropriate sound, however, if we look at the above classes, we can see that no methods are called to produce sounds upon these interactions being carried out. As a result of the appropriate method not being called/not existing altogether, no sound is played upon dying wolves' and cats' collars.
In 22w05a!
Can confirm in 1.18.2.
Can confirm in 1.19 and 22w24a.
Can confirm in 1.19.2.