Seagrass, kelp, coral and coral fans become waterlogged when placed in downwards flowing water
They should only become waterlogged when placed inside a water source block. To reproduce:
1. Dig a 1x1 two deep hole
2. Place a water source block on the top air block
3. Place a coral on the bottom
4. Remove the water source block from the top
Code Analysis:
Code analysis by [~JingyBreadMan] can be found in this comment.
Linked Issues
is duplicated by2
relates to4
Created Issue:
Some blocks become waterlogged when placed in downwards flowing water
They should only become waterlogged when placed inside a water source block. To reproduce:
1. Dig a 1x1 two deep hole
2. Place a water source block on the top air block
3. Place a sea pickle on the bottom
4. Remove the water source block from the top
relates to
relates to
They should only become waterlogged when placed inside a water source block. To reproduce:
1. Dig a 1x1 two deep hole
2. Place a water source block on the top air block
3. Place asea pickleon the bottom
4. Remove the water source block from the topThey should only become waterlogged when placed inside a water source block. To reproduce:
1. Dig a 1x1 two deep hole
2. Place a water source block on the top air block
3. Place a coral on the bottom
4. Remove the water source block from the top
They should only become waterlogged when placed inside a water source block. To reproduce:
1. Dig a 1x1 two deep hole
2. Place a water source block on the top air block
3. Place a coral on the bottom
4. Remove the water source block from the topCode Analysis:
Code analysis by [~JingyBreadMan] can be found in this comment.
is duplicated by
Some blocks become waterlogged when placed in downwards flowing waterSeagrass, kelp, coral and coral fans become waterlogged when placed in downwards flowing water
it's same as MC-133814 - by placing second pickle you created second watersource and 2 water sources spreaded to waterloggable blocks like normal.
Isnt that because the new water flow algorithm
Confirmed for 1.13.1-pre1
Confirmed for 1.13.1
Can't seem to reproduce this with sea pickles in 21w06a. Are there any other blocks that this works with?
Can confirm in 1.19.4 Pre-release 1.
Affect coral, coral fan, seagrass, kelp.
Code Analysis:
The reason for this happening is due to the returned blockstate in the getStateForPlacement() method for kelp, coral plant/fan, and seagrass. All of these blocks add an additional check at the end of the return value "&& fluidState.getAmount() == 8" which checks to see if the blockstate occupying where the player is clicking is a level 8 (so it does not check for a "source block", but rather just level 8).
@Override @Nullable public BlockState getStateForPlacement(BlockPlaceContext blockPlaceContext) { FluidState fluidState = blockPlaceContext.getLevel().getFluidState(blockPlaceContext.getClickedPos()); return (BlockState)this.defaultBlockState().setValue(WATERLOGGED, fluidState.is(FluidTags.WATER) && fluidState.getAmount() == 8); }Confirmed in 1.21.3
Confirmed in 1.21.4 prerelease 2