MC-131562Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat
The Bug:
Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Steps to Reproduce:
- Summon a command block minecart by using the command provided below.
/summon minecraft:command_block_minecart ~ ~ ~
- Open it up and press the "Done" button.
- Take note as to whether or not pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Observed Behavior:
Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Expected Behavior:
Pressing the "Done" button in empty command block minecarts would not print the message "Command set:" in chat. Instead, no message should be printed at all, as no command has been inserted into the command block minecart.
Attachments2
- Unresolved
![[Mod] Avoma](../../../data/avatars/users/86198.png)
[Mod] Avoma
Pau Olivares- 10
- 6
- Confirmed
- (Unassigned)
- command_block_minecart
1.13-pre2 - 1.21.4
1.13-pre2 1.13-pre3 1.13-pre4 1.13-pre5 1.13-pre6 1.13-pre7 1.13-pre8 1.13-pre9 1.13-pre10 1.13 18w30a 18w30b 18w31a 18w32a 18w33a 1.13.1-pre1 1.13.1-pre2 1.13.1 1.13.2-pre1 1.13.2-pre2 1.13.2 18w43b 18w43c 18w44a 18w45a 18w47a 18w47b 18w48a 18w48b 18w49a 18w50a 19w03c 19w04b 19w12b 19w13b 19w14a 19w14b 1.14-pre2 1.14-pre3 1.15.1 1.15.2-pre1 1.15.2-pre2 1.15.2 20w17a 20w21a 1.16-pre2 1.16-pre3 1.16-pre5 1.16-pre7 20w51a 1.16.5 21w06a 21w08b 1.17 1.17.1 21w40a 21w41a 21w42a 21w43a 1.18-pre1 1.18-pre7 1.18 1.18.1 22w06a 22w07a 1.18.2 22w17a 22w18a 1.19 1.19.2 22w43a 1.19.3 1.19.4 1.20 1.20.1 23w32a 1.20.3-rc1 1.20.4 23w51b 1.20.6 1.21 1.21.3 1.21.4
Created Issue:
Command Blocks messages
If you click on a Minecart with a command block and you press done without setting any command a message will appear in the chat (Command set
. However, if you do the same with a Command block, that message won't appear.
If you click on a Minecart with a command block and you press done without setting any command a message will appear in the chat (Command set
If you click on a Minecart with a command block and you press done without setting any command a message will appear in the chat (Command set: ). However, if you do the same with a Command block, that message won't appear.
If you click on a Minecart with a command block and you press
done without setting any command a message will appear in the chat (Command set: ). However, if you do the same with a Command block, that message won't appear.
If you click on a Minecart with a command block and you press "Done" without setting any command a message will appear in the chat (Command set: ). However, if you do the same with a Command block, that message won't appear.
Command Blocksmessages
![[Mod] tryashtar](../../../data/avatars/users/41963.png){kind=small}
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
If you click on a Minecart with a command block and you press "Done" without setting any command a message will appear in the chat (Command set: ). However, if you do the same with a Command block, that message won't appear.
Probably it's because of my computer. But the messages don't appear for me
![[Mod] Neko](../../../data/avatars/users/92901.png){kind=small}
Command Block messagesPressing "Done" in an empty command block minecart returns "Command set:"
No problem
. I'm pretty sure this is a developing error. I hope that can be fixed for future versions!
Still present in MC 1.13-pre3.
Still present in MC 1.13-pre5.
Still present in MC 1.13-pre4.
![[Helper] Lord_Quadrato](../../../data/avatars/users/26105.png){kind=small}
You don't need to comment on your own issue, you can update the list of affected versions yourself (as you did) and there's no need to spam unnecassary "Confirmed" comments. Remember that everyone watching this issue gets an e-mail
![[Mojang] Nathan Adams](../../../data/assets/gravatar/dinnerbone.png){kind=small}
![[Mod] Asteraoth](../../../data/avatars/users/92886.png){kind=small}
![[Mod] NeunEinser](../../../data/avatars/users/39263.png){kind=small}
The Bug:
Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Steps to Reproduce:
- Summon a command block minecart.
- Open it up and press the "Done" button.
- Take note as to whether or not pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Observed Behavior:
Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Expected Behavior:
Pressing the "Done" button in empty command block minecarts would not print the message "Command set:" in chat. Instead, no message should be printed at all, as no command has been inserted into the command block minecart.
Pressing "Done"inan empty command block minecartreturns"Command set:"Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat
The Bug:
Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Steps to Reproduce:
- Summon a command block minecart.
- Open it up and press the "Done" button.
- Take note as to whether or not pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Observed Behavior:
Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Expected Behavior:
Pressing the "Done" button in empty command block minecarts would not print the message "Command set:" in chat. Instead, no message should be printed at all, as no command has been inserted into the command block minecart.
The Bug:
Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Steps to Reproduce:
- Summon a command block minecart.
- Open it up and press the "Done" button.
- Take note as to whether or not pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Observed Behavior:
Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Expected Behavior:
Pressing the "Done" button in empty command block minecarts would not print the message "Command set:" in chat. Instead, no message should be printed at all, as no command has been inserted into the command block minecart.
The Bug:
Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Steps to Reproduce:
- Summon a command block minecart.
- Open it up and press the "Done" button.
- Take note as to whether or not pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Observed Behavior:
Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Expected Behavior:
Pressing the "Done" button in empty command block minecarts would not print the message "Command set:" in chat. Instead, no message should be printed at all, as no command has been inserted into the command block minecart.
The Bug:
Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Steps to Reproduce:
- Summon a command block minecart by using the command provided below.
/summon minecraft:command_block_minecart ~ ~ ~- Open it up and press the "Done" button.
- Take note as to whether or not pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Observed Behavior:
Pressing the "Done" button in empty command block minecarts prints the message "Command set:" in chat.
Expected Behavior:
Pressing the "Done" button in empty command block minecarts would not print the message "Command set:" in chat. Instead, no message should be printed at all, as no command has been inserted into the command block minecart.
![[Mod] turbo](../../../data/avatars/users/92867.png){kind=small}
Affects 21w40a
Relates to MC-131562
Cannot reproduce, both make messages for me
Oops, my mistake, I can reproduce now. Haha, sorry about that
Confirmed for 1.13-pre8.
Confirmed for 1.13-pre9.
Confirmed for 1.13-pre10.
Confirmed in 1.16 Pre-release 2.
Confirmed in 1.16-pre3.
Confirmed in 1.16-pre4.
Confirmed in 1.16-pre5.
Confirmed in 1.16-pre6.
Confirmed in 1.16-pre7.
Confirmed in 1.16-pre8.
Confirmed in 1.16-rc1.
Can confirm in 20w51a.
Can confirm in 21w06a.
Can confirm in 21w08b. Video attached.
Same with command blocks
Can confirm in 1.16.5. Justin Zheng, are you sure? I'm almost certain that this can only be reproduced with command block minecarts.
I've taken a look at the code, and the fix seems to be quite simple.
In a normal command block, a check is done to see if the string is empty beforehand (yarn mappings):
ServerPlayNetworkHandler#onUpdateCommandBlock
But, in a minecart command block, the implementation is different (yarn mappings):
ServerPlayNetworkHandler#onUpdateCommandBlockMinecart
This issue can easily be solved by only calling sendSystemMessage if ChatUtil#isEmpty returns false like a normal command block
Affects 1.17
Can confirm in 1.17.1.
Affects 21w40a
Can confirm in 21w41a. The expected behavior would be that upon pressing the "Done" button in a command block minecart without a command in it, no message would be printed into the chat.
Can confirm in 1.20.3 Release Candidate 1