Swimming in water, riding a minecart or standing on soul sand and snow layers 8 darkens the sky at day time
The bug
In some situations the sky darkens when it shouldn't.
Affected situations
Likely incomplete
- Sitting in a minecart or boat
- Swimming in water
- Standing on soul sand and snow layers 8
Code analysis and possible fix
The bug was introduced in 1.8 (according to the bug report comments) where they changed the client to track entities by their feet location instead of their eye location. This bug fix does the sky light calculation (for determining fog color) at the entity's eye location where it should be instead of their feet.
float f3 = this.mc.world.getLightBrightness(new BlockPos(this.mc.getRenderViewEntity()));
Linked Issues
is duplicated by30
MC-48871When I go on soul sand, 1) the sky turns dark. 2) my hand also turns darkDuplicateMC-49130Sky and held Items become darker when sitting in a minecart.DuplicateMC-49457Sky darkens when standing on Soul Sand or in waterDuplicateMC-50960When In a Minecart The Sky light diminishes. DuplicateMC-54111MInecart & Sky texture bugDuplicateMC-55842skyDuplicateMC-56505Sky seems to turn darker REALLY FAST while getting deeper in the water.DuplicateMC-64048Ilumination glitch when walking over soul sandDuplicateMC-65712Sky turns black while sitting in a minecartDuplicateMC-65858Dark sky on minecartsDuplicateMC-66488Sky turns black when you are in a minecartDuplicateMC-67260Sky goes black when in minecartDuplicateMC-69674Standing on soulsand will darken the skyDuplicateMC-70254Sky darkens when standing on Soul SandDuplicateMC-70717distant sky dims when shade overhead or in waterDuplicateMC-70965Sky darkens when in a minecart or boat.DuplicateMC-72635When flying close to water, the sky turns darkDuplicateMC-77992Flat land has black on the skyDuplicateMC-78168Boat 3rd person perspectiveDuplicateMC-80675Riding in Minecart Causes Lighting IssueDuplicateMC-83463Soul Sand Alters SkyDuplicateMC-84359The sky gets dark when riding a minecartDuplicateMC-89472Minecart fog flashes in moving minecartsDuplicateMC-102491Summoning a MinecartRideable causes a change in the sky lightDuplicateMC-105923(Player) when is in minecart a sky changed color to grey!DuplicateMC-106410If a player standing on farmland and in the moment when farmland changing to a dirt a player can't move and a sky will be gray!DuplicateMC-106549Sky goes dark in minecartDuplicateMC-125320Black fog / dimmed screen on water surfaceDuplicateMC-132193When riding up or down in a minecart, the sky at the horizon will start flashingDuplicateMC-133951Sky darkens whilst in a boatDuplicaterelates to5
MC-31681Fog and clouds darken when indoors or under trees (<16 Chunk Render Distance)FixedMC-47591Held Items are black hile riding a Minecart / BoatFixedMC-139631Light levels in the F3 debug menu aren't accurate when standing on soul sand
LowMC-48294Items you're holding go black when you walk on soul sandFixedMC-123135Standing on half block / stairs / grass path / farmland gives "cave effect" to skyFixed
Created Issue:
when sitting in a minecart, the sky darkens even if its day time
Put the summary of the bug you're having here
What I expected to happen was...:
the sky would stay the sameWhat actually happened was...:
the sky darkened after entering a minecartSteps to Reproduce:
1. place a minecart
2. sit in minecartEnvironment
Put your operating system (Windows 7, Windows XP, OSX) and Java version if you know it here
Attachments1
2014-03-13_16.42.27.png
duplicates
is duplicated by
when sittinginaminecart, the sky darkens even if itsday timeRiding a Minecart or standing on Soul sand darkens the sky at day time
Riding a Minecart or standing on Soul sand darkens the sky at day timeSwimming in the water, riding a Minecart or standing on Soul sand darkens the sky at day time
relates to
is duplicated by
duplicates
relates to
is duplicated by
relates to
is duplicated by
is duplicated by
is duplicated by
![[Mod] Torabi](../../../data/assets/gravatar/torabi.png){kind=small}
is duplicated by
is duplicated by
![[Mod] Neko](../../../data/avatars/users/92901.png){kind=small}
Confirmed for 36d
is duplicated by
is duplicated by
Put your operating system (Windows 7, Windows XP, OSX) and Java version if you know it here
is duplicated by
is duplicated by
is duplicated by
is duplicated by
Swimming in the water, riding a Minecart or standing on Soul sand darkens the sky at day timeSky darkens already when player is below y = 1 (standing on non full blocks, sitting in minecarts / boats, etc.)
Sky darkens already when player is below y = 1 (standing on non full blocks, sitting in minecarts / boats, etc.)Swimming in the water, riding a Minecart or standing on Soul sand darkens the sky at day time
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
Swimming inthewater, riding aMinecart or standing onSoul sand darkens the sky at day timeSwimming in water, riding a minecart or standing on soul sand darkens the sky at day time
Put the summary of the bug you're having hereWhat I expected to happen was...:
the sky would stay the sameWhat actually happened was...:
the sky darkened after entering a minecartSteps to Reproduce:
1. place a minecart
2. sit in minecartThe bug
In some situations the sky darkens when it shouldn't.
Affected situations
Likely incomplete
- Sitting in a minecart
- Swimming in water
- Standing on soul sand
Code analysis and possible fix
The bug was introduced in 1.8 (according to the bug report comments) where they changed the client to track entities by their feet location instead of their eye location. This bug fix does the sky light calculation (for determining fog color) at the entity's eye location where it should be instead of their feet.
![[Mod] Les3awe](../../../data/avatars/users/79847.png){kind=small}
relates to
The bug
In some situations the sky darkens when it shouldn't.
Affected situations
Likely incomplete
- Sitting in a minecart
- Swimming in water
- Standing on soul sand and snow layers 8
Code analysis and possible fix
The bug was introduced in 1.8 (according to the bug report comments) where they changed the client to track entities by their feet location instead of their eye location. This bug fix does the sky light calculation (for determining fog color) at the entity's eye location where it should be instead of their feet.
Swimming in water, riding a minecart or standing on soul sand and snow layers 8 darkens the sky at day time
is duplicated by
The bug
In some situations the sky darkens when it shouldn't.
Affected situations
Likely incomplete
- Sitting in a minecart
- Swimming in water
- Standing on soul sand and snow layers 8
Code analysis and possible fix
The bug was introduced in 1.8 (according to the bug report comments) where they changed the client to track entities by their feet location instead of their eye location. This bug fix does the sky light calculation (for determining fog color) at the entity's eye location where it should be instead of their feet.
float f3 = this.mc.world.getLightBrightness(new BlockPos(this.mc.getRenderViewEntity()));
is duplicated by
is duplicated by
The bug
In some situations the sky darkens when it shouldn't.
Affected situations
Likely incomplete
- Sitting in a minecart or boat
- Swimming in water
- Standing on soul sand and snow layers 8
Code analysis and possible fix
The bug was introduced in 1.8 (according to the bug report comments) where they changed the client to track entities by their feet location instead of their eye location. This bug fix does the sky light calculation (for determining fog color) at the entity's eye location where it should be instead of their feet.
float f3 = this.mc.world.getLightBrightness(new BlockPos(this.mc.getRenderViewEntity()));
![[Mod] Pokechu22](../../../data/avatars/users/92931.png){kind=small}
relates to
![[Mod] Sonicwave](../../../data/avatars/users/94627.png){kind=small}
That's MC-51150 (related to this issue).
Duplicate of MC-51150. Please search before creating new issues.
Dupe of MC-51150
The sky going black thing was actually fixed a while back (MC-51150); my motivation for creating this issue was MC-46667 being fixed for all blocks other than soul sand. It is still an issue from my testing.
The redstone and rails thing (MC-139497) is presumably its own issue since it's new (as far as I can tell), although it might actually be related to them attempting to fix this by changing whether a face is solid or something (I'd have to investigate further).
(That said, it could very much be WAI, as MC-46667 was marked as WAI (albeit by another mod and not a dev); I'm hoping to get a dev confirmation with regards to that on this issue)
Reopening this, because the part "Held Items darken in Minecart" of
MC-47591is fixed.When in a Minecart, the sky only darkens on a flat track. It's normal on an incline. (And it alternates between and light when on a track that alternates between flat and inclined tracks.)
I think that this is due to the light levels being calculated from the feet instead of from your head (combined with the bug where you sit too low in Minecarts).
And light levels are being calculated from your feet instead of your head because of a bug fix in an early 1.8 snapshot.
Before the fix, the client referenced entities by eye position rather than feet position (the real coordinates). Now it uses the feet position, like the server does.
The sky darkening is dependent on the light level at the player's position. Since it now reads the position from the feet, it reads the light level at the feet, even when the player's eyes have a different light level.
What would fix this is to make the sky darkening read the light level from the eyes, separate from the other client functions that use player position.
Related to
MC-31681.Confirmed for 1.8.1-pre4.
Confirmed for 1.8.1.
Does this affects also on chunk distance > 16?
Not sure what "chunk distance > 16" means here, but I have my draw distance at maximum and it affects me.
There's another bug involved in this which I've reported elsewhere: Distant sky should not be affected by light level at the player's position. Having it get dimmer the moment the player steps under a tree is creepy and weird. (It's one of the reasons I stopped playing Minecraft this year.) If anything, the sky should get brighter not dimmer when the player's immediate environment gets dimmer, but it's simpler to just have it unaffected; which would also fix this issue.
I second the analysis of the issue offered by BoxFigs and Sonicwave. This is especially evident when swimming, as the darkening of the horizon seems to occur only when one's feet are significantly below water. When swimming on the surface, the horizon lightens/darkens with each 'stroke'.
edit: i.e. the light levels seem to be calculated from the feet, not the head.
Confirmed for 1.8.6
Shouldn't this just be merged with
MC-31681?@ a: This bug is when the player's feet are in the ground. That bug is when the sky light at the player's location is less than 15.
Yes I know. But I think it's the same underlying issue.
@ a: I guess I could see how it could be the same bug (standing in a block gives a light level of 0). However, this one can be fixed without the other being fixed (have sky darkening read the light level at the eyes instead of the head). Fixing the other one will fix this one, though (removing sky darkening completely).
Of course, it's up to the mods to decide what they want to do.
MC-84359confirms for 15w31c.Confirmed for 1.9.
Only happens when the bottom of your hitbox is covered, not the top. You can test that by making a 1-deep hole in the ground and replacing a side of the hole with a fence, pushing a block over your head with a piston, and going into 3rd-person mode and looking around until you can see the sky. It's bright as ever.
Confirmed for 1.10.2.
Confirmed for 16w33a
Sorry, thought this was describing a different issue. Changed the summary back but can confirm this as well.
Can confirm for MC 1.12.1.
Confirmed for 1.12.2 and 17w43b. I found the root cause and sent a PR fix to the Forge project.
Seems to me that it's partially fixed in 18w22c: Sitting in a Minecart and bobbing up and down in water doesn't make the sky turn dark anymore. Standing on soul sand and snow layer 8 does turn the sky dark, still.
I can't recreate the Bug in 1.13.1-pre2 at all. All 4 Situations don't darken the sky at all.
According to Fabian Röling this was fixed in pre1.